Attachment 359030 Details for Bug 193396 – Patch

[patch] Patch

bug-193396-20190114140202.patch (text/plain), 2.06 KB, created by Zan Dobersek on 2019-01-14 05:02:03 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Zan Dobersek

Created: 2019-01-14 05:02:03 PST

Size: 2.06 KB

patch

obsolete

>Subversion Revision: 239917
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 28e33086034d8773ce7c65a530dc51753393d2a4..be792c84760d72c92d6e308b062f8bfaae49a3bd 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,21 @@
>+2019-01-14  Zan Dobersek  <zdobersek@igalia.com>
>+
>+        DOMCacheStorage: use-after-move in doSequentialMatch()
>+        https://bugs.webkit.org/show_bug.cgi?id=193396
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Depending on the platform- and compiler-specific calling conventions,
>+        the doSequentialMatch() code can move out the Vector<Ref<DOMCache>>
>+        object into the callback lambda before the DOMCache object at the
>+        specified index is retrieved for the DOMCache::doMatch() invocation.
>+
>+        This problem is now avoided by retrieving reference to the target
>+        DOMCache object in an earlier expression.
>+
>+        * Modules/cache/DOMCacheStorage.cpp:
>+        (WebCore::doSequentialMatch):
>+
> 2019-01-13  Carlos Garcia Campos  <cgarcia@igalia.com>
> 
>         [FreeType] Support emoji modifiers
>diff --git a/Source/WebCore/Modules/cache/DOMCacheStorage.cpp b/Source/WebCore/Modules/cache/DOMCacheStorage.cpp
>index bfa33771324a5c24008d6e4c3a34fb6634bab9d8..87062d12b7111bb678734fba2401d2f5d672b301 100644
>--- a/Source/WebCore/Modules/cache/DOMCacheStorage.cpp
>+++ b/Source/WebCore/Modules/cache/DOMCacheStorage.cpp
>@@ -59,7 +59,8 @@ static void doSequentialMatch(size_t index, Vector<Ref<DOMCache>>&& caches, DOMC
>         return;
>     }
> 
>-    caches[index]->doMatch(WTFMove(info), WTFMove(options), [caches = WTFMove(caches), info, options, completionHandler = WTFMove(completionHandler), index](ExceptionOr<FetchResponse*>&& result) mutable {
>+    auto& cache = caches[index].get();
>+    cache.doMatch(WTFMove(info), WTFMove(options), [caches = WTFMove(caches), info, options, completionHandler = WTFMove(completionHandler), index](ExceptionOr<FetchResponse*>&& result) mutable {
>         if (result.hasException()) {
>             completionHandler(result.releaseException());
>             return;

Actions: View | Formatted Diff | Diff

Attachments on bug 193396: 359030