Attachment 359014 Details for Bug 193391 – Patch

[patch] Patch

bug-193391-20190113200401.patch (text/plain), 2.86 KB, created by Devin Rousso on 2019-01-13 19:04:01 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Devin Rousso

Created: 2019-01-13 19:04:01 PST

Size: 2.86 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index 5f2882474395f623127c09343f1b374e695d6e4b..f7a5ccb4a6f91a7d231d671fb44fa600aedf31ea 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,17 @@
>+2019-01-13  Devin Rousso  <drousso@apple.com>
>+
>+        Web Inspector: Settings: group titles should vertically align with the first editor
>+        https://bugs.webkit.org/show_bug.cgi?id=193391
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UserInterface/Views/SettingsTabContentView.css:
>+        (.content-view.settings > .settings-view > .container):
>+        (.content-view.settings > .settings-view > .container > .editor-group > .editor): Added.
>+        (.content-view.settings > .settings-view > .container > .editor-group > .editor:first-child > *): Added.
>+        (.content-view.settings > .settings-view > .container > .editor-group > .editor select):
>+        (.content-view.settings > .settings-view > .container > .editor-group > .editor input[type="number"]):
>+
> 2019-01-11  Matt Baker  <mattbaker@apple.com>
> 
>         Web Inspector: REGRESSION: deleting an audit puts selection in a selected but invisible state
>diff --git a/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.css b/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.css
>index 458a116978c2a12696be649e357c27eaa245e334..9df6efc33e3626d9a43884c3ae2fc6fc2f2a82fb 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.css
>+++ b/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.css
>@@ -55,7 +55,6 @@
> 
> .content-view.settings > .settings-view > .container {
>     display: flex;
>-    align-items: center;
>     margin-top: 1em;
>     font-size: 13px;
> }
>@@ -85,6 +84,14 @@
>     flex-direction: column;
> }
> 
>+.content-view.settings > .settings-view > .container > .editor-group > .editor {
>+    --settings-editor-child-margin-top: 0;
>+}
>+
>+.content-view.settings > .settings-view > .container > .editor-group > .editor:first-child > * {
>+    margin-top: var(--settings-editor-child-margin-top);
>+}
>+
> .content-view.settings > .settings-view > .container > .editor-group > .editor input {
>     font-size: inherit;
> }
>@@ -103,16 +110,18 @@
>     font-size: 16px;
> 
>     /* Vertically align <select> with the group title text. */
>-    margin-top: 0;
>+    --settings-editor-child-margin-top: -2px;
> }
> 
> .content-view.settings > .settings-view > .container > .editor-group > .editor input[type="number"] {
>-    /* Vertically align <input> with the group title text. */
>-    margin-top: -1px;
>-
>     max-width: 48px;
>+    padding-top: 0;
>+    padding-bottom: 0;
>     text-align: end;
>+    vertical-align: 1px;
> 
>+    /* Vertically align <input> with the group title text. */
>+    --settings-editor-child-margin-top: -2px;
>     --settings-input-number-margin-start: 2px;
>     --settings-input-number-margin-end: 5px;
> }

Actions: View | Formatted Diff | Diff

Attachments on bug 193391: 359012 | 359013 | 359014 | 359015