Attachment 359012 Details for Bug 193391 – Patch

[patch] Patch

bug-193391-20190113194633.patch (text/plain), 2.04 KB, created by Devin Rousso on 2019-01-13 18:46:34 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Devin Rousso

Created: 2019-01-13 18:46:34 PST

Size: 2.04 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index 5f2882474395f623127c09343f1b374e695d6e4b..da69eceed6f0b97d95bb665c2c6e26ccbcf1a34e 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,15 @@
>+2019-01-13  Devin Rousso  <drousso@apple.com>
>+
>+        Web Inspector: Settings: group titles should vertically align with the first editor
>+        https://bugs.webkit.org/show_bug.cgi?id=193391
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UserInterface/Views/SettingsTabContentView.css:
>+        (.content-view.settings > .settings-view > .container):
>+        (.content-view.settings > .settings-view > .container > .editor-group > .editor:first-child input): Added.
>+        (.content-view.settings > .settings-view > .container > .editor-group > .editor:last-child input): Added.
>+
> 2019-01-11  Matt Baker  <mattbaker@apple.com>
> 
>         Web Inspector: REGRESSION: deleting an audit puts selection in a selected but invisible state
>diff --git a/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.css b/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.css
>index 458a116978c2a12696be649e357c27eaa245e334..e50f21082c8b45f10fdf5ae2602bb1f5d4b6b031 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.css
>+++ b/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.css
>@@ -55,7 +55,6 @@
> 
> .content-view.settings > .settings-view > .container {
>     display: flex;
>-    align-items: center;
>     margin-top: 1em;
>     font-size: 13px;
> }
>@@ -89,6 +88,14 @@
>     font-size: inherit;
> }
> 
>+.content-view.settings > .settings-view > .container > .editor-group > .editor:first-child input {
>+    margin-top: 0;
>+}
>+
>+.content-view.settings > .settings-view > .container > .editor-group > .editor:last-child input {
>+    margin-bottom: 0;
>+}
>+
> .content-view.settings > .settings-view > .container > .editor-group > .editor input[type="checkbox"] {
>     -webkit-margin-end: 4px;
>     /* Vertically align <select> with the group title text. */

Actions: View | Formatted Diff | Diff

Attachments on bug 193391: 359012 | 359013 | 359014 | 359015