Attachment 358999 Details for Bug 193384 – Patch

[patch] Patch

bug-193384-20190112202327.patch (text/plain), 1.69 KB, created by Devin Rousso on 2019-01-12 19:23:28 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Devin Rousso

Created: 2019-01-12 19:23:28 PST

Size: 1.69 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index 5f2882474395f623127c09343f1b374e695d6e4b..885ea385ce51f23f37dc2b0ece7326cb4241cd76 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,13 @@
>+2019-01-12  Devin Rousso  <drousso@apple.com>
>+
>+        Web Inspector: Event breakpoints: typing uppercase "DOM" doesn't show completions for events that start with "DOM"
>+        https://bugs.webkit.org/show_bug.cgi?id=193384
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UserInterface/Views/EventBreakpointPopover.js:
>+        (WI.EventBreakpointPopover.prototype.show):
>+
> 2019-01-11  Matt Baker  <mattbaker@apple.com>
> 
>         Web Inspector: REGRESSION: deleting an audit puts selection in a selected but invisible state
>diff --git a/Source/WebInspectorUI/UserInterface/Views/EventBreakpointPopover.js b/Source/WebInspectorUI/UserInterface/Views/EventBreakpointPopover.js
>index c38ba0a9d90b8c80e8a79d10487bf6fcd65f0671..3a743d57baf7cec800d733d0938a369e607c6472 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/EventBreakpointPopover.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/EventBreakpointPopover.js
>@@ -106,7 +106,7 @@ WI.EventBreakpointPopover = class EventBreakpointPopover extends WI.Popover
>             .then((eventNames) => {
>                 this._currentCompletions = [];
>                 for (let eventName of eventNames) {
>-                    if (eventName.toLowerCase().startsWith(this._domEventNameInputElement.value))
>+                    if (eventName.toLowerCase().startsWith(this._domEventNameInputElement.value.toLowerCase()))
>                         this._currentCompletions.push(eventName);
>                 }
>

Actions: View | Formatted Diff | Diff

Attachments on bug 193384: 358999