WebKit Bugzilla
Attachment 358981 Details for
Bug 193376
: Enable visual viewport API by default
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Enables the feature by deafult
bug-193376-20190111211403.patch (text/plain), 2.79 KB, created by
Ryosuke Niwa
on 2019-01-11 21:14:03 PST
(
hide
)
Description:
Enables the feature by deafult
Filename:
MIME Type:
Creator:
Ryosuke Niwa
Created:
2019-01-11 21:14:03 PST
Size:
2.79 KB
patch
obsolete
>Subversion Revision: 239871 >diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog >index d53cc33c6927e61aa4e69dae90da8051257de925..9e62ee98580e7381e969301cbea673a3937bf5a0 100644 >--- a/Source/WebKit/ChangeLog >+++ b/Source/WebKit/ChangeLog >@@ -1,3 +1,15 @@ >+2019-01-11 Ryosuke Niwa <rniwa@webkit.org> >+ >+ Enable visual viewport API by default >+ https://bugs.webkit.org/show_bug.cgi?id=193376 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ Enable this feature by default since the remaining issue on iOS is mostly about test failures, >+ not an issue with the core functionality of the API. >+ >+ * Shared/WebPreferences.yaml: >+ > 2019-01-11 Wenson Hsieh <wenson_hsieh@apple.com> > > Introduce IDL files for runtime-enabled UndoManager and UndoItem JavaScript API >diff --git a/Source/WebKitLegacy/mac/ChangeLog b/Source/WebKitLegacy/mac/ChangeLog >index fdcf2eeb48b84dad147a8751bf8b344e0d260fe3..b7ce6a289f1da6b80a97a1e15aa3755d771fd186 100644 >--- a/Source/WebKitLegacy/mac/ChangeLog >+++ b/Source/WebKitLegacy/mac/ChangeLog >@@ -1,3 +1,13 @@ >+2019-01-11 Ryosuke Niwa <rniwa@webkit.org> >+ >+ Enable visual viewport API by default >+ https://bugs.webkit.org/show_bug.cgi?id=193376 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * WebView/WebPreferences.mm: >+ (+[WebPreferences initialize]): >+ > 2019-01-08 Alex Christensen <achristensen@webkit.org> > > Stop using NetworkStorageSession in WebProcess >diff --git a/Source/WebKit/Shared/WebPreferences.yaml b/Source/WebKit/Shared/WebPreferences.yaml >index bcfa73faedfbfd21a0155adcbf643bf5ce1477eb..91020b3cab915c5ed836cc5aebb53410862f5195 100644 >--- a/Source/WebKit/Shared/WebPreferences.yaml >+++ b/Source/WebKit/Shared/WebPreferences.yaml >@@ -1240,7 +1240,7 @@ IntersectionObserverEnabled: > > VisualViewportAPIEnabled: > type: bool >- defaultValue: DEFAULT_EXPERIMENTAL_FEATURES_ENABLED >+ defaultValue: true > humanReadableName: "Visual Viewport API" > humanReadableDescription: "Enable Visual Viewport API" > category: experimental >diff --git a/Source/WebKitLegacy/mac/WebView/WebPreferences.mm b/Source/WebKitLegacy/mac/WebView/WebPreferences.mm >index 22aa954cd61d01d4039796e9a12945380adbb49a..789ca9cbeb521bd468ff9bae163f9c8980a8f2fd 100644 >--- a/Source/WebKitLegacy/mac/WebView/WebPreferences.mm >+++ b/Source/WebKitLegacy/mac/WebView/WebPreferences.mm >@@ -654,7 +654,7 @@ + (void)initialize > #else > [NSNumber numberWithBool:YES], WebKitVisualViewportEnabledPreferenceKey, > #endif >- [NSNumber numberWithBool:NO], WebKitVisualViewportAPIEnabledPreferenceKey, >+ [NSNumber numberWithBool:YES], WebKitVisualViewportAPIEnabledPreferenceKey, > > [NSNumber numberWithBool:NO], WebKitCSSOMViewScrollingAPIEnabledPreferenceKey, > [NSNumber numberWithBool:YES], WebKitNeedsStorageAccessFromFileURLsQuirkKey,
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 193376
: 358981