Attachment 358913 Details for Bug 193353 – Patch

[patch] Patch

bug-193353-20190111112031.patch (text/plain), 4.11 KB, created by Matt Rajca on 2019-01-11 11:20:32 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Matt Rajca

Created: 2019-01-11 11:20:32 PST

Size: 4.11 KB

patch

obsolete

>Subversion Revision: 239830
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 9e87978267a186cc8d8ab4082c2705770e5f2e3a..a96ebf46873fe26e805371da8fed228a66a21aa6 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,15 @@
>+2019-01-11  Matt Rajca  <mrajca@apple.com>
>+
>+        Expose preference for site-specific quirks on iOS
>+        https://bugs.webkit.org/show_bug.cgi?id=193353
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UIProcess/API/Cocoa/WKPreferences.mm:
>+        (-[WKPreferences _setNeedsSiteSpecificQuirks:]):
>+        (-[WKPreferences _needsSiteSpecificQuirks]):
>+        * UIProcess/API/Cocoa/WKPreferencesPrivate.h:
>+
> 2019-01-09  Matt Rajca  <mrajca@apple.com>
> 
>         Put per-document autoplay behavior behind runtime website policies quirk instead of a compile time flag
>diff --git a/Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm b/Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm
>index 3ac5b5c8601b9f973995137db339e7b70b323aec..3b46ecd2da4cd081f555223e12e0d155decaf01e 100644
>--- a/Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm
>+++ b/Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm
>@@ -829,6 +829,16 @@ - (BOOL)_shouldIgnoreMetaViewport
>     return _preferences->shouldIgnoreMetaViewport();
> }
> 
>+- (void)_setNeedsSiteSpecificQuirks:(BOOL)enabled
>+{
>+    _preferences->setNeedsSiteSpecificQuirks(enabled);
>+}
>+
>+- (BOOL)_needsSiteSpecificQuirks
>+{
>+    return _preferences->needsSiteSpecificQuirks();
>+}
>+
> #if PLATFORM(MAC)
> - (void)_setJavaEnabledForLocalFiles:(BOOL)enabled
> {
>@@ -870,16 +880,6 @@ - (NSString *)_defaultTextEncodingName
>     return _preferences->defaultTextEncodingName();
> }
> 
>-- (void)_setNeedsSiteSpecificQuirks:(BOOL)enabled
>-{
>-    _preferences->setNeedsSiteSpecificQuirks(enabled);
>-}
>-
>-- (BOOL)_needsSiteSpecificQuirks
>-{
>-    return _preferences->needsSiteSpecificQuirks();
>-}
>-
> - (void)_setAuthorAndUserStylesEnabled:(BOOL)enabled
> {
>     _preferences->setAuthorAndUserStylesEnabled(enabled);
>diff --git a/Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h b/Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h
>index af64c612382b780c0543331417734d1be96a49d5..63be4d523a15d8ab6cdd9e9b4938343943c6c714 100644
>--- a/Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h
>+++ b/Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h
>@@ -151,6 +151,7 @@ typedef NS_ENUM(NSInteger, _WKEditableLinkBehavior) {
> @property (nonatomic, setter=_setVideoQualityIncludesDisplayCompositingEnabled:) BOOL _videoQualityIncludesDisplayCompositingEnabled WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA));
> @property (nonatomic, setter=_setWebAnimationsCSSIntegrationEnabled:) BOOL _webAnimationsCSSIntegrationEnabled WK_API_AVAILABLE(macosx(10.14), ios(WK_IOS_TBA));
> @property (nonatomic, setter=_setDeviceOrientationEventEnabled:) BOOL _deviceOrientationEventEnabled WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA));
>+@property (nonatomic, setter=_setNeedsSiteSpecificQuirks:) BOOL _needsSiteSpecificQuirks WK_API_AVAILABLE(macosx(10.13.4), ios(WK_IOS_TBA));
> 
> #if !TARGET_OS_IPHONE
> @property (nonatomic, setter=_setWebGLEnabled:) BOOL _webGLEnabled WK_API_AVAILABLE(macosx(10.13.4));
>@@ -158,7 +159,6 @@ typedef NS_ENUM(NSInteger, _WKEditableLinkBehavior) {
> @property (nonatomic, setter=_setCanvasUsesAcceleratedDrawing:) BOOL _canvasUsesAcceleratedDrawing WK_API_AVAILABLE(macosx(10.13.4));
> @property (nonatomic, setter=_setAcceleratedCompositingEnabled:) BOOL _acceleratedCompositingEnabled WK_API_AVAILABLE(macosx(10.13.4));
> @property (nonatomic, setter=_setDefaultTextEncodingName:) NSString *_defaultTextEncodingName WK_API_AVAILABLE(macosx(10.13.4));
>-@property (nonatomic, setter=_setNeedsSiteSpecificQuirks:) BOOL _needsSiteSpecificQuirks WK_API_AVAILABLE(macosx(10.13.4));
> @property (nonatomic, setter=_setAuthorAndUserStylesEnabled:) BOOL _authorAndUserStylesEnabled WK_API_AVAILABLE(macosx(10.13.4));
> @property (nonatomic, setter=_setDOMTimersThrottlingEnabled:) BOOL _domTimersThrottlingEnabled WK_API_AVAILABLE(macosx(10.13.4));
> @property (nonatomic, setter=_setWebArchiveDebugModeEnabled:) BOOL _webArchiveDebugModeEnabled WK_API_AVAILABLE(macosx(10.13.4));

Flags:

dino: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 193353: 358913