Attachment 358862 Details for Bug 193345 – [PATCH] Proposed Fix

[patch] [PATCH] Proposed Fix

blank-1.patch (text/plain), 1.19 KB, created by Joseph Pecoraro on 2019-01-10 19:17:07 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Joseph Pecoraro

Created: 2019-01-10 19:17:07 PST

Size: 1.19 KB

patch

obsolete

>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 392c7e6de5f..5526e380890 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,14 @@
>+2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
>+
>+        MiniBrowser should be able to navigate to about:blank
>+        https://bugs.webkit.org/show_bug.cgi?id=193345
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * MiniBrowser/mac/BrowserWindowController.m:
>+        (-[BrowserWindowController addProtocolIfNecessary:]):
>+        Don't prepend "http://" to "about:" prefixed URLs like "about:blank".
>+
> 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
> 
>         Remove MiniBrowser custom "Process Swap" menu item which does not work
>diff --git a/Tools/MiniBrowser/mac/BrowserWindowController.m b/Tools/MiniBrowser/mac/BrowserWindowController.m
>index 2817dab8144..4b99057a03c 100644
>--- a/Tools/MiniBrowser/mac/BrowserWindowController.m
>+++ b/Tools/MiniBrowser/mac/BrowserWindowController.m
>@@ -65,6 +65,9 @@ - (NSString *)addProtocolIfNecessary:(NSString *)address
>     if ([address hasPrefix:@"data:"])
>         return address;
> 
>+    if ([address hasPrefix:@"about:"])
>+        return address;
>+
>     return [@"http://" stringByAppendingString:address];
> }
>

Actions: View | Formatted Diff | Diff

Attachments on bug 193345: 358862 | 358863