Attachment 358834 Details for Bug 193338 – [PATCH] Proposed Fix

[patch] [PATCH] Proposed Fix

no-leak-1.patch (text/plain), 1.99 KB, created by Joseph Pecoraro on 2019-01-10 14:14:50 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Joseph Pecoraro

Created: 2019-01-10 14:14:50 PST

Size: 1.99 KB

patch

obsolete

>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index d5fb0a31b69..878fe252611 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,14 @@
>+2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
>+
>+        Leak of WKWebProcessPlugInHitTestResult (160 bytes) in com.apple.WebKit.WebContent running layout tests
>+        https://bugs.webkit.org/show_bug.cgi?id=193338
>+        <rdar://problem/46664774>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
>+        (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
>+
> 2019-01-07  Eric Carlson  <eric.carlson@apple.com>
> 
>         A MediaTime timescale must never be zero
>diff --git a/Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp b/Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp
>index 96c89d5a18e..f6ce4944cf9 100644
>--- a/Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp
>+++ b/Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp
>@@ -1372,10 +1372,11 @@ WKBundlePagePolicyAction InjectedBundlePage::decidePolicyForNavigationAction(WKB
>     stringBuilder.appendLiteral(" with navigation type \'");
>     stringBuilder.append(toWTFString(NavigationTypeToString(WKBundleNavigationActionGetNavigationType(navigationAction))));
>     stringBuilder.appendLiteral("\'");
>-    WKBundleHitTestResultRef hitTestResultRef = WKBundleNavigationActionCopyHitTestResult(navigationAction);
>+    WKRetainPtr<WKBundleHitTestResultRef> hitTestResultRef = adoptWK(WKBundleNavigationActionCopyHitTestResult(navigationAction));
>     if (hitTestResultRef) {
>+        WKRetainPtr<WKBundleNodeHandleRef> nodeHandleRef = adoptWK(WKBundleHitTestResultCopyNodeHandle(hitTestResultRef.get()));
>         stringBuilder.appendLiteral(" originating from ");
>-        stringBuilder.append(dumpPath(m_page, m_world.get(), WKBundleHitTestResultCopyNodeHandle(hitTestResultRef)));
>+        stringBuilder.append(dumpPath(m_page, m_world.get(), nodeHandleRef.get()));
>     }
> 
>     stringBuilder.append('\n');

Actions: View | Formatted Diff | Diff

Attachments on bug 193338: 358834