Attachment 358829 Details for Bug 193336 – Patch

[patch] Patch

bug-193336-20190110145821.patch (text/plain), 2.83 KB, created by Devin Rousso on 2019-01-10 13:58:22 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Devin Rousso

Created: 2019-01-10 13:58:22 PST

Size: 2.83 KB

patch

obsolete

>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 91dffd13cebfba59723abc8f9632a8beb670df4c..150bd928421cb4b43eb63645220df7789daf5407 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,15 @@
>+2019-01-10  Devin Rousso  <drousso@apple.com>
>+
>+        Web Inspector: extend overlay element bounds lines to the right/below as well
>+        https://bugs.webkit.org/show_bug.cgi?id=193336
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This patch is purely a visual change for WebInspector, and doesn't affect anything else.
>+
>+        * inspector/InspectorOverlayPage.js:
>+        (_drawBounds):
>+
> 2019-01-09  Alex Christensen  <achristensen@webkit.org>
> 
>         REGRESSION(239737) iOS quicklook tests should not dereference null
>diff --git a/Source/WebCore/inspector/InspectorOverlayPage.js b/Source/WebCore/inspector/InspectorOverlayPage.js
>index dfefcd3a6570e49278607e94a386c6d2c69000b6..a645fa13391e6bad68c97530349260c1dd59e5f0 100644
>--- a/Source/WebCore/inspector/InspectorOverlayPage.js
>+++ b/Source/WebCore/inspector/InspectorOverlayPage.js
>@@ -426,25 +426,43 @@ function _drawOutlinedQuadWithClip(quad, clipQuad, fillColor, bounds)
> function _drawBounds(bounds)
> {
>     _isolateActions(() => {
>-        let startX = DATA.contentInset.width;
>-        let startY = DATA.contentInset.height;
>+        let minX = DATA.contentInset.width;
>+        let maxX = DATA.viewportSize.width;
>+        let minY = DATA.contentInset.height;
>+        let maxY = DATA.viewportSize.height;
> 
>         context.beginPath();
> 
>-        if (bounds.minY - startY > 0) {
>+        if (bounds.minY > minY) {
>             context.moveTo(bounds.minX, bounds.minY);
>-            context.lineTo(bounds.minX, startY);
>+            context.lineTo(bounds.minX, minY);
> 
>             context.moveTo(bounds.maxX, bounds.minY);
>-            context.lineTo(bounds.maxX, startY);
>+            context.lineTo(bounds.maxX, minY);
>         }
> 
>-        if (bounds.minX - startX > 0) {
>+        if (bounds.maxY < maxY) {
>+            context.moveTo(bounds.minX, bounds.maxY);
>+            context.lineTo(bounds.minX, maxY);
>+
>+            context.moveTo(bounds.maxX, bounds.maxY);
>+            context.lineTo(bounds.maxX, maxY);
>+        }
>+
>+        if (bounds.minX > minX) {
>             context.moveTo(bounds.minX, bounds.minY);
>-            context.lineTo(startX, bounds.minY);
>+            context.lineTo(minX, bounds.minY);
> 
>             context.moveTo(bounds.minX, bounds.maxY);
>-            context.lineTo(startX, bounds.maxY);
>+            context.lineTo(minX, bounds.maxY);
>+        }
>+
>+        if (bounds.maxX < maxX) {
>+            context.moveTo(bounds.maxX, bounds.minY);
>+            context.lineTo(maxX, bounds.minY);
>+
>+            context.moveTo(bounds.maxX, bounds.maxY);
>+            context.lineTo(maxX, bounds.maxY);
>         }
> 
>         context.lineWidth = 1;

Actions: View | Formatted Diff | Diff

Attachments on bug 193336: 358829 | 358830