Attachment 358821 Details for Bug 193332 – Patch

[patch] Patch

bug-193332-20190110205144.patch (text/plain), 2.19 KB, created by Charlie Turner on 2019-01-10 12:51:45 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Charlie Turner

Created: 2019-01-10 12:51:45 PST

Size: 2.19 KB

patch

obsolete

>Subversion Revision: 239816
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 291b276c7e458b758eae72ba98721aa106770711..daddba39d35fa78563b7a8cb3d3309ade5962105 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,20 @@
>+2019-01-10  Charlie Turner  <cturner@igalia.com>
>+
>+        [WPE] Workaround for incorrect template specialization being selected when UChar=char16_t
>+        https://bugs.webkit.org/show_bug.cgi?id=193332
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: When UChar is
>+        defined as a char16_t, which changed in ICU 59, the
>+        StringTypeAdapter<UnsignedInt, ...> overload catches casts to
>+        unsigned short. This test is relying on the behaviour that
>+        UChar=unsigned short, which doesn't hold across platforms and ICU
>+        library versions. The full fix would be a special syntax for
>+        literal characters so that these ambiguities do not arise. That
>+        work is proposed in https://bugs.webkit.org/show_bug.cgi?id=193101.
>+        (TestWebKitAPI::TEST):
>+
> 2019-01-09  Fujii Hironori  <Hironori.Fujii@sony.com>
> 
>         [Win][MiniBrowser] wchar_t strings shouldn't be treated as BSTR
>diff --git a/Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp b/Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp
>index 388b30e3086fc3e1a58b9dc1f9a24494e7aaa5dd..ee7004a4f5979c9891d4eded97345dce0c42033d 100644
>--- a/Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp
>+++ b/Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp
>@@ -30,6 +30,7 @@
> #include <wtf/text/StringConcatenateNumbers.h>
> #include <cstddef>
> #include <cstdint>
>+#include <unicode/uvernum.h>
> 
> namespace TestWebKitAPI {
> 
>@@ -81,7 +82,7 @@ TEST(WTF, StringConcatenate_Unsigned)
>     EXPECT_EQ("hello 0 world", makeString("hello ", 0u , " world"));
> 
>     EXPECT_EQ("hello 42 world", makeString("hello ", static_cast<unsigned char>(42) , " world"));
>-#if PLATFORM(WIN)
>+#if PLATFORM(WIN) || U_ICU_VERSION_MAJOR_NUM >= 59
>     EXPECT_EQ("hello 42 world", makeString("hello ", static_cast<unsigned short>(42) , " world"));
> #else
>     EXPECT_EQ("hello * world", makeString("hello ", static_cast<unsigned short>(42) , " world")); // Treated as a character.

Actions: View | Formatted Diff | Diff

Attachments on bug 193332: 358821 | 359023