Attachment 358814 Details for Bug 193330 – ROLLOUT of r239825

[patch] ROLLOUT of r239825

bug-193330-20190110120100.patch (text/plain), 18.83 KB, created by WebKit Commit Bot on 2019-01-10 12:01:00 PST

(hide)

Description:

Filename:

MIME Type:

Creator: WebKit Commit Bot

Created: 2019-01-10 12:01:00 PST

Size: 18.83 KB

patch

obsolete

>Subversion Revision: 239837
>diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
>index 65a5e57564df791aca371c79e183a63288b38194..416edca548a62648c440fad2fa6bb52919d60cd9 100644
>--- a/Source/JavaScriptCore/ChangeLog
>+++ b/Source/JavaScriptCore/ChangeLog
>@@ -1,3 +1,17 @@
>+2019-01-10  Commit Queue  <commit-queue@webkit.org>
>+
>+        Unreviewed, rolling out r239825.
>+        https://bugs.webkit.org/show_bug.cgi?id=193330
>+
>+        Broke tests on armv7/linux bots (Requested by guijemont on
>+        #webkit).
>+
>+        Reverted changeset:
>+
>+        "Enable DFG on ARM/Linux again"
>+        https://bugs.webkit.org/show_bug.cgi?id=192496
>+        https://trac.webkit.org/changeset/239825
>+
> 2019-01-10  Dominik Infuehr  <dinfuehr@igalia.com>
> 
>         Enable DFG on ARM/Linux again
>diff --git a/Source/WTF/ChangeLog b/Source/WTF/ChangeLog
>index 786ba97cd9fc9d889758350ed41697a79f6fae13..324ee663464605d24ceef2e3a49f8caa8b9866a6 100644
>--- a/Source/WTF/ChangeLog
>+++ b/Source/WTF/ChangeLog
>@@ -1,3 +1,17 @@
>+2019-01-10  Commit Queue  <commit-queue@webkit.org>
>+
>+        Unreviewed, rolling out r239825.
>+        https://bugs.webkit.org/show_bug.cgi?id=193330
>+
>+        Broke tests on armv7/linux bots (Requested by guijemont on
>+        #webkit).
>+
>+        Reverted changeset:
>+
>+        "Enable DFG on ARM/Linux again"
>+        https://bugs.webkit.org/show_bug.cgi?id=192496
>+        https://trac.webkit.org/changeset/239825
>+
> 2019-01-10  John Wilander  <wilander@apple.com>
> 
>         Override the session configuration for cookieAcceptPolicy
>diff --git a/Source/JavaScriptCore/assembler/AbstractMacroAssembler.h b/Source/JavaScriptCore/assembler/AbstractMacroAssembler.h
>index f9d0030a21ef41f049c878e0ce25d001dd161ac4..137854066d01b5ef8a7f53027c21d912de9f24a4 100644
>--- a/Source/JavaScriptCore/assembler/AbstractMacroAssembler.h
>+++ b/Source/JavaScriptCore/assembler/AbstractMacroAssembler.h
>@@ -749,7 +749,7 @@ public:
>             m_jumps.append(other.m_jumps.begin(), other.m_jumps.size());
>         }
> 
>-        bool empty() const
>+        bool empty()
>         {
>             return !m_jumps.size();
>         }
>diff --git a/Source/JavaScriptCore/dfg/DFGOSRExit.cpp b/Source/JavaScriptCore/dfg/DFGOSRExit.cpp
>index 6d464f3dfb8d24beae17e881a8dbd09cc1a8efc3..069cf85a9ff38baa364c78ab86fb4d19de93ec6d 100644
>--- a/Source/JavaScriptCore/dfg/DFGOSRExit.cpp
>+++ b/Source/JavaScriptCore/dfg/DFGOSRExit.cpp
>@@ -75,6 +75,8 @@ static JSValue jsValueFor(CPUState& cpu, JSValueSource source)
> 
> #if NUMBER_OF_CALLEE_SAVES_REGISTERS > 0
> 
>+static_assert(is64Bit(), "we only support callee save registers on 64-bit");
>+
> // Based on AssemblyHelpers::emitRestoreCalleeSavesFor().
> static void restoreCalleeSavesFor(Context& context, CodeBlock* codeBlock)
> {
>@@ -135,14 +137,8 @@ static void restoreCalleeSavesFromVMEntryFrameCalleeSavesBuffer(Context& context
>         size_t uintptrOffset = entry.offset() / sizeof(UCPURegister);
>         if (entry.reg().isGPR())
>             context.gpr(entry.reg().gpr()) = calleeSaveBuffer[uintptrOffset];
>-        else {
>-#if USE(JSVALUE64)
>+        else
>             context.fpr(entry.reg().fpr()) = bitwise_cast<double>(calleeSaveBuffer[uintptrOffset]);
>-#else
>-            // FIXME: <https://webkit.org/b/193275> support callee-saved floating point registers on 32-bit architectures
>-            RELEASE_ASSERT_NOT_REACHED();
>-#endif
>-        }
>     }
> }
> 
>@@ -165,14 +161,8 @@ static void copyCalleeSavesToVMEntryFrameCalleeSavesBuffer(Context& context)
>             continue;
>         if (entry.reg().isGPR())
>             stack.set(calleeSaveBuffer, entry.offset(), context.gpr<UCPURegister>(entry.reg().gpr()));
>-        else {
>-#if USE(JSVALUE64)
>+        else
>             stack.set(calleeSaveBuffer, entry.offset(), context.fpr<UCPURegister>(entry.reg().fpr()));
>-#else
>-            // FIXME: <https://webkit.org/b/193275> support callee-saved floating point registers on 32-bit architectures
>-            RELEASE_ASSERT_NOT_REACHED();
>-#endif
>-        }
>     }
> }
> 
>diff --git a/Source/JavaScriptCore/jit/CallFrameShuffler.cpp b/Source/JavaScriptCore/jit/CallFrameShuffler.cpp
>index 81c3e2d4b8a7bec0a062dbf21be20c5266a898ae..6df81e1a9cb89d66569f57cc90b78d4660235782 100644
>--- a/Source/JavaScriptCore/jit/CallFrameShuffler.cpp
>+++ b/Source/JavaScriptCore/jit/CallFrameShuffler.cpp
>@@ -51,14 +51,8 @@ CallFrameShuffler::CallFrameShuffler(CCallHelpers& jit, const CallFrameShuffleDa
>         m_lockedRegisters.clear(GPRInfo::toRegister(i));
>     for (unsigned i = FPRInfo::numberOfRegisters; i--; )
>         m_lockedRegisters.clear(FPRInfo::toRegister(i));
>-
>-#if USE(JSVALUE64)
>-    // ... as well as the runtime registers on 64-bit architectures.
>-    // However do not use these registers on 32-bit architectures since
>-    // saving and restoring callee-saved registers in CallFrameShuffler isn't supported
>-    // on 32-bit architectures yet.
>+    // ... as well as the runtime registers.
>     m_lockedRegisters.exclude(RegisterSet::vmCalleeSaveRegisters());
>-#endif
> 
>     ASSERT(!data.callee.isInJSStack() || data.callee.virtualRegister().isLocal());
>     addNew(VirtualRegister(CallFrameSlot::callee), data.callee);
>diff --git a/Source/JavaScriptCore/jit/GPRInfo.h b/Source/JavaScriptCore/jit/GPRInfo.h
>index 175d53088fc75d1a83df17a6d7a259efd4520fc9..1a0a5c9742b4db7cdea8c8965536c30e9b9fa765 100644
>--- a/Source/JavaScriptCore/jit/GPRInfo.h
>+++ b/Source/JavaScriptCore/jit/GPRInfo.h
>@@ -526,9 +526,13 @@ public:
> 
> #endif // CPU(X86_64)
> 
>-#if CPU(ARM_THUMB2)
>+#if CPU(ARM)
> #define NUMBER_OF_ARGUMENT_REGISTERS 4u
>+#if CPU(ARM_THUMB2)
> #define NUMBER_OF_CALLEE_SAVES_REGISTERS 1u
>+#else
>+#define NUMBER_OF_CALLEE_SAVES_REGISTERS 0u
>+#endif
> 
> class GPRInfo {
> public:
>@@ -544,7 +548,11 @@ public:
>     static const GPRReg regT4 = ARMRegisters::r8;
>     static const GPRReg regT5 = ARMRegisters::r9;
>     static const GPRReg regT6 = ARMRegisters::r10;
>-    static const GPRReg regT7 = ARMRegisters::r5;
>+#if CPU(ARM_THUMB2)
>+    static const GPRReg regT7 = ARMRegisters::r11;
>+#else 
>+    static const GPRReg regT7 = ARMRegisters::r7;
>+#endif
>     static const GPRReg regT8 = ARMRegisters::r4;
>     static const GPRReg regCS0 = ARMRegisters::r11;
>     // These registers match the baseline JIT.
>@@ -579,7 +587,11 @@ public:
>         ASSERT(reg != InvalidGPRReg);
>         ASSERT(static_cast<int>(reg) < 16);
>         static const unsigned indexForRegister[16] =
>-            { 0, 1, 2, 3, 8, 7, InvalidIndex, InvalidIndex, 4, 5, 6, InvalidIndex, InvalidIndex, InvalidIndex, InvalidIndex, InvalidIndex };
>+#if CPU(ARM_THUMB2)
>+            { 0, 1, 2, 3, 8, InvalidIndex, InvalidIndex, InvalidIndex, 4, 5, 6, 7, InvalidIndex, InvalidIndex, InvalidIndex, InvalidIndex };
>+#else
>+            { 0, 1, 2, 3, 8, InvalidIndex, InvalidIndex, 7, 4, 5, 6, InvalidIndex, InvalidIndex, InvalidIndex, InvalidIndex, InvalidIndex };
>+#endif
>         unsigned result = indexForRegister[reg];
>         return result;
>     }
>diff --git a/Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm b/Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm
>index a505a557aa6dc4b6ed7b034a67d34b60956d8c6f..05b3a69556d7da2b44f3c5ab6fe1a3bcbe150e44 100644
>--- a/Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm
>+++ b/Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm
>@@ -2012,11 +2012,6 @@ end)
> 
> 
> op(llint_throw_from_slow_path_trampoline, macro()
>-    loadp Callee[cfr], t1
>-    andp MarkedBlockMask, t1
>-    loadp MarkedBlockFooterOffset + MarkedBlock::Footer::m_vm[t1], t1
>-    copyCalleeSavesToVMEntryFrameCalleeSavesBuffer(t1, t2)
>-
>     callSlowPath(_llint_slow_path_handle_exception)
> 
>     # When throwing from the interpreter (i.e. throwing from LLIntSlowPaths), so
>@@ -2025,6 +2020,7 @@ op(llint_throw_from_slow_path_trampoline, macro()
>     loadp Callee[cfr], t1
>     andp MarkedBlockMask, t1
>     loadp MarkedBlockFooterOffset + MarkedBlock::Footer::m_vm[t1], t1
>+    copyCalleeSavesToVMEntryFrameCalleeSavesBuffer(t1, t2)
>     jmp VM::targetMachinePCForThrow[t1]
> end)
> 
>diff --git a/Source/JavaScriptCore/offlineasm/arm.rb b/Source/JavaScriptCore/offlineasm/arm.rb
>index 85e0b8ec5b2f6a8960362a3174c615bd0b554032..d78b82eef81fe3c61930f0f4cff6e0a6d386b4cd 100644
>--- a/Source/JavaScriptCore/offlineasm/arm.rb
>+++ b/Source/JavaScriptCore/offlineasm/arm.rb
>@@ -34,7 +34,7 @@ require "risc"
> #  x2 => t2, a2, r2
> #  x3 => t3, a3, r3
> #  x6 =>            (callee-save scratch)
>-#  x7 => cfr
>+#  x7 => cfr        (ARMv7 only)
> #  x8 => t4         (callee-save)
> #  x9 => t5         (callee-save)
> # x10 =>            (callee-save scratch)
>@@ -55,6 +55,15 @@ require "risc"
> # d6 =>              (scratch)
> # d7 =>              (scratch)
> 
>+def isARMv7
>+    case $activeBackend
>+    when "ARMv7"
>+        true
>+    else
>+        raise "bad value for $activeBackend: #{$activeBackend}"
>+    end
>+end
>+
> class Node
>     def armSingle
>         doubleOperand = armOperand
>@@ -82,11 +91,13 @@ def armMoveImmediate(value, register)
>         $asm.puts "mov #{register.armOperand}, \##{value}"
>     elsif (~value) >= 0 && (~value) < 256
>         $asm.puts "mvn #{register.armOperand}, \##{~value}"
>-    else
>+    elsif isARMv7
>         $asm.puts "movw #{register.armOperand}, \##{value & 0xffff}"
>         if (value & 0xffff0000) != 0
>             $asm.puts "movt #{register.armOperand}, \##{(value >> 16) & 0xffff}"
>         end
>+    else
>+        $asm.puts "ldr #{register.armOperand}, =#{value}"
>     end
> end
> 
>@@ -108,7 +119,7 @@ class RegisterID
>         when "t5"
>             "r9"
>         when "cfr"
>-            "r7"
>+            isARMv7 ?  "r7" : "r11"
>         when "csr0"
>             "r11"
>         when "lr"
>@@ -598,6 +609,9 @@ class Instruction
>             else
>                 $asm.puts "mov pc, #{operands[0].armOperand}"
>             end
>+            if not isARMv7 and not isARMv7Traditional
>+                $asm.puts ".ltorg"
>+            end
>         when "call"
>             if operands[0].label?
>                 if OS_DARWIN
>@@ -678,7 +692,7 @@ class Instruction
>             $asm.puts "add #{dest.armOperand}, pc, #{dest.armOperand}"
>             $asm.puts "ldr #{dest.armOperand}, [#{dest.armOperand}, #{temp.armOperand}]"
> 
>-            offset = 4
>+            offset = $activeBackend == "ARMv7" ? 4 : 8
> 
>             $asm.deferNextLabelAction {
>                 $asm.puts "#{gotLabel}:"
>diff --git a/Source/WTF/wtf/Platform.h b/Source/WTF/wtf/Platform.h
>index a574b04eb32d3188820f04ddb7ddba9036a3c973..8e1aa52c4f0d5a1755595b620f1ad182e3060165 100644
>--- a/Source/WTF/wtf/Platform.h
>+++ b/Source/WTF/wtf/Platform.h
>@@ -760,6 +760,9 @@
> #if !defined(ENABLE_JIT)
> #define ENABLE_JIT 1
> #endif
>+/* But still disable DFG for now. */
>+#undef ENABLE_DFG_JIT
>+#define ENABLE_DFG_JIT 0
> #else
> /* Disable JIT and force C_LOOP on all 32bit-architectures but ARMv7-Thumb2/Linux. */
> #undef ENABLE_JIT
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index f0adc259ab0b11bf12877c6406e36534b985b2f7..cd5f8e9da55f0db31095a33719584575ab5e3f5b 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,17 @@
>+2019-01-10  Commit Queue  <commit-queue@webkit.org>
>+
>+        Unreviewed, rolling out r239825.
>+        https://bugs.webkit.org/show_bug.cgi?id=193330
>+
>+        Broke tests on armv7/linux bots (Requested by guijemont on
>+        #webkit).
>+
>+        Reverted changeset:
>+
>+        "Enable DFG on ARM/Linux again"
>+        https://bugs.webkit.org/show_bug.cgi?id=192496
>+        https://trac.webkit.org/changeset/239825
>+
> 2019-01-10  Zhifei Fang  <zhifei_fang@apple.com>
> 
>         Disable the run-jsc-stress-test remote host key check.
>diff --git a/Tools/Scripts/run-jsc-stress-tests b/Tools/Scripts/run-jsc-stress-tests
>index 632940b3e4da7b69cd8e87f0151b12616e5bd5bc..1df9301203d1daad17b772f833828e89672cc7e9 100755
>--- a/Tools/Scripts/run-jsc-stress-tests
>+++ b/Tools/Scripts/run-jsc-stress-tests
>@@ -449,7 +449,7 @@ $hostOS = determineOS unless $hostOS
> $architecture = determineArchitecture unless $architecture
> $isFTLPlatform = !($architecture == "x86" || $architecture == "arm" || $architecture == "mips" || $hostOS == "windows")
> 
>-if ["mips", "x86"].include?($architecture)
>+if ["arm", "mips", "x86"].include?($architecture)
>     # The JIT is temporarily disabled on these platforms since
>     # https://trac.webkit.org/changeset/237547
>     $jitTests = false
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 166bd73ca89f17d02b12b4dd191c32fe84a142a0..21f778825d71b7f616592c26c2973a01df9804fc 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,17 @@
>+2019-01-10  Commit Queue  <commit-queue@webkit.org>
>+
>+        Unreviewed, rolling out r239825.
>+        https://bugs.webkit.org/show_bug.cgi?id=193330
>+
>+        Broke tests on armv7/linux bots (Requested by guijemont on
>+        #webkit).
>+
>+        Reverted changeset:
>+
>+        "Enable DFG on ARM/Linux again"
>+        https://bugs.webkit.org/show_bug.cgi?id=192496
>+        https://trac.webkit.org/changeset/239825
>+
> 2019-01-10  Justin Fan  <justin_fan@apple.com>
> 
>         [WebGPU] Fix vertex-buffer-triangle-strip test and small update to GPURenderPipeline
>diff --git a/LayoutTests/js/script-tests/dfg-float32array.js b/LayoutTests/js/script-tests/dfg-float32array.js
>index 1fef87726cce52b8579ba199ed01feaf7e8b66fa..4211465d6de2322a67750abb0e5540c570dfafe3 100644
>--- a/LayoutTests/js/script-tests/dfg-float32array.js
>+++ b/LayoutTests/js/script-tests/dfg-float32array.js
>@@ -1,4 +1,4 @@
>-//@ noNoLLIntRunLayoutTest if $architecture == "arm"
>+//@ noNoLLIntRunLayoutTest if $architecture == "arm" and $hostOS == "darwin"
> 
> description(
> "This tests that float32 arrays work in the DFG."
>diff --git a/LayoutTests/js/script-tests/dfg-float64array.js b/LayoutTests/js/script-tests/dfg-float64array.js
>index b712bd2258233d54ad3bfea052636979e54788ca..d58990e4b641056b8094eea05f7443aa3454d4d3 100644
>--- a/LayoutTests/js/script-tests/dfg-float64array.js
>+++ b/LayoutTests/js/script-tests/dfg-float64array.js
>@@ -1,4 +1,4 @@
>-//@ noNoLLIntRunLayoutTest if $architecture == "arm"
>+//@ noNoLLIntRunLayoutTest if $architecture == "arm" and $hostOS == "darwin"
> 
> description(
> "This tests that float64 arrays work in the DFG."
>diff --git a/LayoutTests/js/script-tests/dfg-int16array.js b/LayoutTests/js/script-tests/dfg-int16array.js
>index 19ad96fc0d62a017ce2604450c1fdb0e03901f2d..3e1efc3a0b918df1eb1fb48304a8d514e11d1793 100644
>--- a/LayoutTests/js/script-tests/dfg-int16array.js
>+++ b/LayoutTests/js/script-tests/dfg-int16array.js
>@@ -1,4 +1,4 @@
>-//@ noNoLLIntRunLayoutTest if $architecture == "arm"
>+//@ noNoLLIntRunLayoutTest if $architecture == "arm" and $hostOS == "darwin"
> 
> description(
> "This tests that int16 arrays work in the DFG."
>diff --git a/LayoutTests/js/script-tests/dfg-int32array-overflow-values.js b/LayoutTests/js/script-tests/dfg-int32array-overflow-values.js
>index bf551c3e912196aa3d8acee2728ea71f23a2ce2e..2edd518a8811d53fa1e147f8d2c11569987fabf3 100644
>--- a/LayoutTests/js/script-tests/dfg-int32array-overflow-values.js
>+++ b/LayoutTests/js/script-tests/dfg-int32array-overflow-values.js
>@@ -1,4 +1,4 @@
>-//@ noNoLLIntRunLayoutTest if $architecture == "arm"
>+//@ noNoLLIntRunLayoutTest if $architecture == "arm" and $hostOS == "darwin"
> 
> description(
> "This tests that int32 arrays work in the DFG."
>diff --git a/LayoutTests/js/script-tests/dfg-int32array.js b/LayoutTests/js/script-tests/dfg-int32array.js
>index 66271290e1aa1df9b764cd4a48b74e9b622ee69d..490c6a3da86fa86dcada83a3ca157759b450b3af 100644
>--- a/LayoutTests/js/script-tests/dfg-int32array.js
>+++ b/LayoutTests/js/script-tests/dfg-int32array.js
>@@ -1,4 +1,4 @@
>-//@ noNoLLIntRunLayoutTest if $architecture == "arm"
>+//@ noNoLLIntRunLayoutTest if $architecture == "arm" and $hostOS == "darwin"
> 
> description(
> "This tests that int32 arrays work in the DFG."
>diff --git a/LayoutTests/js/script-tests/dfg-int8array.js b/LayoutTests/js/script-tests/dfg-int8array.js
>index 05f69e36e8867e4bcc3b1b8c09ba44b06ae31049..feb83e3f0fde205d61582e3b183cc0728daaebcf 100644
>--- a/LayoutTests/js/script-tests/dfg-int8array.js
>+++ b/LayoutTests/js/script-tests/dfg-int8array.js
>@@ -1,4 +1,4 @@
>-//@ noNoLLIntRunLayoutTest if $architecture == "arm"
>+//@ noNoLLIntRunLayoutTest if $architecture == "arm" and $hostOS == "darwin"
> 
> description(
> "This tests that int8 arrays work in the DFG."
>diff --git a/LayoutTests/js/script-tests/dfg-uint16array.js b/LayoutTests/js/script-tests/dfg-uint16array.js
>index 234e897affc63f273c95baa3ef6ef5fe5524daac..ba53b7b0bbf36ffac0239f3279ae6c15a3cceed6 100644
>--- a/LayoutTests/js/script-tests/dfg-uint16array.js
>+++ b/LayoutTests/js/script-tests/dfg-uint16array.js
>@@ -1,4 +1,4 @@
>-//@ noNoLLIntRunLayoutTest if $architecture == "arm"
>+//@ noNoLLIntRunLayoutTest if $architecture == "arm" and $hostOS == "darwin"
> 
> description(
> "This tests that uint16 arrays work in the DFG."
>diff --git a/LayoutTests/js/script-tests/dfg-uint32array.js b/LayoutTests/js/script-tests/dfg-uint32array.js
>index bea38e00e2cf6671683978485a2f1be370dbd50e..f1c48ab5db3175d6c35bcc41ee0e9e491d703b9c 100644
>--- a/LayoutTests/js/script-tests/dfg-uint32array.js
>+++ b/LayoutTests/js/script-tests/dfg-uint32array.js
>@@ -1,4 +1,4 @@
>-//@ noNoLLIntRunLayoutTest if $architecture == "arm"
>+//@ noNoLLIntRunLayoutTest if $architecture == "arm" and $hostOS == "darwin"
> 
> description(
> "This tests that uint32 arrays work in the DFG."
>diff --git a/LayoutTests/js/script-tests/dfg-uint8array.js b/LayoutTests/js/script-tests/dfg-uint8array.js
>index 339d85554e75b820cc2a3c1a9eedae3d9b99b9e1..95e8bcbc89339801243dc22b0c45ccc38f873041 100644
>--- a/LayoutTests/js/script-tests/dfg-uint8array.js
>+++ b/LayoutTests/js/script-tests/dfg-uint8array.js
>@@ -1,4 +1,4 @@
>-//@ noNoLLIntRunLayoutTest if $architecture == "arm"
>+//@ noNoLLIntRunLayoutTest if $architecture == "arm" and $hostOS == "darwin"
> 
> description(
> "This tests that uint8 arrays work in the DFG."
>diff --git a/JSTests/ChangeLog b/JSTests/ChangeLog
>index 851e5468bf35f0885b47a02c3b9f283e8d882844..742dd3fb72684548070a805c8a1c945c1da16fa6 100644
>--- a/JSTests/ChangeLog
>+++ b/JSTests/ChangeLog
>@@ -1,3 +1,17 @@
>+2019-01-10  Commit Queue  <commit-queue@webkit.org>
>+
>+        Unreviewed, rolling out r239825.
>+        https://bugs.webkit.org/show_bug.cgi?id=193330
>+
>+        Broke tests on armv7/linux bots (Requested by guijemont on
>+        #webkit).
>+
>+        Reverted changeset:
>+
>+        "Enable DFG on ARM/Linux again"
>+        https://bugs.webkit.org/show_bug.cgi?id=192496
>+        https://trac.webkit.org/changeset/239825
>+
> 2019-01-10  Dominik Infuehr  <dinfuehr@igalia.com>
> 
>         Enable DFG on ARM/Linux again
>diff --git a/JSTests/stress/regress-192717.js b/JSTests/stress/regress-192717.js
>index f941a85549be7ba11fdc5e002e3920a52e4e1012..91a1ed81045f3a7d029715dfd41be02b464079f9 100644
>--- a/JSTests/stress/regress-192717.js
>+++ b/JSTests/stress/regress-192717.js
>@@ -1,5 +1,5 @@
>-//@ skip if $memoryLimited or $buildType == "debug"
> //@ runDefault("--useLLInt=false", "--forceCodeBlockToJettisonDueToOldAge=true", "--maxPerThreadStackUsage=200000", "--exceptionStackTraceLimit=1", "--defaultErrorStackTraceLimit=1")
>+//@ skip if $memoryLimited or $buildType == "debug"
> 
> let foo = 'let a';
> for (let i = 0; i < 400000; i++)

Actions: View | Formatted Diff | Diff

Attachments on bug 193330: 358814