Attachment 358724 Details for Bug 193293 – Proposed patch

[patch] Proposed patch

ews-build-bug-title.patch (text/plain), 2.40 KB, created by Aakash Jain on 2019-01-09 12:33:34 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Aakash Jain

Created: 2019-01-09 12:33:34 PST

Size: 2.40 KB

patch

obsolete

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 239780)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,15 @@
>+2019-01-09  Aakash Jain  <aakash_jain@apple.com>
>+
>+        [ews-build] Add link to bug along with bug title
>+        https://bugs.webkit.org/show_bug.cgi?id=193293
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * BuildSlaveSupport/ews-build/steps.py:
>+        (ValidatePatch._is_bug_closed): Fetch bug title from Bugzilla and add it to the build.
>+        (ConfigureBuild.add_bug_id_url): Deleted.
>+        (ConfigureBuild.getBugURL): Deleted.
>+
> 2019-01-09  Zalan Bujtas  <zalan@apple.com>
> 
>         [LFC][BFC][MarginCollapsing] Add support for peculiar cases.
>Index: Tools/BuildSlaveSupport/ews-build/steps.py
>===================================================================
>--- Tools/BuildSlaveSupport/ews-build/steps.py	(revision 239780)
>+++ Tools/BuildSlaveSupport/ews-build/steps.py	(working copy)
>@@ -67,7 +67,6 @@ class ConfigureBuild(buildstep.BuildStep
>             self.setProperty("additionalArguments", self.additionalArguments, 'config.json')
> 
>         self.add_patch_id_url()
>-        self.add_bug_id_url()
>         self.finished(SUCCESS)
>         return defer.succeed(None)
> 
>@@ -76,21 +75,11 @@ class ConfigureBuild(buildstep.BuildStep
>         if patch_id:
>             self.addURL('Patch {}'.format(patch_id), self.getPatchURL(patch_id))
> 
>-    def add_bug_id_url(self):
>-        bug_id = self.getProperty('bug_id', '')
>-        if bug_id:
>-            self.addURL('Bug {}'.format(bug_id), self.getBugURL(bug_id))
>-
>     def getPatchURL(self, patch_id):
>         if not patch_id:
>             return None
>         return '{}attachment.cgi?id={}'.format(BUG_SERVER_URL, patch_id)
> 
>-    def getBugURL(self, bug_id):
>-        if not bug_id:
>-            return None
>-        return '{}show_bug.cgi?id={}'.format(BUG_SERVER_URL, bug_id)
>-
> 
> class CheckOutSource(git.Git):
>     name = 'clean-and-update-working-directory'
>@@ -310,6 +299,8 @@ class ValidatePatch(buildstep.BuildStep)
>             self._addToLog('stdio', 'Unable to fetch bug {}.\n'.format(bug_id))
>             return -1
> 
>+        bug_title = bug_json.get('summary')
>+        self.addURL('Bug {} {}'.format(bug_id, bug_title), '{}show_bug.cgi?id={}'.format(BUG_SERVER_URL, bug_id))
>         if bug_json.get('status') in self.bug_closed_statuses:
>             return 1
>         return 0

Flags:

lforschler: review+
commit-queue: commit-queue-

Actions: View | Formatted Diff | Diff

Attachments on bug 193293: 358724