WebKit Bugzilla
Attachment 358701 Details for
Bug 193280
: [ews-build] Parse and display number of style failures
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Proposed patch
ews-build-style-count.patch (text/plain), 2.83 KB, created by
Aakash Jain
on 2019-01-09 07:03:48 PST
(
hide
)
Description:
Proposed patch
Filename:
MIME Type:
Creator:
Aakash Jain
Created:
2019-01-09 07:03:48 PST
Size:
2.83 KB
patch
obsolete
>Index: Tools/ChangeLog >=================================================================== >--- Tools/ChangeLog (revision 239769) >+++ Tools/ChangeLog (working copy) >@@ -1,3 +1,14 @@ >+2019-01-09 Aakash Jain <aakash_jain@apple.com> >+ >+ [ews-build] Parse and display number of style failures >+ https://bugs.webkit.org/show_bug.cgi?id=193280 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * BuildSlaveSupport/ews-build/steps.py: >+ (CheckStyle): Use TestWithFailureCount as base class. >+ (CheckStyle.countFailures): Count the number of style failures. >+ > 2019-01-09 Philippe Normand <pnormand@igalia.com> > > [WPE] API tests can't run in flatpak environment >Index: Tools/BuildSlaveSupport/ews-build/steps.py >=================================================================== >--- Tools/BuildSlaveSupport/ews-build/steps.py (revision 239723) >+++ Tools/BuildSlaveSupport/ews-build/steps.py (working copy) >@@ -363,14 +363,6 @@ class UnApplyPatchIfRequired(CheckOutSou > return not self.doStepIf(step) > > >-class CheckStyle(shell.ShellCommand): >- name = 'check-webkit-style' >- description = ['check-webkit-style running'] >- descriptionDone = ['check-webkit-style'] >- flunkOnFailure = True >- command = ['Tools/Scripts/check-webkit-style'] >- >- > class TestWithFailureCount(shell.Test): > failedTestsFormatString = "%d test%s failed" > failedTestCount = 0 >@@ -409,6 +401,23 @@ class TestWithFailureCount(shell.Test): > return {u'step': status} > > >+class CheckStyle(TestWithFailureCount): >+ name = 'check-webkit-style' >+ description = ['check-webkit-style running'] >+ descriptionDone = ['check-webkit-style'] >+ flunkOnFailure = True >+ failedTestsFormatString = '%d style error%s' >+ command = ['Tools/Scripts/check-webkit-style'] >+ >+ def countFailures(self, cmd): >+ log_text = self.log_observer.getStdout() + self.log_observer.getStderr() >+ >+ match = re.search(r'Total errors found: (?P<errors>\d+) in (?P<files>\d+) files', log_text) >+ if not match: >+ return 0 >+ return int(match.group('errors')) >+ >+ > class RunBindingsTests(shell.ShellCommand): > name = 'bindings-tests' > description = ['bindings-tests running'] >Index: Tools/BuildSlaveSupport/ews-build/steps_unittest.py >=================================================================== >--- Tools/BuildSlaveSupport/ews-build/steps_unittest.py (revision 239723) >+++ Tools/BuildSlaveSupport/ews-build/steps_unittest.py (working copy) >@@ -234,7 +234,7 @@ ERROR: Source/WebCore/layout/Verificatio > Total errors found: 8 in 48 files''') > + 2, > ) >- self.expectOutcome(result=FAILURE, state_string='check-webkit-style (failure)') >+ self.expectOutcome(result=FAILURE, state_string='8 style errors (failure)') > return self.runStep() > > def test_failures_no_style_issues(self):
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 193280
: 358701