WebKit Bugzilla
Attachment 358700 Details for
Bug 193239
: [GTK][WPE] Graphic issue with invalidations on composited layers with subpixel positions
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-193239-20190109160129.patch (text/plain), 7.71 KB, created by
Karl Leplat
on 2019-01-09 07:02:08 PST
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Karl Leplat
Created:
2019-01-09 07:02:08 PST
Size:
7.71 KB
patch
obsolete
>Subversion Revision: 239026 >diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog >index 2b560689ef5cdc45e7ebd16e3dbcf43de79e15ee..9b83a426ed174b4656a3765ddccdc13a8a2d5b04 100644 >--- a/Source/WebCore/ChangeLog >+++ b/Source/WebCore/ChangeLog >@@ -1,3 +1,15 @@ >+2019-01-09 Karl Leplat <karl.leplat_ext@softathome.com> >+ >+ [GTK][WPE] Graphic issue with invalidations on composited layers with subpixel positions >+ https://bugs.webkit.org/show_bug.cgi?id=193239 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ Test: compositing/repaint/invalidations-on-composited-layers-with-subpixel-positions.html >+ >+ * platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp: >+ (WebCore::CoordinatedGraphicsLayer::updateContentBuffers): >+ > 2018-12-09 Youenn Fablet <youenn@apple.com> > > Move capture manager from RealtimeMediaSourceCenter to capture factory >diff --git a/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp b/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp >index 15ae46f60d7264e1ab57c581938a5b465be3ecff..29b4c8ce37fc0ee3723689543b2e6524912376d3 100644 >--- a/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp >+++ b/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp >@@ -888,7 +888,7 @@ void CoordinatedGraphicsLayer::updateContentBuffers() > > if (!m_needsDisplay.completeLayer) { > for (auto& rect : m_needsDisplay.rects) >- layerState.mainBackingStore->invalidate(IntRect { rect }); >+ layerState.mainBackingStore->invalidate(enclosingIntRect(rect)); > } else > layerState.mainBackingStore->invalidate({ { }, IntSize { m_size } }); > >diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog >index 202893917e53d9aaa0af273fc573667ad8a8ea56..ea243c6da36ee1ea1205e902b7c68394ad28d440 100644 >--- a/LayoutTests/ChangeLog >+++ b/LayoutTests/ChangeLog >@@ -1,3 +1,14 @@ >+2019-01-09 Karl Leplat <karl.leplat_ext@softathome.com> >+ >+ [GTK][WPE] Graphic issue with invalidations on composited layers with subpixel positions >+ https://bugs.webkit.org/show_bug.cgi?id=193239 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * compositing/repaint/invalidations-on-composited-layers-with-subpixel-positions-expected.png: Added. >+ * compositing/repaint/invalidations-on-composited-layers-with-subpixel-positions-expected.txt: Added. >+ * compositing/repaint/invalidations-on-composited-layers-with-subpixel-positions.html: Added. >+ > 2018-12-09 Commit Queue <commit-queue@webkit.org> > > Unreviewed, rolling out r239010. >diff --git a/LayoutTests/compositing/repaint/invalidations-on-composited-layers-with-subpixel-positions-expected.png b/LayoutTests/compositing/repaint/invalidations-on-composited-layers-with-subpixel-positions-expected.png >new file mode 100644 >index 0000000000000000000000000000000000000000..bd0767ced4f172a2fafba160992072b701bfb95b >GIT binary patch >literal 3193 >zcmeAS@N?(olHy`uVBq!ia0y~yU{+vYV2a>i0*Z)=h^hlA%@Ws$lH`ok<m}?oT!u7D >z3xi|}^JI%ugEW&gqf|@F6ic(@v^3+yR0B&h<D{mNV0NG;wj^(N7l!{JxM1({$qWqK >zUp!qLLn`LHy}Pk@#u+BJz|UJ)Odj+IX*6EZ-4Xu%;S3?Q1q^Z9Zl2F8XjLuoGdQUd >zU(srk^y}~M@B9o5R{wurXJ%ly=a#_8aD+vS!NCWE@#gV<y?=jxetyEo&~W_&D>s9J >z+6D%OBqp*M-&_-PPaFAOHVy__{7`ShwbHxaYj1BmevN@)&w<#4v!DM|GBJGcl{YUx >zUf5%J?sH8JFT(-uJFM4AW0QN1F9WJ-4sT&#Fl=OH5D<=_ALF;uhH0rYm%W^+$-wZw >zKs@60u6Mup<=#%tW?+bWpts>!<v$xnh9ArNXYYP&aZKWQrQJ3*h6k+gm|pK%XLu|b >z<k^GTP7Dn*4lprvaO%*HQ7ag6dXvxPFK0v;8p?NYuPKfFUVDGr+l{6S4EjKCe732d >z$G}i?`S{tpg)+%KpKau$nHfGXl{c2gUYB^h5#-qiqKep324-5Jy2zXE15wjbXDv$y >zMf>5{gtf1Cz5l%}w|^}oLq+561GAq0{LI4eV76V}yS~Q~$#b6nydlNVAP)58>s`kr >z`h9__*w=F~Qj%K9OYEa*oVYap_xbvwy1&1^Qmt?yFS<r`kzJaP2Hj}T(Z75hO?9KG >zZm6WXZy&$EzhA$XvEkVH`S$<6vOGA>9}jFn7g5lHuJ@gibz<MfcYMGe0fVQjpUXO@ >LgeGNIe>W}wC{fN4 > >literal 0 >HcmV?d00001 > >diff --git a/LayoutTests/compositing/repaint/invalidations-on-composited-layers-with-subpixel-positions-expected.txt b/LayoutTests/compositing/repaint/invalidations-on-composited-layers-with-subpixel-positions-expected.txt >new file mode 100644 >index 0000000000000000000000000000000000000000..d6b800b277dbc66736541845dda38b59f54b72ec >--- /dev/null >+++ b/LayoutTests/compositing/repaint/invalidations-on-composited-layers-with-subpixel-positions-expected.txt >@@ -0,0 +1,31 @@ >+layer at (0,0) size 1288x585 >+ RenderView at (0,0) size 800x585 >+layer at (0,0) size 800x203 >+ RenderBlock {HTML} at (0,0) size 800x204 >+ RenderBody {BODY} at (8,8) size 784x188 >+layer at (0,0) size 800x585 >+ RenderBlock (positioned) {DIV} at (0,0) size 800x585 >+layer at (8,8) size 1280x31 >+ RenderBlock (relative positioned) {DIV} at (0,0) size 1280x32 [color=#FFFFFF] [bgcolor=#333333] >+ RenderText {#text} at (0,0) size 5x24 >+ text run at (0,0) width 5: "." >+layer at (8,39) size 1280x31 >+ RenderBlock (relative positioned) {DIV} at (0,31) size 1280x32 [color=#FFFFFF] [bgcolor=#333333] >+ RenderText {#text} at (0,0) size 5x24 >+ text run at (0,0) width 5: "." >+layer at (8,70) size 1280x32 >+ RenderBlock (relative positioned) {DIV} at (0,62) size 1280x32 [color=#FFFFFF] [bgcolor=#333333] >+ RenderText {#text} at (0,0) size 5x24 >+ text run at (0,0) width 5: "." >+layer at (8,102) size 1280x31 >+ RenderBlock (relative positioned) {DIV} at (0,93) size 1280x32 [color=#FFFFFF] [bgcolor=#333333] >+ RenderText {#text} at (0,0) size 5x24 >+ text run at (0,0) width 5: "." >+layer at (8,133) size 1280x31 >+ RenderBlock (relative positioned) {DIV} at (0,124) size 1280x32 [color=#FFFFFF] [bgcolor=#333333] >+ RenderText {#text} at (0,0) size 5x24 >+ text run at (0,0) width 5: "." >+layer at (8,164) size 1280x31 >+ RenderBlock (relative positioned) {DIV} at (0,155) size 1280x33 [color=#FFFFFF] [bgcolor=#333333] >+ RenderText {#text} at (0,0) size 5x24 >+ text run at (0,0) width 5: "." >diff --git a/LayoutTests/compositing/repaint/invalidations-on-composited-layers-with-subpixel-positions.html b/LayoutTests/compositing/repaint/invalidations-on-composited-layers-with-subpixel-positions.html >new file mode 100644 >index 0000000000000000000000000000000000000000..6bf977add5663a8bb4fbf9d1046260b85d56aca4 >--- /dev/null >+++ b/LayoutTests/compositing/repaint/invalidations-on-composited-layers-with-subpixel-positions.html >@@ -0,0 +1,40 @@ >+<!DOCTYPE html> >+ >+<html> >+ <head> >+ <style type="text/css"> >+ .list_option { >+ position: relative; >+ font-size: 1.3em; >+ width: 1280px; >+ height: 1.5em; >+ background-color: #333; >+ color: white; >+ } >+ .list_option.selected { >+ background-color: #F60; >+ } >+ </style> >+ <script src="../../fast/repaint/resources/repaint.js"></script> >+ <script> >+ function repaintTest() { >+ document.getElementById("opt1").className = "list_option"; >+ document.getElementById("opt2").className = "list_option"; >+ document.getElementById("opt3").className = "list_option"; >+ document.getElementById("opt4").className = "list_option"; >+ document.getElementById("opt5").className = "list_option"; >+ document.getElementById("opt6").className = "list_option"; >+ } >+ </script> >+</head> >+<body onload="runRepaintTest()"> >+<div id="forceAcceleratedCompositing" style="position:absolute;left:0;right:0;top:0;bottom:0;-webkit-transform: translate3d(0, 0, 0);"></div> >+ >+ <div class="list_option selected" id="opt1">.</div> >+ <div class="list_option selected" id="opt2">.</div> >+ <div class="list_option selected" id="opt3">.</div> >+ <div class="list_option selected" id="opt4">.</div> >+ <div class="list_option selected" id="opt5">.</div> >+ <div class="list_option selected" id="opt6">.</div> >+</body> >+</html>
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 193239
:
358598
|
358600
|
358601
|
358608
|
358614
|
358615
|
358638
|
358682
|
358692
|
358699
|
358700
|
358704
|
358705
|
358707
|
358709
|
358711
|
358785
|
359021