Attachment 358699 Details for Bug 193239 – Patch

[patch] Patch

bug-193239-20190109152821.patch (text/plain), 7.92 KB, created by Karl Leplat on 2019-01-09 06:29:00 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Karl Leplat

Created: 2019-01-09 06:29:00 PST

Size: 7.92 KB

patch

obsolete

>Subversion Revision: 239026
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 2b560689ef5cdc45e7ebd16e3dbcf43de79e15ee..9b83a426ed174b4656a3765ddccdc13a8a2d5b04 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,15 @@
>+2019-01-09  Karl Leplat  <karl.leplat_ext@softathome.com>
>+
>+        [GTK][WPE] Graphic issue with invalidations on composited layers with subpixel positions
>+        https://bugs.webkit.org/show_bug.cgi?id=193239
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Test: compositing/repaint/invalidations-on-composited-layers-with-subpixel-positions.html
>+
>+        * platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
>+        (WebCore::CoordinatedGraphicsLayer::updateContentBuffers):
>+
> 2018-12-09  Youenn Fablet  <youenn@apple.com>
> 
>         Move capture manager from RealtimeMediaSourceCenter to capture factory
>diff --git a/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp b/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp
>index 15ae46f60d7264e1ab57c581938a5b465be3ecff..29b4c8ce37fc0ee3723689543b2e6524912376d3 100644
>--- a/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp
>+++ b/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp
>@@ -888,7 +888,7 @@ void CoordinatedGraphicsLayer::updateContentBuffers()
> 
>     if (!m_needsDisplay.completeLayer) {
>         for (auto& rect : m_needsDisplay.rects)
>-            layerState.mainBackingStore->invalidate(IntRect { rect });
>+            layerState.mainBackingStore->invalidate(enclosingIntRect(rect));
>     } else
>         layerState.mainBackingStore->invalidate({ { }, IntSize { m_size } });
> 
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 202893917e53d9aaa0af273fc573667ad8a8ea56..ea243c6da36ee1ea1205e902b7c68394ad28d440 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,14 @@
>+2019-01-09  Karl Leplat  <karl.leplat_ext@softathome.com>
>+
>+        [GTK][WPE] Graphic issue with invalidations on composited layers with subpixel positions
>+        https://bugs.webkit.org/show_bug.cgi?id=193239
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * compositing/repaint/invalidations-on-composited-layers-with-subpixel-positions-expected.png: Added.
>+        * compositing/repaint/invalidations-on-composited-layers-with-subpixel-positions-expected.txt: Added.
>+        * compositing/repaint/invalidations-on-composited-layers-with-subpixel-positions.html: Added.
>+
> 2018-12-09  Commit Queue  <commit-queue@webkit.org>
> 
>         Unreviewed, rolling out r239010.
>diff --git a/LayoutTests/compositing/repaint/invalidations-on-composited-layers-with-subpixel-positions-expected.png b/LayoutTests/compositing/repaint/invalidations-on-composited-layers-with-subpixel-positions-expected.png
>new file mode 100644
>index 0000000000000000000000000000000000000000..676fc6c12e342800f7b7529a152bf64553af4485
>GIT binary patch
>literal 3193
>zcmeAS@N?(olHy`uVBq!ia0y~yU{+vYV2a>i0*Z)=h^hlA%@Ws$lH`ok<m}?oTn4iw
>z15;B&Qws}23qzx%q_i}{<g`?S6ho6#qf~Q)6pLKG#{WP~Y)RhkE)4%caKYZ?lNlJe
>zzj(ShhE&XXdv{~+j5ADbfuFaqm^|na(rCP*yCeMj!x=(q3mD?I-8`RH(5hPEXK+#_
>zzM|D6>DS-i-}xCBtp5ML&dk7Y&n<zG;RuTugM$w>8Fv3(KRQ3(-v1o~Lj`aA1_p*C
>zCT<1=HS!tpEY~*aTsE;aW@UIF`;I9)_ImC8?YY%CybK4p@33C8IX@p5u=l?d7MIH$
>zmw0S*{`fTphCK&j6JoEM9;?XVVmM%3;mW}vARNKKVA#k?H^xSNrtHXRnX~52WMcTh
>zSKhdF-RphtZ*Q~R#>Vh~73ht5&(8}pH01x<vD3OQxu<a6^W<y>hPVfM8`iy+O13cr
>zd3KKy3quE|4nxC?159*d+z@Zvs&m@J_q-1yLq+@U15wvY?|;v|Ef>wq@PVnk(e(W1
>z=bQ`&%xmx5kv(pB%;Nm#jiw9?`UT<<*Gqd1<z|CC8z;y_gM>vOrM~Gt5H&4z*0S_v
>z!0105o3QrvuJ^yU<@T=ydZTgofmzRger92KFxxKgUEgDg<T=lO-jHHw5Z}SQ=Jl>)
>z68*kFRqX3I7%5Jz<R$jeG)`0+zfu2B>-qKd@zg6^$cwH~U6dE=qhUB2hLki5M$^w|
>z`Wd|G=iA5c@9)>|Wo$SGYzzPY%JSeiKd3ESM1HFMR=+De>%=?3E1JL_0fVQjpUXO@
>LgeGNIe>W}wXF|ON
>
>literal 0
>HcmV?d00001
>
>diff --git a/LayoutTests/compositing/repaint/invalidations-on-composited-layers-with-subpixel-positions-expected.txt b/LayoutTests/compositing/repaint/invalidations-on-composited-layers-with-subpixel-positions-expected.txt
>new file mode 100644
>index 0000000000000000000000000000000000000000..181ece534b6d6e39de42426c24cae2604a0c7445
>--- /dev/null
>+++ b/LayoutTests/compositing/repaint/invalidations-on-composited-layers-with-subpixel-positions-expected.txt
>@@ -0,0 +1,32 @@
>+layer at (0,0) size 1288x585
>+  RenderView at (0,0) size 800x585
>+layer at (0,0) size 800x216
>+  RenderBlock {HTML} at (0,0) size 800x216
>+    RenderBody {BODY} at (8,20) size 784x188
>+      RenderBlock {DIV} at (0,0) size 1280x188
>+layer at (0,0) size 800x585
>+  RenderBlock (positioned) {DIV} at (0,0) size 800x585
>+layer at (8,21) size 1280x31
>+  RenderBlock (relative positioned) {DIV} at (0,0) size 1280x32 [color=#FFFFFF] [bgcolor=#333333]
>+    RenderText {#text} at (0,0) size 5x24
>+      text run at (0,0) width 5: "."
>+layer at (8,52) size 1280x31
>+  RenderBlock (relative positioned) {DIV} at (0,31) size 1280x32 [color=#FFFFFF] [bgcolor=#333333]
>+    RenderText {#text} at (0,0) size 5x24
>+      text run at (0,0) width 5: "."
>+layer at (8,83) size 1280x32
>+  RenderBlock (relative positioned) {DIV} at (0,62) size 1280x32 [color=#FFFFFF] [bgcolor=#333333]
>+    RenderText {#text} at (0,0) size 5x24
>+      text run at (0,0) width 5: "."
>+layer at (8,114) size 1280x31
>+  RenderBlock (relative positioned) {DIV} at (0,93) size 1280x32 [color=#FFFFFF] [bgcolor=#333333]
>+    RenderText {#text} at (0,0) size 5x24
>+      text run at (0,0) width 5: "."
>+layer at (8,146) size 1280x31
>+  RenderBlock (relative positioned) {DIV} at (0,124) size 1280x32 [color=#FFFFFF] [bgcolor=#333333]
>+    RenderText {#text} at (0,0) size 5x24
>+      text run at (0,0) width 5: "."
>+layer at (8,177) size 1280x31
>+  RenderBlock (relative positioned) {DIV} at (0,155) size 1280x33 [color=#FFFFFF] [bgcolor=#333333]
>+    RenderText {#text} at (0,0) size 5x24
>+      text run at (0,0) width 5: "."
>diff --git a/LayoutTests/compositing/repaint/invalidations-on-composited-layers-with-subpixel-positions.html b/LayoutTests/compositing/repaint/invalidations-on-composited-layers-with-subpixel-positions.html
>new file mode 100644
>index 0000000000000000000000000000000000000000..18355347137aa5b01a22435ec5b4d4ce9f0931ea
>--- /dev/null
>+++ b/LayoutTests/compositing/repaint/invalidations-on-composited-layers-with-subpixel-positions.html
>@@ -0,0 +1,45 @@
>+<!DOCTYPE html>
>+
>+<html>
>+    <head>
>+        <style type="text/css">
>+            .list_select {
>+                width: 1280px;
>+                font-size: 1.3em;
>+                margin-top: 1em;
>+            }
>+            .list_option {
>+                position: relative;
>+                height: 1.5em;
>+                background-color: #333;
>+                color: white;
>+            }
>+            .list_option.selected {
>+                background-color: #F60;
>+            }
>+    </style>
>+    <script src="../../fast/repaint/resources/repaint.js"></script>
>+    <script>
>+        function repaintTest() {
>+            document.getElementById("opt1").className = "list_option";
>+            document.getElementById("opt2").className = "list_option";
>+            document.getElementById("opt3").className = "list_option";
>+            document.getElementById("opt4").className = "list_option";
>+            document.getElementById("opt5").className = "list_option";
>+            document.getElementById("opt6").className = "list_option";
>+        }
>+    </script>
>+</head>
>+<body onload="runRepaintTest()">
>+<div id="forceAcceleratedCompositing" style="position:absolute;left:0;right:0;top:0;bottom:0;-webkit-transform: translate3d(0, 0, 0);"></div>
>+
>+    <div class="list_select">
>+            <div class="list_option selected" id="opt1">.</div>
>+            <div class="list_option selected" id="opt2">.</div>
>+            <div class="list_option selected" id="opt3">.</div>
>+            <div class="list_option selected" id="opt4">.</div>
>+            <div class="list_option selected" id="opt5">.</div>
>+            <div class="list_option selected" id="opt6">.</div>
>+    </div>
>+</body>
>+</html>

Actions: View | Formatted Diff | Diff

Attachments on bug 193239: 358598 | 358600 | 358601 | 358608 | 358614 | 358615 | 358638 | 358682 | 358692 | 358699 | 358700 | 358704 | 358705 | 358707 | 358709 | 358711 | 358785 | 359021