Attachment 358688 Details for Bug 193276 – Patch

[patch] Patch

wc-ft-synth.diff (text/plain), 1.70 KB, created by Carlos Garcia Campos on 2019-01-09 02:58:55 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Carlos Garcia Campos

Created: 2019-01-09 02:58:55 PST

Size: 1.70 KB

patch

obsolete

>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 17a56b47754..7ac4e15ce66 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,16 @@
>+2019-01-09  Carlos Garcia Campos  <cgarcia@igalia.com>
>+
>+        REGRESSION(r239156): [FreeType] fixed width, and synthetic bold/italic not correctly applied since r239156
>+        https://bugs.webkit.org/show_bug.cgi?id=193276
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        FontCache::createFontPlatformData() is calling getFontPropertiesFromPattern() with the configure pattern instead
>+        of the result one after the match.
>+
>+        * platform/graphics/freetype/FontCacheFreeType.cpp:
>+        (WebCore::FontCache::createFontPlatformData):
>+
> 2019-01-08  Dean Jackson  <dino@apple.com>
> 
>         Blob references for System Previews don't get a correct file extension
>diff --git a/Source/WebCore/platform/graphics/freetype/FontCacheFreeType.cpp b/Source/WebCore/platform/graphics/freetype/FontCacheFreeType.cpp
>index c446edb5107..ac59a5ae642 100644
>--- a/Source/WebCore/platform/graphics/freetype/FontCacheFreeType.cpp
>+++ b/Source/WebCore/platform/graphics/freetype/FontCacheFreeType.cpp
>@@ -429,7 +429,7 @@ std::unique_ptr<FontPlatformData> FontCache::createFontPlatformData(const FontDe
>         return nullptr;
> 
>     bool fixedWidth, syntheticBold, syntheticOblique;
>-    getFontPropertiesFromPattern(pattern.get(), fontDescription, fixedWidth, syntheticBold, syntheticOblique);
>+    getFontPropertiesFromPattern(resultPattern.get(), fontDescription, fixedWidth, syntheticBold, syntheticOblique);
> 
>     RefPtr<cairo_font_face_t> fontFace = adoptRef(cairo_ft_font_face_create_for_pattern(resultPattern.get()));
> #if ENABLE(VARIATION_FONTS)

Flags:

zan: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 193276: 358686 | 358688