Attachment 358669 Details for Bug 193238 – Patch

[patch] Patch

bug-193238-20190108210425.patch (text/plain), 1.90 KB, created by Wenson Hsieh on 2019-01-08 21:04:26 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Wenson Hsieh

Created: 2019-01-08 21:04:26 PST

Size: 1.90 KB

patch

obsolete

>Subversion Revision: 239752
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 61316959ab7da3c895aaaa77bf2112765072ae64..955358ac205b04f2ba03f4556a4de1aceb5215ab 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,17 @@
>+2019-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
>+
>+        [iOS] editing/selection/ios/show-selection-in-empty-overflow-hidden-document.html often times out in internal automation
>+        https://bugs.webkit.org/show_bug.cgi?id=193238
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Fix a flaky layout test that currently attempts to run the main logic of the test twice (once after the child
>+        frame finishes loading, and another time after the main document finishes loading). This leads to a race
>+        condition in the test where the incorrect text field is focused, causing the caret rect to deviate from the
>+        expected value.
>+
>+        * editing/selection/ios/show-selection-in-empty-overflow-hidden-document.html:
>+
> 2019-01-08  Jiewen Tan  <jiewen_tan@apple.com>
> 
>         [WebAuthN] Support U2F HID Authenticators on macOS
>diff --git a/LayoutTests/editing/selection/ios/show-selection-in-empty-overflow-hidden-document.html b/LayoutTests/editing/selection/ios/show-selection-in-empty-overflow-hidden-document.html
>index 47e045360783c7c60580920091664b0eb815cc6d..86c0edc77691e3843f24b1b9c03b86c9ee315c3c 100644
>--- a/LayoutTests/editing/selection/ios/show-selection-in-empty-overflow-hidden-document.html
>+++ b/LayoutTests/editing/selection/ios/show-selection-in-empty-overflow-hidden-document.html
>@@ -88,7 +88,7 @@ async function runTest() {
> </button>
> <div id="container">
>     <textarea id="editor"></textarea>
>-    <iframe id="frame" srcdoc="<textarea id='editor'></textarea>" onload="runTest()"></iframe>
>+    <iframe id="frame" srcdoc="<textarea id='editor'></textarea>"></iframe>
> </div>
> <div id="description"></div>
> <div id="console"></div>

Actions: View | Formatted Diff | Diff

Attachments on bug 193238: 358669