Attachment 358646 Details for Bug 193264 – Patch v1

[patch] Patch v1

bug-193264-20190108155832.patch (text/plain), 1.72 KB, created by David Kilzer (:ddkilzer) on 2019-01-08 15:58:33 PST

(hide)

Description:

Filename:

MIME Type:

Creator: David Kilzer (:ddkilzer)

Created: 2019-01-08 15:58:33 PST

Size: 1.72 KB

patch

obsolete

>Subversion Revision: 239709
>diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
>index 3063c6d563e6c7336cdc252dbd376fb56849cbe9..21b5a9a5f619bd1b07a6cf90b06bf95f4f037f59 100644
>--- a/Source/JavaScriptCore/ChangeLog
>+++ b/Source/JavaScriptCore/ChangeLog
>@@ -1,3 +1,19 @@
>+2019-01-08  David Kilzer  <ddkilzer@apple.com>
>+
>+        Leak of VectorBufferBase.m_buffer (16-64 bytes) under JSC::CompactVariableEnvironment in com.apple.WebKit.WebContent running layout tests
>+        <https://webkit.org/b/193264>
>+        <rdar://problem/46651026>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * parser/VariableEnvironment.cpp:
>+        (JSC::CompactVariableMap::Handle::~Handle): Call delete on
>+        m_environment instead of fastFree() to make sure the destructors
>+        for the Vector instance variables are run.  This fixes the leaks
>+        because calling fastFree() would only free the
>+        CompactVariableEnvironment object, but not the heap-based
>+        buffers allocated for the Vector instance variables.
>+
> 2019-01-07  Devin Rousso  <drousso@apple.com>
> 
>         Web Inspector: extend XHR breakpoints to work with fetch
>diff --git a/Source/JavaScriptCore/parser/VariableEnvironment.cpp b/Source/JavaScriptCore/parser/VariableEnvironment.cpp
>index 24fd233bca14e413b1b185c4e87f035b9bd8e1be..a395ff585b6bf3f1c5e6e24334dc2d60f55d5e85 100644
>--- a/Source/JavaScriptCore/parser/VariableEnvironment.cpp
>+++ b/Source/JavaScriptCore/parser/VariableEnvironment.cpp
>@@ -179,7 +179,7 @@ CompactVariableMap::Handle::~Handle()
>     if (!iter->value) {
>         ASSERT(m_environment == &iter->key.environment());
>         m_map->m_map.remove(iter);
>-        fastFree(m_environment);
>+        delete m_environment;
>     }
> }
>

Actions: View | Formatted Diff | Diff

Attachments on bug 193264: 358646