Attachment 358635 Details for Bug 192061 – Part 6.

[patch] Part 6.

bug-192061-20190108140849.patch (text/plain), 2.78 KB, created by Jiewen Tan on 2019-01-08 14:08:50 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Jiewen Tan

Created: 2019-01-08 14:08:50 PST

Size: 2.78 KB

patch

obsolete

>Subversion Revision: 239526
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 1a222fc62adc11507ca7e04ee1159a49e4f964b8..ef120d4269deaef2c09630e448ca9651c8f43ad7 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,18 @@
>+2019-01-08  Jiewen Tan  <jiewen_tan@apple.com>
>+
>+        [Mac] Layout Test http/wpt/webauthn/public-key-credential-create-success-hid.https.html and http/wpt/webauthn/public-key-credential-get-success-hid.https.html are flaky
>+        https://bugs.webkit.org/show_bug.cgi?id=192061
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Part 6.
>+
>+        Add some additional temporary logging info to determine if data is actually sent.
>+        Once the bug is determined and fixed, we should remove all logging added in this patch.
>+
>+        * UIProcess/WebAuthentication/Mock/MockHidConnection.cpp:
>+        (WebKit::MockHidConnection::send):
>+
> 2018-12-21  Alex Christensen  <achristensen@webkit.org>
> 
>         Expand use of sourceApplicationAuditData
>diff --git a/Source/WebKit/UIProcess/WebAuthentication/Mock/MockHidConnection.cpp b/Source/WebKit/UIProcess/WebAuthentication/Mock/MockHidConnection.cpp
>index b7fc80862581a99f5196a712c57a4fc0ca19a2c3..5af2fdab231ed035ef4a62a0fe79506ea19e0148 100644
>--- a/Source/WebKit/UIProcess/WebAuthentication/Mock/MockHidConnection.cpp
>+++ b/Source/WebKit/UIProcess/WebAuthentication/Mock/MockHidConnection.cpp
>@@ -69,17 +69,23 @@ void MockHidConnection::terminate()
> 
> void MockHidConnection::send(Vector<uint8_t>&& data, DataSentCallback&& callback)
> {
>+    // FIXME(192061): Remove all LOG_ERRORs.
>+    LOG_ERROR("Sending data: Phase 1. Current time: %f.", MonotonicTime::now().secondsSinceEpoch().value());
>     ASSERT(m_initialized);
>     auto task = makeBlockPtr([weakThis = makeWeakPtr(*this), data = WTFMove(data), callback = WTFMove(callback)]() mutable {
>         ASSERT(!RunLoop::isMain());
>+        LOG_ERROR("Sending data: Phase 2. Current time: %f.", MonotonicTime::now().secondsSinceEpoch().value());
>         RunLoop::main().dispatch([weakThis, data = WTFMove(data), callback = WTFMove(callback)]() mutable {
>+            LOG_ERROR("Sending data: Phase 3. Current time: %f.", MonotonicTime::now().secondsSinceEpoch().value());
>             if (!weakThis) {
>                 callback(DataSent::No);
>                 return;
>             }
> 
>+            LOG_ERROR("Sending data: Phase 4. Current time: %f.", MonotonicTime::now().secondsSinceEpoch().value());
>             weakThis->assembleRequest(WTFMove(data));
> 
>+            LOG_ERROR("Sending data: Phase 5. Current time: %f.", MonotonicTime::now().secondsSinceEpoch().value());
>             auto sent = DataSent::Yes;
>             if (weakThis->stagesMatch() && weakThis->m_configuration.hid->error == Mock::Error::DataNotSent)
>                 sent = DataSent::No;

Actions: View | Formatted Diff | Diff

Attachments on bug 192061: 356665 | 357284 | 357480 | 357622 | 357969 | 358635 | 358758 | 358844 | 358846 | 358851