Attachment 358630 Details for Bug 193254 – Patch

[patch] Patch

bug-193254-20190108133154.patch (text/plain), 2.86 KB, created by Keith Miller on 2019-01-08 13:31:54 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Keith Miller

Created: 2019-01-08 13:31:54 PST

Size: 2.86 KB

patch

obsolete

>Subversion Revision: 239723
>diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
>index 3063c6d563e6c7336cdc252dbd376fb56849cbe9..c7de58960434c6e621ebc955b091320d11a04283 100644
>--- a/Source/JavaScriptCore/ChangeLog
>+++ b/Source/JavaScriptCore/ChangeLog
>@@ -1,3 +1,15 @@
>+2019-01-08  Keith Miller  <keith_miller@apple.com>
>+
>+        Move JSValueMakeSymbol to private header
>+        https://bugs.webkit.org/show_bug.cgi?id=193254
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        When moving other functions in JSValueRef I guess I forgot to move this one.
>+
>+        * API/JSObjectRefPrivate.h:
>+        * API/JSValueRef.h:
>+
> 2019-01-07  Devin Rousso  <drousso@apple.com>
> 
>         Web Inspector: extend XHR breakpoints to work with fetch
>diff --git a/Source/JavaScriptCore/API/JSObjectRefPrivate.h b/Source/JavaScriptCore/API/JSObjectRefPrivate.h
>index 6ce97434f42c9f215287305cc42921595ac6c521..08263fe0164ce082a8642e9113aeeac040184d72 100644
>--- a/Source/JavaScriptCore/API/JSObjectRefPrivate.h
>+++ b/Source/JavaScriptCore/API/JSObjectRefPrivate.h
>@@ -130,6 +130,15 @@ JS_EXPORT void JSObjectSetPropertyForKey(JSContextRef ctx, JSObjectRef object, J
>  */
> JS_EXPORT bool JSObjectDeletePropertyForKey(JSContextRef ctx, JSObjectRef object, JSValueRef propertyKey, JSValueRef* exception) JSC_API_AVAILABLE(macosx(JSC_MAC_TBA), ios(JSC_IOS_TBA));
> 
>+/*!
>+ @function
>+ @abstract            Creates a JavaScript value of the symbol type.
>+ @param ctx           The execution context to use.
>+ @param description   A description of the newly created symbol value.
>+ @result              A unique JSValue of the symbol type, whose description matches the one provided.
>+ */
>+JS_EXPORT JSValueRef JSValueMakeSymbol(JSContextRef ctx, JSStringRef description) JSC_API_AVAILABLE(macosx(JSC_MAC_TBA), ios(JSC_IOS_TBA));
>+
> /*!
>  @function
>  @abstract       Tests whether a JavaScript value's type is the symbol type.
>diff --git a/Source/JavaScriptCore/API/JSValueRef.h b/Source/JavaScriptCore/API/JSValueRef.h
>index 5766ba2009832c91eb35a94b6db54e986122bb8f..c78a46d9a2e472ae5b1ec018bad53e9f50a26b1b 100644
>--- a/Source/JavaScriptCore/API/JSValueRef.h
>+++ b/Source/JavaScriptCore/API/JSValueRef.h
>@@ -260,15 +260,6 @@ JS_EXPORT JSValueRef JSValueMakeBoolean(JSContextRef ctx, bool boolean);
> */
> JS_EXPORT JSValueRef JSValueMakeNumber(JSContextRef ctx, double number);
> 
>-/*!
>-@function
>-@abstract            Creates a JavaScript value of the symbol type.
>-@param ctx           The execution context to use.
>-@param description   A description of the newly created symbol value.
>-@result              A unique JSValue of the symbol type, whose description matches the one provided.
>-*/
>-JS_EXPORT JSValueRef JSValueMakeSymbol(JSContextRef ctx, JSStringRef description) JSC_API_AVAILABLE(macosx(JSC_MAC_TBA), ios(JSC_IOS_TBA));
>-
> /*!
> @function
> @abstract       Creates a JavaScript value of the string type.

Flags:

saam: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 193254: 358630