WebKit Bugzilla
Attachment 358624 Details for
Bug 193251
: Call CompletionHandler when destroying a NetworkCache::Storage::WriteOperation
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-193251-20190108124840.patch (text/plain), 1.33 KB, created by
Alex Christensen
on 2019-01-08 12:48:40 PST
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Alex Christensen
Created:
2019-01-08 12:48:40 PST
Size:
1.33 KB
patch
obsolete
>Index: Source/WebKit/ChangeLog >=================================================================== >--- Source/WebKit/ChangeLog (revision 239736) >+++ Source/WebKit/ChangeLog (working copy) >@@ -1,3 +1,15 @@ >+2019-01-08 Alex Christensen <achristensen@webkit.org> >+ >+ Call CompletionHandler when destroying a NetworkCache::Storage::WriteOperation >+ https://bugs.webkit.org/show_bug.cgi?id=193251 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ This fixes another assertion introduced in r239710. >+ >+ * NetworkProcess/cache/NetworkCacheStorage.cpp: >+ (WebKit::NetworkCache::Storage::WriteOperation::~WriteOperation): >+ > 2019-01-08 Michael Catanzaro <mcatanzaro@igalia.com> > > Unreviewed, silence -Wformat warnings >Index: Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.cpp >=================================================================== >--- Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.cpp (revision 239733) >+++ Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.cpp (working copy) >@@ -112,6 +112,13 @@ public: > , mappedBodyHandler(WTFMove(mappedBodyHandler)) > , completionHandler(WTFMove(completionHandler)) > { } >+ >+ ~WriteOperation() >+ { >+ if (completionHandler) >+ completionHandler(0); >+ } >+ > Ref<Storage> storage; > > const Record record;
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Flags:
cdumez
:
review+
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 193251
: 358624