Attachment 358601 Details for Bug 193239 – Patch

[patch] Patch

bug-193239-20190108181419.patch (text/plain), 6.16 KB, created by Karl Leplat on 2019-01-08 09:14:58 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Karl Leplat

Created: 2019-01-08 09:14:58 PST

Size: 6.16 KB

patch

obsolete

>Subversion Revision: 239026
>diff --git a/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp b/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp
>index 15ae46f60d7264e1ab57c581938a5b465be3ecff..29b4c8ce37fc0ee3723689543b2e6524912376d3 100644
>--- a/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp
>+++ b/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp
>@@ -888,7 +888,7 @@ void CoordinatedGraphicsLayer::updateContentBuffers()
> 
>     if (!m_needsDisplay.completeLayer) {
>         for (auto& rect : m_needsDisplay.rects)
>-            layerState.mainBackingStore->invalidate(IntRect { rect });
>+            layerState.mainBackingStore->invalidate(enclosingIntRect(rect));
>     } else
>         layerState.mainBackingStore->invalidate({ { }, IntSize { m_size } });
> 
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 202893917e53d9aaa0af273fc573667ad8a8ea56..f684bd9a407c2f0004a4957fd0378b9bb3a4b502 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,15 @@
>+2019-01-08  Karl Leplat  <karl.leplat_ext@softathome.com>
>+
>+        [GTK][WPE] Graphic issue with invalidations on composited layers with subpixel positions
>+        https://bugs.webkit.org/show_bug.cgi?id=193239
>+
>+        Reviewed by NOBODY (OOPS!).
>+        
>+        LayoutTest:
>+        * compositing/repaint/invalidations-on-composited-layers-with-subpixel-positions-expected.png: Added.
>+        * compositing/repaint/invalidations-on-composited-layers-with-subpixel-positions-expected.txt: Added.
>+        * compositing/repaint/invalidations-on-composited-layers-with-subpixel-positions.html: Added.
>+
> 2018-12-09  Commit Queue  <commit-queue@webkit.org>
> 
>         Unreviewed, rolling out r239010.
>diff --git a/LayoutTests/compositing/repaint/invalidations-on-composited-layers-with-subpixel-positions-expected.png b/LayoutTests/compositing/repaint/invalidations-on-composited-layers-with-subpixel-positions-expected.png
>new file mode 100644
>index 0000000000000000000000000000000000000000..55285d1a102342101c1e7c83133f9d9376557ca3
>GIT binary patch
>literal 3084
>zcmeAS@N?(olHy`uVBq!ia0y~yU{+vYV2a>i0*Z)=h^hlA%@Ws$lH`ok<m}?oTm~~U
>z3ll?g^R&d|MDw&H3q!+1!xV!g!z8mL0}GR+G{c|1XO9Clu_bxCyD<C*!3BGlPiA1?
>zZufL?45^s&_U^(y;XsDAi<-Bcq-2s}c@JJo6xga!bHDU{a`PG&1-B_Ik#}~@y*ojF
>z^U1T8NoP#=|0$Y$^6s4T&p8<y&h6eV$G~79)yT>qARNKKU`S2IZM*UhA3kh&#>dc*
>zxZ@xbLkFi0L&J;%WHa^(MEw3+xB2E8V^)R)9`D9d3mL!Vmp@j-<nl5cV3@{~z5TXr
>zEh9t4(zl0hJ}sL0{AbnPb=%k&5*UC=ci(+h8JEk&a6saZD+dkyN+9qyiZf;Jzn^b5
>zyL1@?Lr<dS2EO*gFH5ZC`d6=IWRN%zl<>A}_i}v(hV@%wEq2G~eYS~TfBot;1_qu4
>z%?)|mZ`+(-?F&@byq|-SA&H5bK|yT;13|{OH^G+o?JHH-86MPACHO@m<n8<}r%hF5
>zU}%ouS@T=}^2g&}e%_8sW?*pJAQ4gietG7scV(}AfG#~;_VUB^^Dlo@|FT|h3XB4l
>z?ncwQ%k1}uOEEDRaMcSkF&tqLV{q_EU?j+R^K*I8zIowu7#R%s%&DD32}B!Jv%{!e
>zv?ydoLv=J%satK0rl`>rHJYM^Yc9BLXJ@zXD;tB<_wV2HZ5d~%f!Y+7<TrbNvp2Y!
>b-k5mdpEIzL&fw|l=d#Wzp-I`*-;E0ZE>t*U
>
>literal 0
>HcmV?d00001
>
>diff --git a/LayoutTests/compositing/repaint/invalidations-on-composited-layers-with-subpixel-positions-expected.txt b/LayoutTests/compositing/repaint/invalidations-on-composited-layers-with-subpixel-positions-expected.txt
>new file mode 100644
>index 0000000000000000000000000000000000000000..afbc5ef9a70216dcfca47dd4722b1bfbbbbe5809
>--- /dev/null
>+++ b/LayoutTests/compositing/repaint/invalidations-on-composited-layers-with-subpixel-positions-expected.txt
>@@ -0,0 +1,21 @@
>+layer at (0,0) size 1288x585
>+  RenderView at (0,0) size 800x585
>+layer at (0,0) size 800x122
>+  RenderBlock {HTML} at (0,0) size 800x123
>+    RenderBody {BODY} at (8,20) size 784x95
>+      RenderBlock {DIV} at (0,0) size 1280x94
>+        RenderBlock {DIV} at (0,0) size 1280x94
>+layer at (0,0) size 800x585
>+  RenderBlock (positioned) {DIV} at (0,0) size 800x585
>+layer at (8,21) size 1280x31
>+  RenderBlock (relative positioned) {DIV} at (0,0) size 1280x32 [color=#FFFFFF] [bgcolor=#333333]
>+    RenderText {#text} at (0,0) size 5x24
>+      text run at (0,0) width 5: "."
>+layer at (8,52) size 1280x31
>+  RenderBlock (relative positioned) {DIV} at (0,31) size 1280x32 [color=#FFFFFF] [bgcolor=#333333]
>+    RenderText {#text} at (0,0) size 5x24
>+      text run at (0,0) width 5: "."
>+layer at (8,83) size 1280x32
>+  RenderBlock (relative positioned) {DIV} at (0,62) size 1280x32 [color=#FFFFFF] [bgcolor=#FF6600]
>+    RenderText {#text} at (0,0) size 5x24
>+      text run at (0,0) width 5: "."
>diff --git a/LayoutTests/compositing/repaint/invalidations-on-composited-layers-with-subpixel-positions.html b/LayoutTests/compositing/repaint/invalidations-on-composited-layers-with-subpixel-positions.html
>new file mode 100644
>index 0000000000000000000000000000000000000000..c450282dc7161122bf6540fe70ea86a777e15928
>--- /dev/null
>+++ b/LayoutTests/compositing/repaint/invalidations-on-composited-layers-with-subpixel-positions.html
>@@ -0,0 +1,42 @@
>+<!DOCTYPE html>
>+
>+<html>
>+    <head>
>+        <style type="text/css">
>+            .sah_select {
>+                width: 1280px;
>+                font-size: 1.3em;
>+                margin-top: 1em;
>+            }
>+            .sah_option {
>+                position: relative;
>+                height: 1.5em;
>+                background-color: #333;
>+                color: white;
>+            }
>+            .sah_option.selected {
>+                background-color: #F60;
>+            }
>+    </style>
>+    <script src="../../fast/repaint/resources/repaint.js"></script>
>+    <script>
>+        function repaintTest() {
>+            document.getElementById("opt1").className = "sah_option";
>+            document.getElementById("opt2").className = "sah_option selected";
>+            document.getElementById("opt2").className = "sah_option";
>+            document.getElementById("opt3").className = "sah_option selected";
>+        }
>+    </script>
>+</head>
>+<body onload="runRepaintTest()">
>+<div id="forceAcceleratedCompositing" style="position:absolute;left:0;right:0;top:0;bottom:0;-webkit-transform: translate3d(0, 0, 0);"></div>
>+
>+    <div class="sah_select">
>+      <div>
>+            <div class="sah_option selected" id="opt1">.</div>
>+            <div class="sah_option" id="opt2">.</div>
>+            <div class="sah_option" id="opt3">.</div>
>+        </div>
>+    </div>
>+</body>
>+</html>

Actions: View | Formatted Diff | Diff

Attachments on bug 193239: 358598 | 358600 | 358601 | 358608 | 358614 | 358615 | 358638 | 358682 | 358692 | 358699 | 358700 | 358704 | 358705 | 358707 | 358709 | 358711 | 358785 | 359021