Attachment 358588 Details for Bug 193234 – Proposed patch

[patch] Proposed patch

ews-build-clean-webkit-v2.patch (text/plain), 1.76 KB, created by Aakash Jain on 2019-01-08 07:25:14 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Aakash Jain

Created: 2019-01-08 07:25:14 PST

Size: 1.76 KB

patch

obsolete

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 239724)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,14 @@
>+2019-01-08  Aakash Jain  <aakash_jain@apple.com>
>+
>+        [ews-build] unapply-patch step should not update source
>+        https://bugs.webkit.org/show_bug.cgi?id=193234
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * BuildSlaveSupport/ews-build/steps.py:
>+        (CleanWorkingDirectory): Use clean-webkit script to clean the working directory.
>+        (UnApplyPatchIfRequired): Use CleanWorkingDirectory as base class.
>+
> 2019-01-07  David Kilzer  <ddkilzer@apple.com>
> 
>         Leak of ScrollCompletionCallbackData (16 bytes) in com.apple.WebKit.WebContent running WebKit layout tests
>Index: Tools/BuildSlaveSupport/ews-build/steps.py
>===================================================================
>--- Tools/BuildSlaveSupport/ews-build/steps.py	(revision 239723)
>+++ Tools/BuildSlaveSupport/ews-build/steps.py	(working copy)
>@@ -106,6 +106,15 @@ class CheckOutSource(git.Git):
>                                                 **kwargs)
> 
> 
>+class CleanWorkingDirectory(shell.ShellCommand):
>+    name = 'clean-working-directory'
>+    description = ['clean-workring-directory running']
>+    descriptionDone = ['clean-working-directory']
>+    flunkOnFailure = True
>+    haltOnFailure = True
>+    command = ['Tools/Scripts/clean-webkit']
>+
>+
> class ApplyPatch(shell.ShellCommand, CompositeStepMixin):
>     name = 'apply-patch'
>     description = ['applying-patch']
>@@ -353,7 +362,7 @@ class ValidatePatch(buildstep.BuildStep)
>         return None
> 
> 
>-class UnApplyPatchIfRequired(CheckOutSource):
>+class UnApplyPatchIfRequired(CleanWorkingDirectory):
>     name = 'unapply-patch'
> 
>     def doStepIf(self, step):

Flags:

lforschler: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 193234: 358586 | 358588