Attachment 358549 Details for Bug 193217 – Patch for landing

[patch] Patch for landing

bug-193217-20190107160130.patch (text/plain), 1.76 KB, created by youenn fablet on 2019-01-07 16:01:31 PST

(hide)

Description:

Filename:

MIME Type:

Creator: youenn fablet

Created: 2019-01-07 16:01:31 PST

Size: 1.76 KB

patch

obsolete

>Subversion Revision: 239660
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 0abcdb8ea34f7b9361951217cdd8e5912b7cd8e7..98e759a06f993573c932b50d28d1d6d3f4b80f7d 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,18 @@
>+2019-01-07  Youenn Fablet  <youenn@apple.com>
>+
>+        Crash in SWServer::Connection::resolveRegistrationReadyRequests
>+        https://bugs.webkit.org/show_bug.cgi?id=193217
>+
>+        Reviewed by Chris Dumez.
>+
>+        As can be seen from the traces, SWServer might clear its connections HashMap in its destructor.
>+        This might then trigger calling SWServer::resolveRegistrationReadyRequests.
>+        This method is iterating on the connections HashMap which is being cleared.
>+        To remove this problem, move the HashMap in a temporary variable and clear the temporary variable.
>+
>+        * workers/service/server/SWServer.cpp:
>+        (WebCore::SWServer::~SWServer):
>+
> 2019-01-07  Youenn Fablet  <youenn@apple.com>
> 
>         IDB storage of Crypto keys does not work in private browsing mode
>diff --git a/Source/WebCore/workers/service/server/SWServer.cpp b/Source/WebCore/workers/service/server/SWServer.cpp
>index f876b82be6abf11235f6a2697ce25adad91fe777..044bc841388279dd52a6634e6b2b1335674c66be 100644
>--- a/Source/WebCore/workers/service/server/SWServer.cpp
>+++ b/Source/WebCore/workers/service/server/SWServer.cpp
>@@ -66,7 +66,8 @@ SWServer::~SWServer()
> {
>     // Destroy the remaining connections before the SWServer gets destroyed since they have a raw pointer
>     // to the server and since they try to unregister clients from the server in their destructor.
>-    m_connections.clear();
>+    auto connections = WTFMove(m_connections);
>+    connections.clear();
> 
>     allServers().remove(this);
> }

Actions: View | Formatted Diff | Diff

Attachments on bug 193217: 358539 | 358549