Attachment 358546 Details for Bug 193221 – Patch

[patch] Patch

bug-193221-20190108004106.patch (text/plain), 1.53 KB, created by Tadeu Zagallo on 2019-01-07 15:41:14 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Tadeu Zagallo

Created: 2019-01-07 15:41:14 PST

Size: 1.53 KB

patch

obsolete

>Subversion Revision: 239704
>diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
>index 3063c6d563e6c7336cdc252dbd376fb56849cbe9..6ce2517ccc4798138b91251e860076b382d23f01 100644
>--- a/Source/JavaScriptCore/ChangeLog
>+++ b/Source/JavaScriptCore/ChangeLog
>@@ -1,3 +1,16 @@
>+2019-01-07  Tadeu Zagallo  <tzagallo@apple.com>
>+
>+        LLInt put_by_id uses the wrong load instruction for loading flags from the metadata
>+        https://bugs.webkit.org/show_bug.cgi?id=193221
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        The flags are only 4 bytes, but were loaded with loadp. It used to work,
>+        since the flags were followed by a 4-byte padding, but it broke after the
>+        struct was compacted in r239626.
>+
>+        * llint/LowLevelInterpreter64.asm:
>+
> 2019-01-07  Devin Rousso  <drousso@apple.com>
> 
>         Web Inspector: extend XHR breakpoints to work with fetch
>diff --git a/Source/JavaScriptCore/llint/LowLevelInterpreter64.asm b/Source/JavaScriptCore/llint/LowLevelInterpreter64.asm
>index 2e7ed9ecb6c4d62762565f40c20f4cea083600f7..eed2a0fb2231db565c4bbfe11d4c06c451d47faf 100644
>--- a/Source/JavaScriptCore/llint/LowLevelInterpreter64.asm
>+++ b/Source/JavaScriptCore/llint/LowLevelInterpreter64.asm
>@@ -1341,7 +1341,7 @@ llintOpWithMetadata(op_put_by_id, OpPutById, macro (size, get, dispatch, metadat
>     get(value, t1)
>     loadConstantOrVariable(size, t1, t3)
> 
>-    loadp OpPutById::Metadata::flags[t5], t1
>+    loadi OpPutById::Metadata::flags[t5], t1
> 
>     # At this point, we have:
>     # t0 -> object base

Actions: View | Formatted Diff | Diff

Attachments on bug 193221: 358546 | 358607