WebKit Bugzilla
Attachment 358533 Details for
Bug 193214
: Turn on Pointer Events by default for iOS
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-193214-20190108095444.patch (text/plain), 18.49 KB, created by
Dean Jackson
on 2019-01-07 14:54:46 PST
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Dean Jackson
Created:
2019-01-07 14:54:46 PST
Size:
18.49 KB
patch
obsolete
>Subversion Revision: 239689 >diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog >index 6cfd088e3cecd824f2ef6dfac9a2db9d799ce756..adeb26d9331356e37564e8b4e172b9ba943f7a4c 100644 >--- a/Source/WebKit/ChangeLog >+++ b/Source/WebKit/ChangeLog >@@ -1,3 +1,16 @@ >+2019-01-07 Dean Jackson <dino@apple.com> >+ >+ Turn on Pointer Events by default for iOS >+ https://bugs.webkit.org/show_bug.cgi?id=193214 >+ <rdar://problem/46974878> >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ Turn on Pointer Events. >+ >+ * Shared/WebPreferences.yaml: >+ * Shared/WebPreferencesDefaultValues.h: Make a new #define for iOS. >+ > 2019-01-07 Antti Koivisto <antti@apple.com> > > UI process side scrollbars for UI side compositing on Mac >diff --git a/Source/WebKit/Shared/WebPreferences.yaml b/Source/WebKit/Shared/WebPreferences.yaml >index 20614ae3687924deed66b6d2160af23fbe2fb8c5..a640597e507b889e7c2b1e22358dfe025201b928 100644 >--- a/Source/WebKit/Shared/WebPreferences.yaml >+++ b/Source/WebKit/Shared/WebPreferences.yaml >@@ -1240,7 +1240,7 @@ VisualViewportAPIEnabled: > > PointerEventsEnabled: > type: bool >- defaultValue: false >+ defaultValue: DEFAULT_POINTER_EVENTS_ENABLED > humanReadableName: "Pointer Events" > humanReadableDescription: "Enable Pointer Events" > webcoreBinding: RuntimeEnabledFeatures >diff --git a/Source/WebKit/Shared/WebPreferencesDefaultValues.h b/Source/WebKit/Shared/WebPreferencesDefaultValues.h >index 1d07882bef39cabfa89d477f0d1fab87f81ee543..0a52167c20fa5ae0404734784a49ec91c9106ff7 100644 >--- a/Source/WebKit/Shared/WebPreferencesDefaultValues.h >+++ b/Source/WebKit/Shared/WebPreferencesDefaultValues.h >@@ -208,6 +208,12 @@ > #define DEFAULT_SERVICE_WORKERS_ENABLED false > #endif > >+#if PLATFORM(IOS_FAMILY) >+#define DEFAULT_POINTER_EVENTS_ENABLED true >+#else >+#define DEFAULT_POINTER_EVENTS_ENABLED false >+#endif >+ > #if PLATFORM(MAC) || PLATFORM(IOS) > #define DEFAULT_PROCESS_SWAP_ON_CROSS_SITE_NAVIGATION_ENABLED true > #else >diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog >index d0cf93405d973ef4051d9200475b79e20654b891..a4a6583826c984830738db358e1a15003099035f 100644 >--- a/LayoutTests/ChangeLog >+++ b/LayoutTests/ChangeLog >@@ -1,3 +1,18 @@ >+2019-01-07 Dean Jackson <dino@apple.com> >+ >+ Turn on Pointer Events by default for iOS >+ https://bugs.webkit.org/show_bug.cgi?id=193214 >+ <rdar://problem/46974878> >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ Skip the pointer events tests everywhere but iOS. >+ >+ * TestExpectations: >+ * platform/ios-wk1/TestExpectations: >+ * platform/ios-wk2/TestExpectations: >+ * platform/mac-wk1/TestExpectations: >+ > 2019-01-07 Wenson Hsieh <wenson_hsieh@apple.com> > > Native caret shows up alongside the page's caret when requesting desktop site on jsfiddle.net >diff --git a/LayoutTests/imported/w3c/ChangeLog b/LayoutTests/imported/w3c/ChangeLog >index 60ce6517d77823c4bbca6d055fad9a3c78e9e667..22d9f066f9ade70b4d5b14b997ac8fb50b8dec7d 100644 >--- a/LayoutTests/imported/w3c/ChangeLog >+++ b/LayoutTests/imported/w3c/ChangeLog >@@ -1,3 +1,17 @@ >+2019-01-07 Dean Jackson <dino@apple.com> >+ >+ Turn on Pointer Events by default for iOS >+ https://bugs.webkit.org/show_bug.cgi?id=193214 >+ <rdar://problem/46974878> >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ Update expected results. >+ >+ * web-platform-tests/pointerevents/extension/pointerevent_touch-action-verification-expected.txt: >+ * web-platform-tests/pointerevents/pointerevent_touch-action-illegal-expected.txt: >+ * web-platform-tests/pointerevents/pointerevent_touch-action-verification-expected.txt: >+ > 2019-01-05 Youenn Fablet <youenn@apple.com> > > Service Worker fetch should obey its referrer policy >diff --git a/LayoutTests/TestExpectations b/LayoutTests/TestExpectations >index 4d5c642b9a2b70e5c26b0e6af498f4465f17876c..675456c42f3927f6b0a6f205265ff170bbb01788 100644 >--- a/LayoutTests/TestExpectations >+++ b/LayoutTests/TestExpectations >@@ -434,6 +434,10 @@ fast/web-share [ Skip ] > # This test was created to test a mac-wk2 bugfix > fast/animation/request-animation-frame-in-two-pages.html [ Skip ] > >+# Only supported on iOS >+imported/w3c/web-platform-tests/pointerevents [ Skip ] >+pointerevents [ Skip ] >+ > #////////////////////////////////////////////////////////////////////////////////////////// > # End platform-specific tests. > #////////////////////////////////////////////////////////////////////////////////////////// >diff --git a/LayoutTests/imported/w3c/web-platform-tests/pointerevents/extension/pointerevent_touch-action-verification-expected.txt b/LayoutTests/imported/w3c/web-platform-tests/pointerevents/extension/pointerevent_touch-action-verification-expected.txt >index c5b110db4f214dfd829981600121d14728ef9365..b04398c98e3cacc975496a0f5d516ec9065d1282 100644 >--- a/LayoutTests/imported/w3c/web-platform-tests/pointerevents/extension/pointerevent_touch-action-verification-expected.txt >+++ b/LayoutTests/imported/w3c/web-platform-tests/pointerevents/extension/pointerevent_touch-action-verification-expected.txt >@@ -7,45 +7,45 @@ touch-action: basic verification > The following pointer types were detected: . > > >-FAIL default assert_equals: expected (undefined) undefined but got (string) "auto" >-FAIL stylesheet-none assert_equals: expected (undefined) undefined but got (string) "none" >-FAIL explicit-auto assert_equals: expected (undefined) undefined but got (string) "auto" >-FAIL explicit-pan-x assert_equals: expected (undefined) undefined but got (string) "pan-x" >-FAIL explicit-pan-left assert_equals: expected (undefined) undefined but got (string) "pan-left" >-FAIL explicit-pan-right assert_equals: expected (undefined) undefined but got (string) "pan-right" >-FAIL explicit-pan-y assert_equals: expected (undefined) undefined but got (string) "pan-y" >-FAIL explicit-pan-up assert_equals: expected (undefined) undefined but got (string) "pan-up" >-FAIL explicit-pan-down assert_equals: expected (undefined) undefined but got (string) "pan-down" >-FAIL explicit-pinch-zoom assert_equals: expected (undefined) undefined but got (string) "pinch-zoom" >-FAIL explicit-pan-x-pan-y assert_equals: expected (undefined) undefined but got (string) "pan-x pan-y" >-FAIL explicit-pan-y-pan-x assert_equals: expected (undefined) undefined but got (string) "pan-x pan-y" >-FAIL explicit-pan-left-pan-up assert_equals: expected (undefined) undefined but got (string) "pan-left pan-up" >-FAIL explicit-pan-left-pan-down assert_equals: expected (undefined) undefined but got (string) "pan-left pan-down" >-FAIL explicit-pan-right-pan-up assert_equals: expected (undefined) undefined but got (string) "pan-right pan-up" >-FAIL explicit-pan-right-pan-down assert_equals: expected (undefined) undefined but got (string) "pan-right pan-down" >-FAIL explicit-pan-up-pan-left assert_equals: expected (undefined) undefined but got (string) "pan-left pan-up" >-FAIL explicit-pan-up-pan-right assert_equals: expected (undefined) undefined but got (string) "pan-right pan-up" >-FAIL explicit-pan-down-pan-left assert_equals: expected (undefined) undefined but got (string) "pan-left pan-down" >-FAIL explicit-pan-down-pan-right assert_equals: expected (undefined) undefined but got (string) "pan-right pan-down" >-FAIL explicit-pinch-zoom-pan-x-pan-up assert_equals: expected (undefined) undefined but got (string) "pan-x pan-up pinch-zoom" >-FAIL explicit-pinch-zoom-pan-x-pan-y assert_equals: expected (undefined) undefined but got (string) "manipulation" >-FAIL explicit-manipulation assert_equals: expected (undefined) undefined but got (string) "manipulation" >-FAIL explicit-none assert_equals: expected (undefined) undefined but got (string) "none" >-FAIL explicit-invalid-1 assert_equals: expected (undefined) undefined but got (string) "auto" >-FAIL explicit-invalid-2 assert_equals: expected (undefined) undefined but got (string) "none" >-FAIL explicit-invalid-3 assert_equals: expected (undefined) undefined but got (string) "auto" >-FAIL explicit-invalid-4 assert_equals: expected (undefined) undefined but got (string) "auto" >-FAIL explicit-invalid-5 assert_equals: expected (undefined) undefined but got (string) "auto" >-FAIL explicit-invalid-6 assert_equals: expected (undefined) undefined but got (string) "auto" >-FAIL explicit-invalid-7 assert_equals: expected (undefined) undefined but got (string) "auto" >-FAIL explicit-invalid-8 assert_equals: expected (undefined) undefined but got (string) "auto" >-FAIL explicit-invalid-9 assert_equals: expected (undefined) undefined but got (string) "auto" >-FAIL explicit-invalid-10 assert_equals: expected (undefined) undefined but got (string) "auto" >-FAIL explicit-invalid-11 assert_equals: expected (undefined) undefined but got (string) "auto" >-FAIL explicit-invalid-12 assert_equals: expected (undefined) undefined but got (string) "auto" >-FAIL explicit-invalid-13 assert_equals: expected (undefined) undefined but got (string) "auto" >-FAIL explicit-invalid-14 assert_equals: expected (undefined) undefined but got (string) "auto" >-FAIL not-inherited assert_equals: expected (undefined) undefined but got (string) "auto" >-FAIL inherit assert_equals: expected (undefined) undefined but got (string) "none" >-FAIL initial assert_equals: expected (undefined) undefined but got (string) "auto" >+PASS default >+FAIL stylesheet-none assert_equals: expected "auto" but got "none" >+PASS explicit-auto >+FAIL explicit-pan-x assert_equals: expected "auto" but got "pan-x" >+FAIL explicit-pan-left assert_equals: expected "auto" but got "pan-left" >+FAIL explicit-pan-right assert_equals: expected "auto" but got "pan-right" >+FAIL explicit-pan-y assert_equals: expected "auto" but got "pan-y" >+FAIL explicit-pan-up assert_equals: expected "auto" but got "pan-up" >+FAIL explicit-pan-down assert_equals: expected "auto" but got "pan-down" >+FAIL explicit-pinch-zoom assert_equals: expected "auto" but got "pinch-zoom" >+FAIL explicit-pan-x-pan-y assert_equals: expected "auto" but got "pan-x pan-y" >+FAIL explicit-pan-y-pan-x assert_equals: expected "auto" but got "pan-x pan-y" >+FAIL explicit-pan-left-pan-up assert_equals: expected "auto" but got "pan-left pan-up" >+FAIL explicit-pan-left-pan-down assert_equals: expected "auto" but got "pan-left pan-down" >+FAIL explicit-pan-right-pan-up assert_equals: expected "auto" but got "pan-right pan-up" >+FAIL explicit-pan-right-pan-down assert_equals: expected "auto" but got "pan-right pan-down" >+FAIL explicit-pan-up-pan-left assert_equals: expected "auto" but got "pan-left pan-up" >+FAIL explicit-pan-up-pan-right assert_equals: expected "auto" but got "pan-right pan-up" >+FAIL explicit-pan-down-pan-left assert_equals: expected "auto" but got "pan-left pan-down" >+FAIL explicit-pan-down-pan-right assert_equals: expected "auto" but got "pan-right pan-down" >+FAIL explicit-pinch-zoom-pan-x-pan-up assert_equals: expected "auto" but got "pan-x pan-up pinch-zoom" >+FAIL explicit-pinch-zoom-pan-x-pan-y assert_equals: expected "auto" but got "manipulation" >+PASS explicit-manipulation >+FAIL explicit-none assert_equals: expected "auto" but got "none" >+PASS explicit-invalid-1 >+FAIL explicit-invalid-2 assert_equals: expected "auto" but got "none" >+PASS explicit-invalid-3 >+PASS explicit-invalid-4 >+PASS explicit-invalid-5 >+PASS explicit-invalid-6 >+PASS explicit-invalid-7 >+PASS explicit-invalid-8 >+PASS explicit-invalid-9 >+PASS explicit-invalid-10 >+PASS explicit-invalid-11 >+PASS explicit-invalid-12 >+PASS explicit-invalid-13 >+PASS explicit-invalid-14 >+PASS not-inherited >+FAIL inherit assert_equals: expected "auto" but got "none" >+PASS initial > >diff --git a/LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_touch-action-illegal-expected.txt b/LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_touch-action-illegal-expected.txt >index 563bd2059479fe657fbe2af865f72b9b331b1570..c02deb3a087b24abc79395eec1ddf9971dbe9e47 100644 >--- a/LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_touch-action-illegal-expected.txt >+++ b/LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_touch-action-illegal-expected.txt >@@ -7,7 +7,7 @@ touch-action: none > The following pointer types were detected: (none). > > >-FAIL 'pan-x none' is corrected properly assert_true: 'pan-x none' is corrected properly expected true got false >-FAIL 'pan-y none' is corrected properly assert_true: 'pan-y none' is corrected properly expected true got false >-FAIL 'auto none' is corrected properly assert_true: 'auto none' is corrected properly expected true got false >+PASS 'pan-x none' is corrected properly >+PASS 'pan-y none' is corrected properly >+PASS 'auto none' is corrected properly > >diff --git a/LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_touch-action-verification-expected.txt b/LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_touch-action-verification-expected.txt >index 771bba164c6b27ed4d624bd1b1699510a080135c..123f93ea4b75e5404afed21f28d3d85c07e4f538 100644 >--- a/LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_touch-action-verification-expected.txt >+++ b/LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_touch-action-verification-expected.txt >@@ -5,29 +5,29 @@ Test Description: Test will automatically check parsing behaviour of various tou > touch-action: basic verification > > >-FAIL default assert_equals: expected (undefined) undefined but got (string) "auto" >-FAIL stylesheet-none assert_equals: expected (undefined) undefined but got (string) "none" >-FAIL explicit-auto assert_equals: expected (undefined) undefined but got (string) "auto" >-FAIL explicit-pan-x assert_equals: expected (undefined) undefined but got (string) "pan-x" >-FAIL explicit-pan-y assert_equals: expected (undefined) undefined but got (string) "pan-y" >-FAIL explicit-pan-x-pan-y assert_equals: expected (undefined) undefined but got (string) "pan-x pan-y" >-FAIL explicit-pan-y-pan-x assert_equals: expected (undefined) undefined but got (string) "pan-x pan-y" >-FAIL explicit-manipulation assert_equals: expected (undefined) undefined but got (string) "manipulation" >-FAIL explicit-none assert_equals: expected (undefined) undefined but got (string) "none" >-FAIL explicit-invalid-1 assert_equals: expected (undefined) undefined but got (string) "auto" >-FAIL explicit-invalid-2 assert_equals: expected (undefined) undefined but got (string) "none" >-FAIL explicit-invalid-3 assert_equals: expected (undefined) undefined but got (string) "auto" >-FAIL explicit-invalid-4 assert_equals: expected (undefined) undefined but got (string) "auto" >-FAIL explicit-invalid-5 assert_equals: expected (undefined) undefined but got (string) "auto" >-FAIL explicit-invalid-6 assert_equals: expected (undefined) undefined but got (string) "auto" >-FAIL explicit-invalid-7 assert_equals: expected (undefined) undefined but got (string) "auto" >-FAIL explicit-invalid-8 assert_equals: expected (undefined) undefined but got (string) "auto" >-FAIL explicit-invalid-9 assert_equals: expected (undefined) undefined but got (string) "auto" >-FAIL explicit-invalid-10 assert_equals: expected (undefined) undefined but got (string) "auto" >-FAIL explicit-invalid-11 assert_equals: expected (undefined) undefined but got (string) "auto" >-FAIL explicit-invalid-12 assert_equals: expected (undefined) undefined but got (string) "auto" >-FAIL explicit-invalid-13 assert_equals: expected (undefined) undefined but got (string) "auto" >-FAIL not-inherited assert_equals: expected (undefined) undefined but got (string) "auto" >-FAIL inherit assert_equals: expected (undefined) undefined but got (string) "none" >-FAIL initial assert_equals: expected (undefined) undefined but got (string) "auto" >+PASS default >+FAIL stylesheet-none assert_equals: expected "auto" but got "none" >+PASS explicit-auto >+FAIL explicit-pan-x assert_equals: expected "auto" but got "pan-x" >+FAIL explicit-pan-y assert_equals: expected "auto" but got "pan-y" >+FAIL explicit-pan-x-pan-y assert_equals: expected "auto" but got "pan-x pan-y" >+FAIL explicit-pan-y-pan-x assert_equals: expected "auto" but got "pan-x pan-y" >+PASS explicit-manipulation >+FAIL explicit-none assert_equals: expected "auto" but got "none" >+PASS explicit-invalid-1 >+FAIL explicit-invalid-2 assert_equals: expected "auto" but got "none" >+PASS explicit-invalid-3 >+PASS explicit-invalid-4 >+PASS explicit-invalid-5 >+PASS explicit-invalid-6 >+PASS explicit-invalid-7 >+PASS explicit-invalid-8 >+PASS explicit-invalid-9 >+PASS explicit-invalid-10 >+PASS explicit-invalid-11 >+PASS explicit-invalid-12 >+PASS explicit-invalid-13 >+PASS not-inherited >+FAIL inherit assert_equals: expected "auto" but got "none" >+PASS initial > >diff --git a/LayoutTests/platform/ios-wk1/TestExpectations b/LayoutTests/platform/ios-wk1/TestExpectations >index 31dd1e304cd982c0da85e70aca30cca538b31887..3617a550ea6d66ed1268c6bcb8b7ad49c91f0f36 100644 >--- a/LayoutTests/platform/ios-wk1/TestExpectations >+++ b/LayoutTests/platform/ios-wk1/TestExpectations >@@ -23,10 +23,6 @@ webrtc [ Skip ] > # Not supported on WK1 > media/no-fullscreen-when-hidden.html [ Skip ] > >-# Skip pointerevents on WK1 >-pointerevents [ Skip ] >-imported/w3c/web-platform-tests/pointerevents [ Skip ] >- > # Datalist is unsupported in WK1 > fast/forms/datalist [ WontFix ] > imported/w3c/web-platform-tests/html/semantics/forms/the-datalist-element [ WontFix ] >diff --git a/LayoutTests/platform/ios-wk2/TestExpectations b/LayoutTests/platform/ios-wk2/TestExpectations >index c36183dda7a10cd08b0519fd31dabc5bc8df56bf..6f001e8b526748a615b4e92de6e2d63fa64ef8dd 100644 >--- a/LayoutTests/platform/ios-wk2/TestExpectations >+++ b/LayoutTests/platform/ios-wk2/TestExpectations >@@ -55,6 +55,9 @@ applicationmanifest/ [ Pass ] > > webkit.org/b/187773 http/tests/webAPIStatistics [ Pass ] > >+imported/w3c/web-platform-tests/pointerevents [ Pass ] >+pointerevents [ Pass ] >+ > #////////////////////////////////////////////////////////////////////////////////////////// > # End platform-specific directories. > #////////////////////////////////////////////////////////////////////////////////////////// >diff --git a/LayoutTests/platform/mac-wk1/TestExpectations b/LayoutTests/platform/mac-wk1/TestExpectations >index 0568fa5d0c29b23561ec400568f3303abc6d0338..ba723afd289cbedc9240ecbda524fb6c06b4365b 100644 >--- a/LayoutTests/platform/mac-wk1/TestExpectations >+++ b/LayoutTests/platform/mac-wk1/TestExpectations >@@ -166,10 +166,6 @@ webrtc/datachannel [ Pass ] > webrtc/datachannel/mdns-ice-candidates.html [ Skip ] > imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-setLocalDescription-offer.html [ Failure ] > >-# Skip pointerevents on WK1 >-pointerevents [ Skip ] >-imported/w3c/web-platform-tests/pointerevents [ Skip ] >- > # Datalist is unsupported in WK1 > fast/forms/datalist [ WontFix ] > imported/w3c/web-platform-tests/html/semantics/forms/the-datalist-element [ WontFix ]
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Flags:
wenson_hsieh
:
review+
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 193214
: 358533