Attachment 358526 Details for Bug 193208 – Patch

[patch] Patch

bug-193208-20190108105236.patch (text/plain), 1.95 KB, created by Eric Carlson on 2019-01-07 13:52:37 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Eric Carlson

Created: 2019-01-07 13:52:37 PST

Size: 1.95 KB

patch

obsolete

>Subversion Revision: 239676
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 3b718d102b27c05fb479747b9368f58f924e93e2..127e8afa037c6e205f89c175954d105d87ef4fbf 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,15 @@
>+2019-01-07  Eric Carlson  <eric.carlson@apple.com>
>+
>+        Cleanup AudioTrackPrivateMediaStreamCocoa
>+        https://bugs.webkit.org/show_bug.cgi?id=193208
>+        <rdar://problem/42225870>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * platform/mediastream/mac/AudioTrackPrivateMediaStreamCocoa.cpp:
>+        (WebCore::AudioTrackPrivateMediaStreamCocoa::audioSamplesAvailable): Clear input and
>+        output format descriptions after stopping the audio unit.
>+
> 2019-01-07  Zalan Bujtas  <zalan@apple.com>
> 
>         [LFC][BFC] Margin collapsing should not be limited to in-flow non-replaced boxes.
>diff --git a/Source/WebCore/platform/mediastream/mac/AudioTrackPrivateMediaStreamCocoa.cpp b/Source/WebCore/platform/mediastream/mac/AudioTrackPrivateMediaStreamCocoa.cpp
>index 478718a68f9e71c7262d7ff38d318e009e886974..902b0bbf6390c487c9360b2593f90afa1c70faba 100644
>--- a/Source/WebCore/platform/mediastream/mac/AudioTrackPrivateMediaStreamCocoa.cpp
>+++ b/Source/WebCore/platform/mediastream/mac/AudioTrackPrivateMediaStreamCocoa.cpp
>@@ -172,15 +172,15 @@ void AudioTrackPrivateMediaStreamCocoa::audioSamplesAvailable(const MediaTime& s
> 
>     if (!m_inputDescription || *m_inputDescription != description) {
> 
>-        m_inputDescription = nullptr;
>-        m_outputDescription = nullptr;
>-
>         if (m_remoteIOUnit) {
>             AudioOutputUnitStop(m_remoteIOUnit);
>             AudioComponentInstanceDispose(m_remoteIOUnit);
>             m_remoteIOUnit = nullptr;
>         }
> 
>+        m_inputDescription = nullptr;
>+        m_outputDescription = nullptr;
>+
>         CAAudioStreamDescription inputDescription = toCAAudioStreamDescription(description);
>         CAAudioStreamDescription outputDescription;
>

Actions: View | Formatted Diff | Diff

Attachments on bug 193208: 358526