Attachment 358486 Details for Bug 193044 – Patch

[patch] Patch

bug-193044-20190107183905.patch (text/plain), 1.58 KB, created by Fujii Hironori on 2019-01-07 01:39:07 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Fujii Hironori

Created: 2019-01-07 01:39:07 PST

Size: 1.58 KB

patch

obsolete

>Subversion Revision: 239666
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 3e68f076c1e3ffc6d8e97632187f9ba97e3a8df2..026b5d0a663559ae307840801feb70713d7ce0b3 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,16 @@
>+2019-01-07  Fujii Hironori  <Hironori.Fujii@sony.com>
>+
>+        [Win] EWS: wincairo-ews cannot apply a patch with *.png
>+        https://bugs.webkit.org/show_bug.cgi?id=193044
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        WinCairo EWS bots are using Windows Perl. Binary files should be
>+        opened as binary mode.
>+
>+        * Scripts/svn-apply:
>+        (handleGitBinaryChange): Use 'binmode' for binary file handles.
>+
> 2019-01-06  Fujii Hironori  <Hironori.Fujii@sony.com>
> 
>         [Win][Clang] Fix compilation warnings of MiniBrowser
>diff --git a/Tools/Scripts/svn-apply b/Tools/Scripts/svn-apply
>index d84021696296b3da206f51a96bc2811cb44ab592..ecae4ead3f75c7f8e0cdc70e22a242f70a8ceb26 100755
>--- a/Tools/Scripts/svn-apply
>+++ b/Tools/Scripts/svn-apply
>@@ -264,6 +264,7 @@ sub handleGitBinaryChange($$)
>     if (open FILE, $fullPath) {
>         die "$fullPath already exists" if $isFileAddition;
> 
>+        binmode(FILE);
>         $originalContents = join("", <FILE>);
>         close FILE;
>     }
>@@ -286,6 +287,7 @@ sub handleGitBinaryChange($$)
>             die "Original content of $fullPath mismatches" if $originalContents ne applyGitBinaryPatchDelta($reverseBinaryChunk, $out);
>         }
>         open FILE, ">", $fullPath or die "Failed to open $fullPath.";
>+        binmode(FILE);
>         print FILE $out;
>         close FILE;
>         if ($isFileAddition) {

Actions: View | Formatted Diff | Diff

Attachments on bug 193044: 358486