Attachment 358485 Details for Bug 193190 – Patch

[patch] Patch

bug-193190-20190107102743.patch (text/plain), 2.45 KB, created by Zan Dobersek on 2019-01-07 01:27:44 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Zan Dobersek

Created: 2019-01-07 01:27:44 PST

Size: 2.45 KB

patch

obsolete

>Subversion Revision: 239667
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 8c00641a45c657aa8d038db139ab69a77550f746..0f61b485c56bdeced1b24d46a5124e815bbbe10b 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,23 @@
>+2019-01-07  Zan Dobersek  <zdobersek@igalia.com>
>+
>+        [WPE] Use Widget bounds for PlatformScreen rectangle information
>+        https://bugs.webkit.org/show_bug.cgi?id=193190
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Provide a better screen area estimate in screenRect() and
>+        screenAvailableRect() return values than the current 1240x640 value by
>+        using the Widget's bounds rectangle.
>+
>+        This approach is only factually correct when the Widget-associated view
>+        is displayed in fullscreen, but it provides a better estimate even when
>+        displayed in any other case as well. WPE doesn't provide specific API
>+        that could enable the embedding environment to provide this information.
>+
>+        * platform/wpe/PlatformScreenWPE.cpp:
>+        (WebCore::screenRect): Return bounds of the Widget object.
>+        (WebCore::screenAvailableRect): Relay the call to screenRect().
>+
> 2019-01-06  Zan Dobersek  <zdobersek@igalia.com>
> 
>         [Nicosia] Take over CoordinatedGraphics-named implementation of async scrolling classes
>diff --git a/Source/WebCore/platform/wpe/PlatformScreenWPE.cpp b/Source/WebCore/platform/wpe/PlatformScreenWPE.cpp
>index a2d079b0c15739cc4e6f61cf6931e170cb00a5e4..904ebce5e83495cae1ce82df4dee13778918b640 100644
>--- a/Source/WebCore/platform/wpe/PlatformScreenWPE.cpp
>+++ b/Source/WebCore/platform/wpe/PlatformScreenWPE.cpp
>@@ -28,6 +28,7 @@
> 
> #include "FloatRect.h"
> #include "NotImplemented.h"
>+#include "Widget.h"
> 
> namespace WebCore {
> 
>@@ -65,16 +66,19 @@ void setScreenDPIObserverHandler(Function<void()>&&, void*)
>     notImplemented();
> }
> 
>-FloatRect screenRect(Widget*)
>+FloatRect screenRect(Widget* widget)
> {
>-    notImplemented();
>-    return FloatRect(0, 0, 1024, 640);
>+    // WPE can't offer any more useful information about the screen size,
>+    // so we use the Widget's bounds rectangle (size of which equals the WPE view size).
>+
>+    if (!widget)
>+        return { };
>+    return widget->boundsRect();
> }
> 
>-FloatRect screenAvailableRect(Widget*)
>+FloatRect screenAvailableRect(Widget* widget)
> {
>-    notImplemented();
>-    return FloatRect(0, 0, 1024, 640);
>+    return screenRect(widget);
> }
> 
> bool screenSupportsExtendedColor(Widget*)

Actions: View | Formatted Diff | Diff

Attachments on bug 193190: 358485