Attachment 358484 Details for Bug 193189 – Patch

[patch] Patch

bug-193189-20190107095957.patch (text/plain), 2.82 KB, created by Zan Dobersek on 2019-01-07 00:59:59 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Zan Dobersek

Created: 2019-01-07 00:59:59 PST

Size: 2.82 KB

patch

obsolete

>Subversion Revision: 239667
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 8c00641a45c657aa8d038db139ab69a77550f746..f7d810840eea53d664102bfc093b1dab6a82965a 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,21 @@
>+2019-01-07  Zan Dobersek  <zdobersek@igalia.com>
>+
>+        Make Gradient::gradientSpaceTransform(), Pattern::patternSpaceTransform() methods const
>+        https://bugs.webkit.org/show_bug.cgi?id=193189
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        The transform getter methods on the Gradient and Pattern classes both
>+        return const references to the transform objects, and don't modify any
>+        internal state. They should be marked const accordingly, allowing
>+        invocations of these two methods through const references to Gradient
>+        and Pattern objects.
>+
>+        * platform/graphics/Gradient.h:
>+        (WebCore::Gradient::gradientSpaceTransform): Now const.
>+        * platform/graphics/Pattern.h:
>+        (WebCore::Pattern::patternSpaceTransform): Now const.
>+
> 2019-01-06  Zan Dobersek  <zdobersek@igalia.com>
> 
>         [Nicosia] Take over CoordinatedGraphics-named implementation of async scrolling classes
>diff --git a/Source/WebCore/platform/graphics/Gradient.h b/Source/WebCore/platform/graphics/Gradient.h
>index 4c9577e261b7cfe2fa7455e94ca8a13c02e6577c..5a869b9d65d981c34924095058232a3c30fd238f 100644
>--- a/Source/WebCore/platform/graphics/Gradient.h
>+++ b/Source/WebCore/platform/graphics/Gradient.h
>@@ -119,7 +119,7 @@ public:
> 
>     // CG needs to transform the gradient at draw time.
>     void setGradientSpaceTransform(const AffineTransform& gradientSpaceTransformation);
>-    const AffineTransform& gradientSpaceTransform() { return m_gradientSpaceTransformation; }
>+    const AffineTransform& gradientSpaceTransform() const { return m_gradientSpaceTransformation; }
> 
>     void fill(GraphicsContext&, const FloatRect&);
>     void adjustParametersForTiledDrawing(FloatSize&, FloatRect&, const FloatSize& spacing);
>diff --git a/Source/WebCore/platform/graphics/Pattern.h b/Source/WebCore/platform/graphics/Pattern.h
>index f467a0f5bffb2754d9b9880e75760f41624a74d9..a267ea8ae40bc2d0d2f080c712d9034c3aefaf56 100644
>--- a/Source/WebCore/platform/graphics/Pattern.h
>+++ b/Source/WebCore/platform/graphics/Pattern.h
>@@ -65,7 +65,7 @@ public:
>     PlatformPatternPtr createPlatformPattern(const GraphicsContext&, float alpha, const AffineTransform& userSpaceTransformation) const;
> #endif
>     void setPatternSpaceTransform(const AffineTransform& patternSpaceTransformation);
>-    const AffineTransform& patternSpaceTransform() { return m_patternSpaceTransformation; };
>+    const AffineTransform& patternSpaceTransform() const { return m_patternSpaceTransformation; };
>     bool repeatX() const { return m_repeatX; }
>     bool repeatY() const { return m_repeatY; }
>

Actions: View | Formatted Diff | Diff

Attachments on bug 193189: 358484