Attachment 358475 Details for Bug 193186 – Patch

[patch] Patch

bug-193186-20190106204603.patch (text/plain), 3.92 KB, created by Devin Rousso on 2019-01-06 19:46:04 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Devin Rousso

Created: 2019-01-06 19:46:04 PST

Size: 3.92 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index f05867e772b1e72f1f71f2d8dd7aa992a18c40c6..2ac5c64733da225435d83164bdc653665521eb64 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,25 @@
>+2019-01-06  Devin Rousso  <drousso@apple.com>
>+
>+        Web Inspector: Timelines: DOMContentLoaded and load event lines need to be more obvious
>+        https://bugs.webkit.org/show_bug.cgi?id=193186
>+        <rdar://problem/45100694>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Shift around z-index values to make Timelines markers appear behind record bars.
>+
>+        * UserInterface/Views/TimelineRuler.css:
>+        (.timeline-ruler):
>+        (.timeline-ruler > .markers):
>+        (.timeline-ruler > .markers > .marker):
>+        (.timeline-ruler > .markers > .marker.load-event):
>+        (.timeline-ruler > .markers > .marker.dom-content-event):
>+        (.timeline-ruler > .markers > .marker.timestamp):
>+
>+        * UserInterface/Views/TimelineRecordBar.css:
>+        (.timeline-record-bar):
>+        (.timeline-record-bar > .segment):
>+
> 2019-01-04  Joseph Pecoraro  <pecoraro@apple.com>
> 
>         Web Inspector: subclasses of WI.ClusterContentView don't save/restore content views after the initial view
>diff --git a/Source/WebInspectorUI/UserInterface/Views/TimelineRecordBar.css b/Source/WebInspectorUI/UserInterface/Views/TimelineRecordBar.css
>index 7df5e227d2cc02f15085e68bb11ed5f2f49e9280..6443751f8f1776b2d2e1fc9b521da110c3e2e00d 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/TimelineRecordBar.css
>+++ b/Source/WebInspectorUI/UserInterface/Views/TimelineRecordBar.css
>@@ -26,7 +26,7 @@
> .timeline-record-bar {
>     position: absolute;
>     height: 12px;
>-    z-index: 1;
>+    z-index: 10;
> 
>     --timeline-record-bar-has-inactive-segment-not-inactive-segment-border-start: 1px solid hsla(215, 67%, 53%, 0.7) !important;
> }
>@@ -38,7 +38,7 @@
>     border: 1px solid hsl(0, 0%, 78%);
>     border-radius: 3px;
>     min-width: 4px;
>-    z-index: 1;
>+    z-index: 10;
> }
> 
> .timeline-record-bar.selected > .segment {
>diff --git a/Source/WebInspectorUI/UserInterface/Views/TimelineRuler.css b/Source/WebInspectorUI/UserInterface/Views/TimelineRuler.css
>index da1277d89aa9b88869bb4f7a6c7b09cc38fb8258..13ca6870fb5d2260d1b6bcbace5139f32052cd89 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/TimelineRuler.css
>+++ b/Source/WebInspectorUI/UserInterface/Views/TimelineRuler.css
>@@ -26,7 +26,6 @@
> .timeline-ruler {
>     position: relative;
>     pointer-events: none;
>-    z-index: 1;
> 
>     --timeline-ruler-marker-translateX: -1px;
> }
>@@ -103,7 +102,7 @@ body[dir=rtl] .timeline-ruler > .header > .divider > .label {
>     left: 0;
>     right: 0;
>     bottom: 0;
>-    z-index: 10;
>+    z-index: 5;
> }
> 
> .timeline-ruler > .markers > .divider {
>@@ -118,9 +117,9 @@ body[dir=rtl] .timeline-ruler > .header > .divider > .label {
>     position: absolute;
>     top: 0;
>     bottom: 0;
>-    pointer-events: all;
>-
>+    width: 3px;
>     border: 0 solid hsla(0, 0%, 50%, 0.5);
>+    pointer-events: all;
> }
> 
> body[dir=ltr] .timeline-ruler > .markers > .marker {
>@@ -131,12 +130,6 @@ body[dir=rtl] .timeline-ruler > .markers > .marker {
>     border-right-width: 1px;
> }
> 
>-/* Larger tooltip area */
>-.timeline-ruler > .markers > .marker {
>-    z-index: 20;
>-    width: 3px;
>-}
>-
> .timeline-ruler > .markers > .marker::before {
>     width: 3px;
>     content: "";
>@@ -172,15 +165,15 @@ body[dir=rtl] .timeline-ruler > .markers > .marker::before {
> }
> 
> .timeline-ruler > .markers > .marker.load-event {
>-    border-color: hsla(0, 100%, 50%, 0.25);
>+    border-color: hsl(0, 100%, 50%);
> }
> 
> .timeline-ruler > .markers > .marker.dom-content-event {
>-    border-color: hsla(240, 100%, 50%, 0.25);
>+    border-color: hsl(240, 100%, 50%);
> }
> 
> .timeline-ruler > .markers > .marker.timestamp {
>-    border-color: hsla(119, 100%, 21%, 0.25);
>+    border-color: hsl(119, 100%, 21%);
> }
> 
> .timeline-ruler > .selection-drag {

Actions: View | Formatted Diff | Diff

Attachments on bug 193186: 358475 | 358476 | 358513 | 358521 | 358522 | 360157