Attachment 358464 Details for Bug 193175 – Patch

[patch] Patch

bug-193175-20190106111900.patch (text/plain), 10.70 KB, created by youenn fablet on 2019-01-06 11:19:01 PST

(hide)

Description:

Filename:

MIME Type:

Creator: youenn fablet

Created: 2019-01-06 11:19:01 PST

Size: 10.70 KB

patch

obsolete

>Subversion Revision: 239660
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 97104d3ce906a86ca50eee55ee6a2dfd9a226035..9b7ed239fcf94cf842c2b3973baa8504b147651c 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,17 @@
>+2019-01-06  Youenn Fablet  <youenn@apple.com>
>+
>+        API test broken: TestWebKitAPI.WebKit.CustomDataStorePathsVersusCompletionHandlers
>+        https://bugs.webkit.org/show_bug.cgi?id=193175
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Updated API test as we bumped the SW schema to version 4.
>+
>+        * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
>+        * TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-4.sqlite3: Renamed from Tools/TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-3.sqlite3.
>+        * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
>+        (TEST):
>+
> 2019-01-05  Oriol Brufau  <obrufau@igalia.com>
> 
>         [GTK] Add python3-setuptools, libunistring-dev, bison and flex dependencies
>diff --git a/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj b/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
>index 65349c516642572f222ed726a9a4a003103a8015..b35bf5998743f2e5ea4025b5957c6e4203e75dd6 100644
>--- a/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
>+++ b/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
>@@ -179,7 +179,7 @@
> 		467C565321B5ED130057516D /* GetSessionCookie.html in Copy Resources */ = {isa = PBXBuildFile; fileRef = 467C565121B5ECDF0057516D /* GetSessionCookie.html */; };
> 		467C565421B5ED130057516D /* SetSessionCookie.html in Copy Resources */ = {isa = PBXBuildFile; fileRef = 467C565221B5ECDF0057516D /* SetSessionCookie.html */; };
> 		46A911592108E6780078D40D /* CustomUserAgent.mm in Sources */ = {isa = PBXBuildFile; fileRef = 46A911582108E66B0078D40D /* CustomUserAgent.mm */; };
>-		46AE5A3720F9066D00E0873E /* SimpleServiceWorkerRegistrations-3.sqlite3 in Copy Resources */ = {isa = PBXBuildFile; fileRef = 4656A75720F9054F0002E21F /* SimpleServiceWorkerRegistrations-3.sqlite3 */; };
>+		46AE5A3720F9066D00E0873E /* SimpleServiceWorkerRegistrations-4.sqlite3 in Copy Resources */ = {isa = PBXBuildFile; fileRef = 4656A75720F9054F0002E21F /* SimpleServiceWorkerRegistrations-4.sqlite3 */; };
> 		46C519DA1D355AB200DAA51A /* LocalStorageNullEntries.mm in Sources */ = {isa = PBXBuildFile; fileRef = 46C519D81D355A7300DAA51A /* LocalStorageNullEntries.mm */; };
> 		46C519E61D3563FD00DAA51A /* LocalStorageNullEntries.html in Copy Resources */ = {isa = PBXBuildFile; fileRef = 46C519E21D35629600DAA51A /* LocalStorageNullEntries.html */; };
> 		46C519E71D3563FD00DAA51A /* LocalStorageNullEntries.localstorage in Copy Resources */ = {isa = PBXBuildFile; fileRef = 46C519E31D35629600DAA51A /* LocalStorageNullEntries.localstorage */; };
>@@ -1232,7 +1232,7 @@
> 				BC909784125571CF00083756 /* simple.html in Copy Resources */,
> 				51E5C7021919C3B200D8B3E1 /* simple2.html in Copy Resources */,
> 				51E5C7031919C3B200D8B3E1 /* simple3.html in Copy Resources */,
>-				46AE5A3720F9066D00E0873E /* SimpleServiceWorkerRegistrations-3.sqlite3 in Copy Resources */,
>+				46AE5A3720F9066D00E0873E /* SimpleServiceWorkerRegistrations-4.sqlite3 in Copy Resources */,
> 				F4F405BD1D4C0D1C007A9707 /* skinny-autoplaying-video-with-audio.html in Copy Resources */,
> 				C01A23F21266156700C9ED55 /* spacebar-scrolling.html in Copy Resources */,
> 				E194E1BD177E53C7009C4D4E /* StopLoadingFromDidReceiveResponse.html in Copy Resources */,
>@@ -1511,7 +1511,7 @@
> 		4612C2B8210A6ABF00B788A6 /* LoadFileThenReload.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = LoadFileThenReload.mm; sourceTree = "<group>"; };
> 		46397B941DC2C850009A78AE /* DOMNode.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = DOMNode.mm; sourceTree = "<group>"; };
> 		4647B1251EBA3B730041D7EF /* ProcessDidTerminate.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = ProcessDidTerminate.cpp; sourceTree = "<group>"; };
>-		4656A75720F9054F0002E21F /* SimpleServiceWorkerRegistrations-3.sqlite3 */ = {isa = PBXFileReference; lastKnownFileType = file; path = "SimpleServiceWorkerRegistrations-3.sqlite3"; sourceTree = "<group>"; };
>+		4656A75720F9054F0002E21F /* SimpleServiceWorkerRegistrations-4.sqlite3 */ = {isa = PBXFileReference; lastKnownFileType = file; path = "SimpleServiceWorkerRegistrations-4.sqlite3"; sourceTree = "<group>"; };
> 		466C3842210637CE006A88DE /* notify-resourceLoadObserver.html */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.html; path = "notify-resourceLoadObserver.html"; sourceTree = "<group>"; };
> 		467C565121B5ECDF0057516D /* GetSessionCookie.html */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.html; path = GetSessionCookie.html; sourceTree = "<group>"; };
> 		467C565221B5ECDF0057516D /* SetSessionCookie.html */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.html; path = SetSessionCookie.html; sourceTree = "<group>"; };
>@@ -2920,7 +2920,7 @@
> 				F4E3D80720F708E4007B58C5 /* significant-text-milestone-article.html */,
> 				F4FC077620F0108100CA043C /* significant-text-milestone.html */,
> 				C9B4AD291ECA6EA500F5FEA0 /* silence-long.m4a */,
>-				4656A75720F9054F0002E21F /* SimpleServiceWorkerRegistrations-3.sqlite3 */,
>+				4656A75720F9054F0002E21F /* SimpleServiceWorkerRegistrations-4.sqlite3 */,
> 				F4F405BB1D4C0CF8007A9707 /* skinny-autoplaying-video-with-audio.html */,
> 				515BE16E1D4288FF00DD7C68 /* StoreBlobToBeDeleted.html */,
> 				9BD6D3A11F7B202100BD4962 /* sunset-in-cupertino-100px.tiff */,
>diff --git a/Tools/TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-3.sqlite3 b/Tools/TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-3.sqlite3
>deleted file mode 100644
>index cb51b60e04cacc7099db23aee0feb69dd98e57dc..0000000000000000000000000000000000000000
>GIT binary patch
>literal 0
>HcmV?d00001
>
>literal 12288
>zcmeI1&1)M+6u?(XX&Qq`p@$q?=qm&yfxK!GXduB5SyiY(wGvxO3Z;nA?2|O{XlFAs
>zYjr7x9(pMB>T~~|_S!>_{X2T>+b`KpZLjI6&>1w^`FL;Mo8P=yc6JY64unORDZOMC
>z9(f;n^}6>A!1KI1<y(}?RHMRsWreP3y(-l`|Nak~cmMM0o2TC9>D}L|6kNX};0QPZ
>zj({WJ2si?cfFs}tI0FAC0zW>i-M+WARr~3wWmAa<$dwLEajEwX`rT0<M%~>(ABsk3
>z9$^Bb{?{YeA5tC<1~A-*-f;i<V6QiV=iR*ljQ96mj{6td5Be_#-Cn;9N{hJ&D@JI8
>z;VQ!M!Jtyms%Ut#Atf_*90kl`Z-M-1B$fzY49Dr@uAE96;!NX}U_HhcSm}=8T156H
>zj^~n<1Fn=lLOn{NYTI0e7DIc8Jl4V{FO(EKf!)Dy_qqw@ejK1tvF7*{iz+l)+x7SF
>zb+>As2m}1iyp?pSpRm}ftUf8?Wb&XWr04n%(ml0Fxwi4dqn}HTfFs}tI0BA<Bj5-)
>z0*=5n1b*(-HqGNt9^c+NJpE|v{>KYzBQseBp+6UP5l?-gCX=l3NvCt6xnow_7LD!P
>zp!b~tKkNSS`$P51>p%CFk<!*&KZ05LZ;U}X^H~t|kLf9VAPhZ>qi!}tXe^Vm(S}(Z
>zaw}BW#8jdM-){h9MSsPF9fwxPCN%-@^sHfgIs%2w#_@wj%eM<EuJyD2Tt5}pXk#7b
>zTB!qFDVyJ91Esx<HHAj|lE&<@-Cx)xd3Z^;v57>V8*^zdiz1r%rCnml=C~~h!&MT5
>zMQ^W|HrrComH#H1Upmm7;Gs@BQx%6c`I7!nn@Z_rLZ2J0#8)gpT`6rswHj$fz>A>^
>z65qC-W~GxBU8sCQdE<(8o}uN7YgbvLiBuT8rl@TeOHAKF`67=8U*p@Dg7w|S&b17d
>z>)q*;@sTUHfXNk0426MF@)%9#F-c8h3v|@x%pj;4n3!`knHYINZ7U%qEZ8x^F_ST7
>zYGMY>(ja`gvjZ`m@@68$pftY@w^FPi1So0DG^Ep1gk;9#+UcE{J2L=4-j~C}k|i)j
>zhz$myLYdGX&z(&Tk>m;?MC!B(OgbAbRfuUVA^>TT-X$bC3EEbLgPA4^12Cvb$Iz<}
>zs*v=$U!q+*(aVP1S=ar{Mze^H)Q`1V#omQ{<<C#H*zZ2Mdl6N8Z7;Kb&RQCWsns+U
>zs7qdD$4SfQS#Xti4QQS>dj6ha{5+D*?iA&o`{yoN8!lZqAxBPH)SNc-=p~C0yu6wJ
>zS{CTKLAges<=vP0b5LB-5pV<?0Y|_Qa0DCyN5Bzq1RMcJz!CVb68QX<x$`ex!Tt@^
>CnWL@%
>
>diff --git a/Tools/TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-4.sqlite3 b/Tools/TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-4.sqlite3
>new file mode 100644
>index 0000000000000000000000000000000000000000..089b811bfb2bbd0e5271f04f2381da13d348839f
>GIT binary patch
>literal 12288
>zcmeI1|7#;f6u>t*@w8Y^@P|Vx_=JNbkZwE#50!#xE{BEK^m@rD$Qh=yFUeddJ9{&;
>zjf)ig!C%B*?~l^Iz@G*G2!Hg=W;bomwp;v3VTMe0zPx$w&1c>$JG)OF4}?XSD!pJ9
>zJ`Uaq>h<6YfFKC!ly6ZkQ;iC*l@+?WdR3|i;k_R>@B9_iH!;}6JHJ&8@co{EC*TQq
>z0-k^;;0bsFo`5Id3H+}K{KRUv?{00?etyrgBZ-H|m5xktsrL^1-BBM#-Q7VSibiN2
>zV+N!CHzU{|QXUTmFx-dUaR1R@uQ!56-Ms;f_xB!;`xn{|`v-$=uiplx#Z1H%8ropE
>zN^pEQs1&p+8Qx5#WX6t@h*|8-kspu50^#9s>?U{RRN9c{Bc2M@V|<R4?ij8`VsGO3
>zO0rVnQt4yVqb#Ym%~fnMwoj0!TG;GBNx?JN9SnD`o1n%iYK^)OzkX@m!ng?@qEV^l
>z_!Ubk479fEuix!%)dCSm_`P`{=~O>qsa1J>QiRpyeo=7e`ZwI3+N50D_%xuOPo97$
>z;0bsFo`5Id33vjYz|{nPd02bfJow<j?X4#--`%>m`TpG6#7q`Z9L|KDr$?bslS$tA
>zS*LTMxnq{w7LD!Pp!XGpA9a6!>*c|p-~F+-NR+nbdJSe7J~syCG-OfKKcR>AfiU#!
>zj=I?pv9V0bMjNJS%&kyy6P-j0e%JuWi{X+9JC3c8O=<$*?r35{Ix)q~#>xFgE3|Ve
>zuE*#7tMN`;qfK?Z8s!}5O4<B2SLAvdYYL6_C5`!GdpNfX^6-*wV>5{%H|Ek_mLxRs
>zOS{B^&2U>1hN~n9i{4%`ZMLPFsqlF+yHwGP;GxbsM=FhN_9gwHHkHzgj6OG7iBDOC
>zx>DN2YB|!1fETI@63<$n=cUsYU8sCYdE<(8o}%URYgbvLNmLwtO;Ot{mYBYU^7$$r
>zLX9s{3f5N_do{{nx!#>l86T^`EnsrVGDBftlsrL`drVSCsRcTjb7m0K6imuFnp}*$
>zpthxu66Wj#;e^Q)^I>8N&C(!zxU&N(o${t4#;7#E4!2UQAOt8$rweJ9ijd5iTsyrp
>zb7uws$oo<~ELa9d2&uscR4g<4<11&KA(C7o#7Lc1fpN3pQpM<M2?20Ldi9X4NYJ(_
>z9Lz_uI0A#3#u$22LKTu;_e->ECwjTcopn9TZ8VGMaDJ?ZRqS0@t^E1P7W+LUcQ2x9
>zukGdb&slSE=&ZU_pe}ip9jC33=fPFpHK2Lk==pnw30IMHcBd%!+&_2G+HmQ@DLHc5
>zqGs37qjxe!@bYH<YgwS{2IU%kmiJ%g&q47;PrwuK1Uvyxz!UHUJONL@6YvB)0Z-t+
>OO5l@Q=FNZc3ifXRKCzAf
>
>literal 0
>HcmV?d00001
>
>diff --git a/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm b/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm
>index a4f24683bcf7e2bf6158fe1d4aa3aa9e688d4da8..764edf47a3094b0775f3d93babc96dd41c68a012 100644
>--- a/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm
>+++ b/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm
>@@ -280,14 +280,14 @@ TEST(WebKit, WebsiteDataStoreCustomPathsWithPrewarming)
> TEST(WebKit, CustomDataStorePathsVersusCompletionHandlers)
> {
>     // Copy the baked database files to the database directory
>-    NSURL *url1 = [[NSBundle mainBundle] URLForResource:@"SimpleServiceWorkerRegistrations-3" withExtension:@"sqlite3" subdirectory:@"TestWebKitAPI.resources"];
>+    NSURL *url1 = [[NSBundle mainBundle] URLForResource:@"SimpleServiceWorkerRegistrations-4" withExtension:@"sqlite3" subdirectory:@"TestWebKitAPI.resources"];
> 
>     NSURL *swPath = [NSURL fileURLWithPath:[@"~/Library/Caches/TestWebKitAPI/WebKit/ServiceWorkers/" stringByExpandingTildeInPath]];
>     [[NSFileManager defaultManager] removeItemAtURL:swPath error:nil];
>     EXPECT_FALSE([[NSFileManager defaultManager] fileExistsAtPath:swPath.path]);
> 
>     [[NSFileManager defaultManager] createDirectoryAtURL:swPath withIntermediateDirectories:YES attributes:nil error:nil];
>-    [[NSFileManager defaultManager] copyItemAtURL:url1 toURL:[swPath URLByAppendingPathComponent:@"ServiceWorkerRegistrations-3.sqlite3"] error:nil];
>+    [[NSFileManager defaultManager] copyItemAtURL:url1 toURL:[swPath URLByAppendingPathComponent:@"ServiceWorkerRegistrations-4.sqlite3"] error:nil];
> 
>     auto websiteDataStoreConfiguration = adoptNS([[_WKWebsiteDataStoreConfiguration alloc] init]);
>     websiteDataStoreConfiguration.get()._serviceWorkerRegistrationDirectory = swPath;

Actions: View | Formatted Diff | Diff

Attachments on bug 193175: 358464