WebKit Bugzilla
Attachment 358457 Details for
Bug 193174
: [WPE][GTK] Building with ENABLE_VIDEO=OFF fails trying to use Document MediaPlayback functions.
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
patch
bug-193174-20190106105417.patch (text/plain), 2.01 KB, created by
Pablo Saavedra
on 2019-01-06 01:54:18 PST
(
hide
)
Description:
patch
Filename:
MIME Type:
Creator:
Pablo Saavedra
Created:
2019-01-06 01:54:18 PST
Size:
2.01 KB
patch
obsolete
>Subversion Revision: 239662 >diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog >index 9066243e3ea5e764c1434fb33593023b50a8ecae..ecff460d2ce5e99db548fb610e1e0ce3dd8cf22e 100644 >--- a/Source/WebCore/ChangeLog >+++ b/Source/WebCore/ChangeLog >@@ -1,3 +1,15 @@ >+2019-01-06 Pablo Saavedra <psaavedra@igalia.com> >+ >+ [WPE][GTK] Building with ENABLE_VIDEO=OFF fails trying to use Document MediaPlayback functions. >+ https://bugs.webkit.org/show_bug.cgi?id=193174 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * page/Page.cpp: >+ (WebCore::Page::stopAllMediaPlayback): >+ (WebCore::Page::suspendAllMediaPlayback): >+ (WebCore::Page::resumeAllMediaPlayback): >+ > 2019-01-05 David Kilzer <ddkilzer@apple.com> > > Leak of two CCRSACryptorRef (4.0 Kbytes/1 page each) in com.apple.WebKit.WebContent running WebKit layout tests >diff --git a/Source/WebCore/page/Page.cpp b/Source/WebCore/page/Page.cpp >index ddf391279534b90c15778bad2bce849e75851392..e81cb238e17fe15e1409843150ae639ee96d5b5d 100644 >--- a/Source/WebCore/page/Page.cpp >+++ b/Source/WebCore/page/Page.cpp >@@ -1718,14 +1718,17 @@ void Page::stopMediaCapture() > > void Page::stopAllMediaPlayback() > { >+#if ENABLE(VIDEO) > for (Frame* frame = &mainFrame(); frame; frame = frame->tree().traverseNext()) { > if (auto* document = frame->document()) > document->stopAllMediaPlayback(); > } >+#endif > } > > void Page::suspendAllMediaPlayback() > { >+#if ENABLE(VIDEO) > ASSERT(!m_mediaPlaybackIsSuspended); > if (m_mediaPlaybackIsSuspended) > return; >@@ -1736,10 +1739,12 @@ void Page::suspendAllMediaPlayback() > } > > m_mediaPlaybackIsSuspended = true; >+#endif > } > > void Page::resumeAllMediaPlayback() > { >+#if ENABLE(VIDEO) > ASSERT(m_mediaPlaybackIsSuspended); > if (!m_mediaPlaybackIsSuspended) > return; >@@ -1749,6 +1754,7 @@ void Page::resumeAllMediaPlayback() > if (auto* document = frame->document()) > document->resumeAllMediaPlayback(); > } >+#endif > } > > #if ENABLE(MEDIA_SESSION)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 193174
: 358457