Attachment 358456 Details for Bug 191303 – Patch

[patch] Patch

bug-191303-20190106075916.patch (text/plain), 1.86 KB, created by darshan on 2019-01-05 22:59:17 PST

(hide)

Description:

Filename:

MIME Type:

Creator: darshan

Created: 2019-01-05 22:59:17 PST

Size: 1.86 KB

patch

obsolete

>Subversion Revision: 239610
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 48d642a731de0cb5defc0e961da2451d0442a9e7..d03c10ad616b78d2c329dbb34b95ccfb32b97d87 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,13 @@
>+2019-01-05  Darshan Kadu  <dkadu@igalia.com>
>+
>+        DumpRenderTree should report unknown options
>+        https://bugs.webkit.org/show_bug.cgi?id=191303
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * DumpRenderTree/TestOptions.cpp:
>+        (TestOptions::TestOptions):
>+
> 2019-01-03  Ross Kirsling  <ross.kirsling@sony.com>
> 
>         test262-runner misbehaves when test file YAML has a trailing space
>diff --git a/Tools/DumpRenderTree/TestOptions.cpp b/Tools/DumpRenderTree/TestOptions.cpp
>index 82d87e13ac80ee46b570964983579368e1ad2978..24e0af04b1a4ffceeb7ca09ad80bdc9b6b73c1eb 100644
>--- a/Tools/DumpRenderTree/TestOptions.cpp
>+++ b/Tools/DumpRenderTree/TestOptions.cpp
>@@ -75,7 +75,7 @@ TestOptions::TestOptions(const std::string& pathOrURL, const std::string& absolu
>         auto value = pairString.substr(equalsLocation + 1, pairEnd - (equalsLocation + 1));
>         if (key == "enableAttachmentElement")
>             enableAttachmentElement = parseBooleanTestHeaderValue(value);
>-        if (key == "useAcceleratedDrawing")
>+        else if (key == "useAcceleratedDrawing")
>             useAcceleratedDrawing = parseBooleanTestHeaderValue(value);
>         else if (key == "enableIntersectionObserver")
>             enableIntersectionObserver = parseBooleanTestHeaderValue(value);
>@@ -107,6 +107,8 @@ TestOptions::TestOptions(const std::string& pathOrURL, const std::string& absolu
>             jscOptions = value;
>         else if (key == "experimental:WebGPUEnabled")
>             enableWebGPU = parseBooleanTestHeaderValue(value);
>+        else
>+            fprintf(stderr, "Unknown option %s\n", key.c_str());
>         pairStart = pairEnd + 1;
>     }
> }

Actions: View | Formatted Diff | Diff

Attachments on bug 191303: 358263 | 358456 | 360474 | 360733 | 360737 | 360738 | 360743 | 360746 | 360760 | 360762 | 360768 | 360769 | 360779 | 360865 | 360913 | 361201 | 361302 | 361683 | 361687 | 362238