Attachment 358432 Details for Bug 193169 – ROLLOUT of r239607

[patch] ROLLOUT of r239607

bug-193169-20190105032736.patch (text/plain), 3.03 KB, created by WebKit Commit Bot on 2019-01-05 03:27:36 PST

(hide)

Description:

Filename:

MIME Type:

Creator: WebKit Commit Bot

Created: 2019-01-05 03:27:36 PST

Size: 3.03 KB

patch

obsolete

>Subversion Revision: 239655
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 14d08a0c460c629e4eed610c30cc5bc94d1666e1..1ce9b3abfe75aca76d0c1be9a9caec47c2092082 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,18 @@
>+2019-01-05  Commit Queue  <commit-queue@webkit.org>
>+
>+        Unreviewed, rolling out r239607.
>+        https://bugs.webkit.org/show_bug.cgi?id=193169
>+
>+        This change makes the test even more flaky (Requested by fredw
>+        on #webkit).
>+
>+        Reverted changeset:
>+
>+        "Flaky Test: http/wpt/css/css-animations/start-
>+        animation-001.html"
>+        https://bugs.webkit.org/show_bug.cgi?id=190903
>+        https://trac.webkit.org/changeset/239607
>+
> 2019-01-04  Daniel Bates  <dabates@apple.com>
> 
>         REGRESSION (r238522): Erratic scrolling on Google flights search result page and vrbo.com
>diff --git a/LayoutTests/http/wpt/css/css-animations/start-animation-001.html b/LayoutTests/http/wpt/css/css-animations/start-animation-001.html
>index fd058b9a4907c3a36b6ba8599bbe743ce535ae51..116b4eb51dee16b62ae14d54bfd834de3b09baf4 100644
>--- a/LayoutTests/http/wpt/css/css-animations/start-animation-001.html
>+++ b/LayoutTests/http/wpt/css/css-animations/start-animation-001.html
>@@ -53,33 +53,18 @@
>       }
>     </style>
>     <script>
>-      function squareLeft(id) {
>-          var element = document.getElementById(id);
>-          if (id === "squareNonAccelerated")
>-              return element.getBoundingClientRect().left;
>-          var transform = window.getComputedStyle(element).getPropertyValue("transform");
>-          var match = /matrix\(1, 0, 0, 1, (.*), 0\)/.exec(transform);
>-          return match ? parseFloat(match[1]) : 0;
>+      function runTest() {
>+        if (!window.testRunner)
>+          return;
>+        // We wait a bit after the squares are moved behind the blue rectangle. For discontinuous
>+        // transforms we have 5000px / 100 steps = 5px/step. Hence this happens after 20 steps i.e.
>+        // 20/100*10s = 200ms.
>+        testRunner.waitUntilDone();
>+        setTimeout(() => { testRunner.notifyDone(); }, 300);
>       }
>-      function shouldBeHiddenByCoveringRect(id) {
>-          var coveringRectLeft = document.getElementById("coveringRect").getBoundingClientRect().left;
>-          return squareLeft(id) > coveringRectLeft;
>-      }
>-      // We wait until all the squares are moved behind the blue rectangle.
>-      if (window.testRunner)
>-          testRunner.waitUntilDone();
>-      function step() {
>-          if (["squareLinear", "squareSteps", "squareNonAccelerated"].every(shouldBeHiddenByCoveringRect)) {
>-              if (window.testRunner)
>-                  testRunner.notifyDone();
>-              return;
>-          }
>-          window.requestAnimationFrame(step);
>-      }
>-      window.requestAnimationFrame(step);
>     </script>
>   </head>
>-  <body>
>+  <body onload="runTest()">
>     <p>This test passes if green squares are moved behind the blue rectangle.</p>
>     <div id="container">
>       <div id="squareLinear"><tt>transform</tt> (linear)</div>

Actions: View | Formatted Diff | Diff

Attachments on bug 193169: 358432