WebKit Bugzilla
Attachment 358372 Details for
Bug 192451
: Web Inspector: subclasses of WI.ClusterContentView don't save/restore content views after the initial view
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
[PATCH] Proposed Fix
cluster-save-state-1.patch (text/plain), 2.89 KB, created by
Joseph Pecoraro
on 2019-01-04 14:28:50 PST
(
hide
)
Description:
[PATCH] Proposed Fix
Filename:
MIME Type:
Creator:
Joseph Pecoraro
Created:
2019-01-04 14:28:50 PST
Size:
2.89 KB
patch
obsolete
>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog >index 9d242d169b4..8a4d81eeaa9 100644 >--- a/Source/WebInspectorUI/ChangeLog >+++ b/Source/WebInspectorUI/ChangeLog >@@ -1,3 +1,21 @@ >+2019-01-04 Joseph Pecoraro <pecoraro@apple.com> >+ >+ Web Inspector: subclasses of WI.ClusterContentView don't save/restore content views after the initial view >+ https://bugs.webkit.org/show_bug.cgi?id=192451 >+ <rdar://problem/46800958> >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * UserInterface/Models/BackForwardEntry.js: >+ (WI.BackForwardEntry.prototype.prepareToHide): >+ * UserInterface/Views/ClusterContentView.js: >+ (WI.ClusterContentView.prototype.get shouldSaveStateOnHide): >+ * UserInterface/Views/ContentView.js: >+ (WI.ContentView.prototype.get shouldSaveStateOnHide): >+ Allow ClusterContentViews to save its state whenever its hidden, >+ this means it can be properly restored to the last state it had >+ instead of the initial state it was shown with. >+ > 2019-01-04 Joseph Pecoraro <pecoraro@apple.com> > > Web Inspector: Add a Setting Toggle for Source Maps >diff --git a/Source/WebInspectorUI/UserInterface/Models/BackForwardEntry.js b/Source/WebInspectorUI/UserInterface/Models/BackForwardEntry.js >index 34ac1e6b80e..d158b62df3f 100644 >--- a/Source/WebInspectorUI/UserInterface/Models/BackForwardEntry.js >+++ b/Source/WebInspectorUI/UserInterface/Models/BackForwardEntry.js >@@ -93,6 +93,11 @@ WI.BackForwardEntry = class BackForwardEntry > this.contentView.hidden(); > > this._saveScrollPositions(); >+ >+ if (this._contentView.shouldSaveStateOnHide) { >+ this._cookie = {}; >+ this._contentView.saveToCookie(this._cookie); >+ } > } > > isEqual(other) >diff --git a/Source/WebInspectorUI/UserInterface/Views/ClusterContentView.js b/Source/WebInspectorUI/UserInterface/Views/ClusterContentView.js >index 6af3a420d4e..f8473c695b8 100644 >--- a/Source/WebInspectorUI/UserInterface/Views/ClusterContentView.js >+++ b/Source/WebInspectorUI/UserInterface/Views/ClusterContentView.js >@@ -61,6 +61,11 @@ WI.ClusterContentView = class ClusterContentView extends WI.ContentView > return super.supportsSplitContentBrowser; > } > >+ get shouldSaveStateOnHide() >+ { >+ return true; >+ } >+ > shown() > { > super.shown(); >diff --git a/Source/WebInspectorUI/UserInterface/Views/ContentView.js b/Source/WebInspectorUI/UserInterface/Views/ContentView.js >index e7b30c95534..ed220dec952 100644 >--- a/Source/WebInspectorUI/UserInterface/Views/ContentView.js >+++ b/Source/WebInspectorUI/UserInterface/Views/ContentView.js >@@ -355,6 +355,11 @@ WI.ContentView = class ContentView extends WI.View > return false; > } > >+ get shouldSaveStateOnHide() >+ { >+ return false; >+ } >+ > get selectionPathComponents() > { > // Implemented by subclasses.
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Flags:
hi
:
review+
ews-watchlist
:
commit-queue-
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 192451
: 358372 |
358390
|
358404