Attachment 358352 Details for Bug 192209 – Patch

[patch] Patch

192209.diff (text/plain), 5.11 KB, created by Devin Rousso on 2019-01-04 12:51:40 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Devin Rousso

Created: 2019-01-04 12:51:40 PST

Size: 5.11 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index 1ea968ffeb4..3c24d842dcd 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,23 @@
>+2019-01-04  Devin Rousso  <drousso@apple.com>
>+
>+        Web Inspector: Audit: run arrow shouldn't be visible when running tests
>+        https://bugs.webkit.org/show_bug.cgi?id=192209
>+        <rdar://problem/46423615>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UserInterface/Views/AuditTreeElement.js:
>+        (WI.AuditTreeElement.prototype.onattach):
>+        (WI.AuditTreeElement.prototype.ondetach):
>+        (WI.AuditTreeElement.prototype._updateLevel):
>+        (WI.AuditTreeElement.prototype._handleAuditManagerTestScheduled): Added.
>+        (WI.AuditTreeElement.prototype._handleAuditManagerTestCompleted): Added.
>+        * UserInterface/Views/AuditTreeElement.css: Added.
>+        (.tree-outline .item.audit:matches(.test-case, .test-group):not(.manager-active) > .status:hover > img): Added.
>+        (.tree-outline .item.audit.manager-active > .status > img.show-on-hover, .tree-outline .item.audit.test-group.expanded > .status:hover > :not(img), .tree-outline .item.audit.test-group-result.expanded > .status): Added.
>+        (.tree-outline .item.audit:matches(.test-case, .test-group) > .status:hover > img): Deleted.
>+        (.tree-outline .item.audit.test-group.expanded > .status:hover > :not(img), .tree-outline .item.audit.test-group-result.expanded > .status): Deleted.
>+
> 2019-01-02  Nikita Vasilyev  <nvasilyev@apple.com>
> 
>         Web Inspector: Styles: selection lost when inspector is blurred
>diff --git a/Source/WebInspectorUI/UserInterface/Views/AuditTreeElement.css b/Source/WebInspectorUI/UserInterface/Views/AuditTreeElement.css
>index e1f8be3e707..ddd2d95aea8 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/AuditTreeElement.css
>+++ b/Source/WebInspectorUI/UserInterface/Views/AuditTreeElement.css
>@@ -35,7 +35,7 @@
>     height: 100%;
> }
> 
>-.tree-outline .item.audit:matches(.test-case, .test-group) > .status:hover > img {
>+.tree-outline .item.audit:matches(.test-case, .test-group):not(.manager-active) > .status:hover > img {
>     width: 75%;
>     height: 75%;
>     margin: 0 auto;
>@@ -47,6 +47,7 @@
>     opacity: 0;
> }
> 
>+.tree-outline .item.audit.manager-active > .status > img.show-on-hover,
> .tree-outline .item.audit.test-group.expanded > .status:hover > :not(img),
> .tree-outline .item.audit.test-group-result.expanded > .status {
>     display: none;
>diff --git a/Source/WebInspectorUI/UserInterface/Views/AuditTreeElement.js b/Source/WebInspectorUI/UserInterface/Views/AuditTreeElement.js
>index 2015b6ad6ac..cd28ade014e 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/AuditTreeElement.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/AuditTreeElement.js
>@@ -67,6 +67,9 @@ WI.AuditTreeElement = class AuditTreeElement extends WI.GeneralTreeElement
>                 this.representedObject.addEventListener(WI.AuditTestBase.Event.Scheduled, this._handleTestCaseScheduled, this);
>             else if (this.representedObject instanceof WI.AuditTestGroup)
>                 this.representedObject.addEventListener(WI.AuditTestBase.Event.Scheduled, this._handleTestGroupScheduled, this);
>+
>+            WI.auditManager.addEventListener(WI.AuditManager.Event.TestScheduled, this._handleAuditManagerTestScheduled, this);
>+            WI.auditManager.addEventListener(WI.AuditManager.Event.TestCompleted, this._handleAuditManagerTestCompleted, this);
>         }
> 
>         if (this._expandedSetting && this._expandedSetting.value)
>@@ -77,6 +80,7 @@ WI.AuditTreeElement = class AuditTreeElement extends WI.GeneralTreeElement
> 
>     ondetach()
>     {
>+        WI.auditManager.removeEventListener(null, null, this);
>         this.representedObject.removeEventListener(null, null, this);
> 
>         super.ondetach();
>@@ -170,7 +174,7 @@ WI.AuditTreeElement = class AuditTreeElement extends WI.GeneralTreeElement
> 
>     _updateLevel()
>     {
>-        let className = "show-on-hover";
>+        let className = "";
> 
>         let result = this.representedObject.result;
>         if (result) {
>@@ -187,12 +191,16 @@ WI.AuditTreeElement = class AuditTreeElement extends WI.GeneralTreeElement
>         }
> 
>         this.status = document.createElement("img");
>-        this.status.classList.add(className);
> 
>         if (this.representedObject instanceof WI.AuditTestCase || this.representedObject instanceof WI.AuditTestGroup) {
>             this.status.title = WI.UIString("Start");
>             this.status.addEventListener("click", this._handleStatusClick.bind(this));
>+
>+            if (!className)
>+                className = "show-on-hover";
>         }
>+
>+        this.status.classList.add(className);
>     }
> 
>     _showRunningSpinner()
>@@ -265,6 +273,16 @@ WI.AuditTreeElement = class AuditTreeElement extends WI.GeneralTreeElement
>         this._showRunningProgress();
>     }
> 
>+    _handleAuditManagerTestScheduled(event)
>+    {
>+        this.addClassName("manager-active");
>+    }
>+
>+    _handleAuditManagerTestCompleted(event)
>+    {
>+        this.removeClassName("manager-active");
>+    }
>+
>     _handleStatusClick(event)
>     {
>         this._start();

Actions: View | Formatted Diff | Diff

Attachments on bug 192209: 358352 | 358361 | 358377 | 358382