Attachment 358336 Details for Bug 193147 – [PATCH] Proposed Fix

[patch] [PATCH] Proposed Fix

globalthis-1.patch (text/plain), 1.67 KB, created by Joseph Pecoraro on 2019-01-04 11:00:44 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Joseph Pecoraro

Created: 2019-01-04 11:00:44 PST

Size: 1.67 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index 1ea968ffeb4..4109c8dd233 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,13 @@
>+2019-01-04  Joseph Pecoraro  <pecoraro@apple.com>
>+
>+        Web Inspector: Include `globalThis` in default JavaScript completions
>+        https://bugs.webkit.org/show_bug.cgi?id=193147
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UserInterface/Controllers/CodeMirrorCompletionController.js:
>+        Add `globalThis` which is a new global value.
>+
> 2019-01-02  Nikita Vasilyev  <nvasilyev@apple.com>
> 
>         Web Inspector: Styles: selection lost when inspector is blurred
>diff --git a/Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorCompletionController.js b/Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorCompletionController.js
>index 62dc9a81809..7774f1cba76 100644
>--- a/Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorCompletionController.js
>+++ b/Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorCompletionController.js
>@@ -661,7 +661,7 @@ WI.CodeMirrorCompletionController = class CodeMirrorCompletionController extends
>             "return", "static", "super", "switch", "this", "throw", "true", "try",
>             "typeof", "undefined", "var", "void", "while", "with", "yield"
>         ];
>-        var valueKeywords = ["false", "Infinity", "NaN", "null", "this", "true", "undefined"];
>+        var valueKeywords = ["false", "Infinity", "NaN", "null", "this", "true", "undefined", "globalThis"];
> 
>         var allowedKeywordsInsideBlocks = allKeywords.keySet();
>         var allowedKeywordsWhenDeclaringVariable = valueKeywords.keySet();

Actions: View | Formatted Diff | Diff

Attachments on bug 193147: 358336