Attachment 358331 Details for Bug 193146 – ROLLOUT of r239603

[patch] ROLLOUT of r239603

bug-193146-20190104102659.patch (text/plain), 1.53 KB, created by WebKit Commit Bot on 2019-01-04 10:26:59 PST

(hide)

Description:

Filename:

MIME Type:

Creator: WebKit Commit Bot

Created: 2019-01-04 10:26:59 PST

Size: 1.53 KB

patch

obsolete

>Subversion Revision: 239617
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index be400ab6f3fa578d5424bfa6be2c70e0bca10a9a..dddfdb019947a39a5268e186cf8153c643a3b2c4 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,17 @@
>+2019-01-04  Commit Queue  <commit-queue@webkit.org>
>+
>+        Unreviewed, rolling out r239603.
>+        https://bugs.webkit.org/show_bug.cgi?id=193146
>+
>+        Breaks shipping tests (Requested by bfulgha__ on #webkit).
>+
>+        Reverted changeset:
>+
>+        "[iOS] Update sandbox profile to use iconservices instead of
>+        lsdiconservice"
>+        https://bugs.webkit.org/show_bug.cgi?id=193115
>+        https://trac.webkit.org/changeset/239603
>+
> 2019-01-04  Chris Dumez  <cdumez@apple.com>
> 
>         Crash under WebProcessPool::addSuspendedPage()
>diff --git a/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb b/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb
>index d29efd5792df8463ac5b85a9162e57029ed30212..9220757ce832df2372efb5b0e4e89d40c90bfc9d 100644
>--- a/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb
>+++ b/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb
>@@ -169,7 +169,7 @@
> (allow file-read*
>     (well-known-system-group-container-subpath "/systemgroup.com.apple.lsd.iconscache"))
> (allow mach-lookup
>-    (xpc-service-name "com.apple.iconservices"))
>+    (xpc-service-name "com.apple.lsdiconservice"))
> 
> ;; Common mach services needed by UIKit.
> (allow mach-lookup

Actions: View | Formatted Diff | Diff

Attachments on bug 193146: 358331