Attachment 358323 Details for Bug 193141 – Patch for landing

[patch] Patch for landing

bug-193141-20190104090837.patch (text/plain), 1.44 KB, created by Jonathan Bedard on 2019-01-04 09:08:42 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Bedard

Created: 2019-01-04 09:08:42 PST

Size: 1.44 KB

patch

obsolete

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 239610)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,14 @@
>+2019-01-04  Jonathan Bedard  <jbedard@apple.com>
>+
>+        webkitpy: Increase simulator teardown timeout
>+        https://bugs.webkit.org/show_bug.cgi?id=193141
>+        <rdar://problem/46174217>
>+
>+        Rubber-stamped by Aakash Jain.
>+
>+        * Scripts/webkitpy/xcode/simulated_device.py:
>+        (SimulatedDeviceManager.tear_down): Use SIMULATOR_BOOT_TIMEOUT.
>+
> 2019-01-03  Ross Kirsling  <ross.kirsling@sony.com>
> 
>         test262-runner misbehaves when test file YAML has a trailing space
>Index: Tools/Scripts/webkitpy/xcode/simulated_device.py
>===================================================================
>--- Tools/Scripts/webkitpy/xcode/simulated_device.py	(revision 239609)
>+++ Tools/Scripts/webkitpy/xcode/simulated_device.py	(working copy)
>@@ -442,7 +442,7 @@ class SimulatedDeviceManager(object):
>         SimulatedDeviceManager._wait_until_device_is_usable(device, max(0, deadline - time.time()))
> 
>     @staticmethod
>-    def tear_down(host=SystemHost(), timeout=60):
>+    def tear_down(host=SystemHost(), timeout=SIMULATOR_BOOT_TIMEOUT):
>         if SimulatedDeviceManager._managing_simulator_app:
>             host.executive.run_command(['killall', '-9', 'Simulator'], return_exit_code=True)
>             SimulatedDeviceManager._managing_simulator_app = False

Actions: View | Formatted Diff | Diff

Attachments on bug 193141: 358320 | 358323