Attachment 358314 Details for Bug 193137 – Proposed patch

[patch] Proposed patch

ews-build-checkrelevance-message.patch (text/plain), 1.32 KB, created by Aakash Jain on 2019-01-04 06:08:13 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Aakash Jain

Created: 2019-01-04 06:08:13 PST

Size: 1.32 KB

patch

obsolete

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 239606)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,13 @@
>+2019-01-04  Aakash Jain  <aakash_jain@apple.com>
>+
>+        [ews-build] Check patch relevance step should print patch id
>+        https://bugs.webkit.org/show_bug.cgi?id=193137
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * BuildSlaveSupport/ews-build/steps.py:
>+        (CheckPatchRelevance.start): Update the status to include patch id.
>+
> 2019-01-03  Ross Kirsling  <ross.kirsling@sony.com>
> 
>         test262-runner misbehaves when test file YAML has a trailing space
>Index: Tools/BuildSlaveSupport/ews-build/steps.py
>===================================================================
>--- Tools/BuildSlaveSupport/ews-build/steps.py	(revision 239606)
>+++ Tools/BuildSlaveSupport/ews-build/steps.py	(working copy)
>@@ -189,7 +189,7 @@ class CheckPatchRelevance(buildstep.Buil
>         self._addToLog('stdio', 'This patch does not have relevant changes.')
>         self.finished(FAILURE)
>         self.build.results = SKIPPED
>-        self.build.buildFinished(['Patch doesn\'t have relevant changes'], SKIPPED)
>+        self.build.buildFinished(['Patch {} doesn\'t have relevant changes'.format(self.getProperty('patch_id', ''))], SKIPPED)
>         return None
> 
>

Actions: View | Formatted Diff | Diff

Attachments on bug 193137: 358314