Attachment 358283 Details for Bug 189818 – Patch

[patch] Patch

bug-189818-20190103155640.patch (text/plain), 5.84 KB, created by Aaron Chu on 2019-01-03 15:56:40 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Aaron Chu

Created: 2019-01-03 15:56:40 PST

Size: 5.84 KB

patch

obsolete

>Subversion Revision: 239597
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 56a25d38458e0f556a06bdfd91c48b614e9b3100..386c01ef35212c6620a75559d79c50570c2738b1 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,17 @@
>+2019-01-03  Aaron Chu  <aaron_chu@apple.com>
>+
>+        [macOS EWS] Layout test accessibility/smart-invert-reference.html is a flaky failure
>+        https://bugs.webkit.org/show_bug.cgi?id=189818
>+        <rdar://problem/44667625>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Swapped out the blur effect image behind the video play buttons for a solid color image to enhance rendering consistency.
>+
>+        * accessibility/smart-invert-reference-expected.html:
>+        * accessibility/smart-invert-reference.html:
>+        * platform/mac-wk2/TestExpectations:
>+
> 2019-01-03  Devin Rousso  <drousso@apple.com>
> 
>         Web Inspector: conic-gradient color picker doesn't accurately show color when saturation value is not 100%
>diff --git a/LayoutTests/accessibility/smart-invert-reference-expected.html b/LayoutTests/accessibility/smart-invert-reference-expected.html
>index bcffdb3948c0f0be45f822c2e95e8d331f797e7e..a8a6b7fe32d2c8cb1f47312f5d23af83326b4d84 100644
>--- a/LayoutTests/accessibility/smart-invert-reference-expected.html
>+++ b/LayoutTests/accessibility/smart-invert-reference-expected.html
>@@ -7,6 +7,7 @@
>     .no-invert { filter: none; }
>     .preserve-filter { filter: grayscale(1); }
>     #result { position: absolute; top: -5000px; }
>+    video { width: 150px; height: 150px; }
> </style>
> </head>
> <body>
>@@ -14,17 +15,17 @@
>   <img class="invert" src="../compositing/resources/simple_image.png" alt="">
>   <picture class="invert" ><img class="fallback" src="../compositing/resources/simple_image.png" alt=""></picture>
>   <video class="invert" poster="../compositing/resources/simple_image.png"></video>
>-  <video class="invert" poster="../compositing/resources/simple_image.png" controls></video>
>+  <video class="invert" poster="../compositing/resources/circle.svg" controls></video>
>   <br>
>   <img class="no-invert" src="../compositing/resources/simple_image.png">
>   <picture class="no-invert"><img class="fallback" src="../compositing/resources/simple_image.png" alt=""></picture>
>   <video class="no-invert" poster="../compositing/resources/simple_image.png"></video>
>-  <video class="no-invert" poster="../compositing/resources/simple_image.png" controls></video>
>+  <video class="no-invert" poster="../compositing/resources/circle.svg" controls></video>
>   <br>
>   <img class="preserve-filter" src="../compositing/resources/simple_image.png" alt="">
>   <picture class="preserve-filter"><img class="fallback" src="../compositing/resources/simple_image.png" alt=""></picture>
>   <video class="preserve-filter" poster="../compositing/resources/simple_image.png"></video>
>-  <video class="preserve-filter" poster="../compositing/resources/simple_image.png" controls></video>
>+  <video class="preserve-filter" poster="../compositing/resources/circle.svg" controls></video>
>   
>   <div id="result"></div>
> </body>
>diff --git a/LayoutTests/accessibility/smart-invert-reference.html b/LayoutTests/accessibility/smart-invert-reference.html
>index 68759c15b390159c8a7d0dc38a6fad1891993e3e..0e919ebf8d03cadeaa7da519cfe8c3902745b998 100644
>--- a/LayoutTests/accessibility/smart-invert-reference.html
>+++ b/LayoutTests/accessibility/smart-invert-reference.html
>@@ -5,6 +5,7 @@
>     /* Testing explicit author overrides. */
>     .no-invert { filter: none; }
>     .preserve-filter { filter: grayscale(1); }
>+    video { width: 150px; height: 150px; }
> </style>
> <script>
> if (window.testRunner)
>@@ -41,17 +42,17 @@ window.addEventListener("load", runTest, false);
>   <img id="a" src="../compositing/resources/simple_image.png" alt="">
>   <picture id="b"><img class="fallback" src="../compositing/resources/simple_image.png" alt=""></picture>
>   <video id="c" poster="../compositing/resources/simple_image.png"></video>
>-  <video id="d" poster="../compositing/resources/simple_image.png" controls></video>
>+  <video id="d" poster="../compositing/resources/circle.svg" controls></video>
>   <br>
>   <img class="no-invert" src="../compositing/resources/simple_image.png">
>   <picture class="no-invert"><img class="fallback" src="../compositing/resources/simple_image.png" alt=""></picture>
>   <video class="no-invert" poster="../compositing/resources/simple_image.png"></video>
>-  <video class="no-invert" poster="../compositing/resources/simple_image.png" controls></video>
>+  <video class="no-invert" poster="../compositing/resources/circle.svg" controls></video>
>   <br>
>   <img class="preserve-filter" src="../compositing/resources/simple_image.png" alt="">
>   <picture class="preserve-filter"><img class="fallback" src="../compositing/resources/simple_image.png" alt=""></picture>
>   <video class="preserve-filter" poster="../compositing/resources/simple_image.png"></video>
>-  <video class="preserve-filter" poster="../compositing/resources/simple_image.png" controls></video>
>+  <video class="preserve-filter" poster="../compositing/resources/circle.svg" controls></video>
>   
>   <div id="result"></div>
> </body>
>diff --git a/LayoutTests/platform/mac-wk2/TestExpectations b/LayoutTests/platform/mac-wk2/TestExpectations
>index caaa4c15daac91f3659a35a6240645cae2a0521d..23eea9cb254980381f54e6149f79cb3f59f2c8ea 100644
>--- a/LayoutTests/platform/mac-wk2/TestExpectations
>+++ b/LayoutTests/platform/mac-wk2/TestExpectations
>@@ -16,7 +16,7 @@ fast/events/autoscroll-when-zoomed.html [ Pass ]
> fast/events/autoscroll-main-document.html [ Pass ]
> 
> accessibility/smart-invert.html [ Pass ]
>-webkit.org/b/189818 accessibility/smart-invert-reference.html [ Pass ImageOnlyFailure ]
>+accessibility/smart-invert-reference.html [ Pass ]
> fast/media/mq-inverted-colors-live-update.html [ Pass ]
> fast/media/mq-inverted-colors-live-update-in-subframes.html [ Pass ]
> fast/media/mq-monochrome-live-update.html [ Pass ]

Flags:

ap: review-

Actions: View | Formatted Diff | Diff

Attachments on bug 189818: 350320 | 350321 | 350322 | 358283