Attachment 358282 Details for Bug 193109 – WIP

[patch] WIP

bug-193109-20190103154740.patch (text/plain), 47.58 KB, created by Wenson Hsieh on 2019-01-03 15:47:40 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Wenson Hsieh

Created: 2019-01-03 15:47:40 PST

Size: 47.58 KB

patch

obsolete

>Subversion Revision: 239591
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index dc1f8d982cc8394940734728052ad8004df6fa69..a6d05a3b65ac77a6dd6715a82112356d758a0aea 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,75 @@
>+2019-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
>+
>+        Introduce IDL files for runtime-enabled UndoManager and UndoItem JavaScript API
>+        https://bugs.webkit.org/show_bug.cgi?id=193109
>+        <rdar://problem/44807048>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Adds new IDL files and stubs for UndoManager and UndoItem. This is an experimental DOM API that (in the near
>+        future) is intended only for use in internal WebKit text editing clients. This API allows the page to
>+        participate in the processes of undoing and redoing by defining custom undo and redo handlers, to be executed
>+        when undo or redo is triggered.
>+
>+        Tests: editing/undo/UndoManager/undo-manager-basic-undo-redo.html
>+               editing/undo/UndoManager/undo-manager-interfaces.html
>+
>+        * CMakeLists.txt:
>+        * DerivedSources-input.xcfilelist:
>+        * DerivedSources-output.xcfilelist:
>+        * DerivedSources.make:
>+        * Sources.txt:
>+        * UnifiedSources-input.xcfilelist:
>+        * WebCore.xcodeproj/project.pbxproj:
>+
>+        Add new source files.
>+
>+        * bindings/js/WebCoreBuiltinNames.h:
>+
>+        Add "UndoManager" and "UndoItem" names.
>+
>+        * dom/Document.cpp:
>+        (WebCore::m_undoManager):
>+
>+        Have the document own a UndoManager.
>+
>+        (WebCore::m_identifier): Deleted.
>+        * dom/Document.h:
>+        (WebCore::Document::undoManager const):
>+        * dom/Document.idl:
>+        * page/RuntimeEnabledFeatures.h:
>+        (WebCore::RuntimeEnabledFeatures::setUndoManagerAPIEnabled):
>+        (WebCore::RuntimeEnabledFeatures::undoManagerAPIEnabled const):
>+
>+        Guard the new bindings behind a runtime-enabled feature flag.
>+
>+        * page/UndoItem.h:
>+        (WebCore::UndoItem::create):
>+        (WebCore::UndoItem::label const):
>+        (WebCore::UndoItem::undoHandler const):
>+        (WebCore::UndoItem::redoHandler const):
>+
>+        Implement `undo` and `redo` attributes as `undoHandler` and `redoHandler`, for a bit of added clarity.
>+
>+        (WebCore::UndoItem::setLabel):
>+        (WebCore::UndoItem::setUndoHandler):
>+        (WebCore::UndoItem::setRedoHandler):
>+        (WebCore::UndoItem::UndoItem):
>+        * page/UndoItem.idl:
>+        * page/UndoManager.cpp:
>+        (WebCore::UndoManager::addItem):
>+        (WebCore::UndoManager::undo):
>+        (WebCore::UndoManager::redo):
>+
>+        Implement these by invoking the corresponding methods on `document.execCommand`.
>+
>+        * page/UndoManager.h:
>+        (WebCore::UndoManager::create):
>+        * page/UndoManager.idl:
>+        * page/mac/WheelEventDeltaFilterMac.h:
>+
>+        Necessary (albeit unrelated) build fix to appease unified sources.
>+
> 2019-01-02  Simon Fraser  <simon.fraser@apple.com>
> 
>         REGRESSION (r239306): Don't disable font smoothing in transparent layers on macOS Mojave and later
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 83f5006f8f2374a2fa1a921ffcdf0e7121681eef..f3583a611e472995aa7fab8c184f7983d4671595 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,23 @@
>+2019-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
>+
>+        Introduce IDL files for runtime-enabled UndoManager and UndoItem JavaScript API
>+        https://bugs.webkit.org/show_bug.cgi?id=193109
>+        <rdar://problem/44807048>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Add a new SPI configuration flag to enable the UndoManager API. This is off by default.
>+
>+        * Shared/WebPreferences.yaml:
>+        * UIProcess/API/Cocoa/WKWebView.mm:
>+        (-[WKWebView _initializeWithConfiguration:]):
>+        * UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
>+        (-[WKWebViewConfiguration init]):
>+        (-[WKWebViewConfiguration copyWithZone:]):
>+        (-[WKWebViewConfiguration _setUndoManagerAPIEnabled:]):
>+        (-[WKWebViewConfiguration _undoManagerAPIEnabled]):
>+        * UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
>+
> 2019-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
> 
>         [iOS] REGRESSION (r239441): Tab cycling to offscreen <select> may not scroll it into view
>diff --git a/Source/WebCore/CMakeLists.txt b/Source/WebCore/CMakeLists.txt
>index 9c51418af76624841ebbf5c6589f250df85f1d50..a610b6d14431cbd55aae8afb3ab123052cc27df7 100644
>--- a/Source/WebCore/CMakeLists.txt
>+++ b/Source/WebCore/CMakeLists.txt
>@@ -923,6 +923,8 @@ set(WebCore_NON_SVG_IDL_FILES
>     page/ScrollLogicalPosition.idl
>     page/ScrollToOptions.idl
>     page/ShareData.idl
>+    page/UndoItem.idl
>+    page/UndoManager.idl
>     page/VisualViewport.idl
>     page/WebKitPoint.idl
>     page/WindowEventHandlers.idl
>diff --git a/Source/WebCore/DerivedSources-input.xcfilelist b/Source/WebCore/DerivedSources-input.xcfilelist
>index 90b25fa1e53185a10d30ae5ef1d34f5ae8cc475f..fff1d07441d166a31d39390a76770cd69b514dda 100644
>--- a/Source/WebCore/DerivedSources-input.xcfilelist
>+++ b/Source/WebCore/DerivedSources-input.xcfilelist
>@@ -852,6 +852,8 @@ $(PROJECT_DIR)/page/ScrollLogicalPosition.idl
> $(PROJECT_DIR)/page/ScrollToOptions.idl
> $(PROJECT_DIR)/page/Settings.yaml
> $(PROJECT_DIR)/page/ShareData.idl
>+$(PROJECT_DIR)/page/UndoItem.idl
>+$(PROJECT_DIR)/page/UndoManager.idl
> $(PROJECT_DIR)/page/UserMessageHandler.idl
> $(PROJECT_DIR)/page/UserMessageHandlersNamespace.idl
> $(PROJECT_DIR)/page/VisualViewport.idl
>diff --git a/Source/WebCore/DerivedSources-output.xcfilelist b/Source/WebCore/DerivedSources-output.xcfilelist
>index dfbb88b0c675c70c10cc27ce8a26fa148ce67cc8..8d2ac9d57c513f28291ab25a70014bcfb7f6263a 100644
>--- a/Source/WebCore/DerivedSources-output.xcfilelist
>+++ b/Source/WebCore/DerivedSources-output.xcfilelist
>@@ -1702,6 +1702,10 @@ $(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSUIEventInit.cpp
> $(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSUIEventInit.h
> $(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSURLSearchParams.cpp
> $(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSURLSearchParams.h
>+$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSUndoItem.cpp
>+$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSUndoItem.h
>+$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSUndoManager.cpp
>+$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSUndoManager.h
> $(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSUserMessageHandler.cpp
> $(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSUserMessageHandler.h
> $(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSUserMessageHandlersNamespace.cpp
>diff --git a/Source/WebCore/DerivedSources.make b/Source/WebCore/DerivedSources.make
>index e948b702f37a566e550a5ebe56e602fcb7922f8f..db27e58914415da4a5f807f2aa25a45a23b2891e 100644
>--- a/Source/WebCore/DerivedSources.make
>+++ b/Source/WebCore/DerivedSources.make
>@@ -872,6 +872,8 @@ JS_BINDING_IDLS = \
>     $(WebCore)/page/ScrollLogicalPosition.idl \
>     $(WebCore)/page/ScrollToOptions.idl \
>     $(WebCore)/page/ShareData.idl \
>+    $(WebCore)/page/UndoItem.idl \
>+    $(WebCore)/page/UndoManager.idl \
>     $(WebCore)/page/UserMessageHandler.idl \
>     $(WebCore)/page/UserMessageHandlersNamespace.idl \
>     $(WebCore)/page/VisualViewport.idl \
>diff --git a/Source/WebCore/Sources.txt b/Source/WebCore/Sources.txt
>index e7d934ad27f1bfa91231e1d86df0b7419d838b90..a274b09a40f668846c03415c5bfa868771a24d57 100644
>--- a/Source/WebCore/Sources.txt
>+++ b/Source/WebCore/Sources.txt
>@@ -1489,6 +1489,7 @@ page/SocketProvider.cpp
> page/SpatialNavigation.cpp
> page/SuspendableTimer.cpp
> page/TextIndicator.cpp
>+page/UndoManager.cpp
> page/UserContentProvider.cpp
> page/UserContentController.cpp
> page/UserContentURLPattern.cpp
>@@ -3204,6 +3205,8 @@ JSTextMetrics.cpp
> JSTimeRanges.cpp
> JSTransitionEvent.cpp
> JSTreeWalker.cpp
>+JSUndoItem.cpp
>+JSUndoManager.cpp
> JSUIEvent.cpp
> JSUIEventInit.cpp
> JSURLSearchParams.cpp
>diff --git a/Source/WebCore/UnifiedSources-input.xcfilelist b/Source/WebCore/UnifiedSources-input.xcfilelist
>index dfc2a3c29529a4146448ec8c3b5bcee081411730..07ce9464a8999726ee1a60435951312ef339da15 100644
>--- a/Source/WebCore/UnifiedSources-input.xcfilelist
>+++ b/Source/WebCore/UnifiedSources-input.xcfilelist
>@@ -818,6 +818,8 @@ $(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSTreeWalker.cpp
> $(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSUIEvent.cpp
> $(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSUIEventInit.cpp
> $(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSURLSearchParams.cpp
>+$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSUndoItem.cpp
>+$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSUndoManager.cpp
> $(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSUserMessageHandler.cpp
> $(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSUserMessageHandlersNamespace.cpp
> $(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSUserVerificationRequirement.cpp
>diff --git a/Source/WebCore/WebCore.xcodeproj/project.pbxproj b/Source/WebCore/WebCore.xcodeproj/project.pbxproj
>index de452c062a6ba26f47327077fc1f99acfcfd8ceb..960412680f29116f2522ec2b2e708f1b874572ff 100644
>--- a/Source/WebCore/WebCore.xcodeproj/project.pbxproj
>+++ b/Source/WebCore/WebCore.xcodeproj/project.pbxproj
>@@ -868,6 +868,8 @@
> 		2EB4BCD3121F03E300EC4885 /* BlobResourceHandle.h in Headers */ = {isa = PBXBuildFile; fileRef = 2EB4BCD1121F03E300EC4885 /* BlobResourceHandle.h */; };
> 		2EB767571DA19BDF003E23B5 /* InputEvent.h in Headers */ = {isa = PBXBuildFile; fileRef = 2EB767541DA19B67003E23B5 /* InputEvent.h */; settings = {ATTRIBUTES = (Private, ); }; };
> 		2EBBC3D81B65988300F5253D /* WheelEventDeltaFilter.h in Headers */ = {isa = PBXBuildFile; fileRef = 2EBBC3D71B65988300F5253D /* WheelEventDeltaFilter.h */; settings = {ATTRIBUTES = (Private, ); }; };
>+		2ECDBAD121D8903400F00ECD /* UndoManager.h in Headers */ = {isa = PBXBuildFile; fileRef = 2ECDBACE21D8903400F00ECD /* UndoManager.h */; };
>+		2ECDBAD821D8906300F00ECD /* UndoItem.h in Headers */ = {isa = PBXBuildFile; fileRef = 2ECDBAD521D8906300F00ECD /* UndoItem.h */; };
> 		2ECF7ADD10162B3800427DE7 /* JSErrorEvent.h in Headers */ = {isa = PBXBuildFile; fileRef = 2ECF7ADB10162B3800427DE7 /* JSErrorEvent.h */; };
> 		2ECF7AE210162B5800427DE7 /* ErrorEvent.h in Headers */ = {isa = PBXBuildFile; fileRef = 2ECF7ADF10162B5800427DE7 /* ErrorEvent.h */; };
> 		2ED609BD1145B07100C8684E /* DOMFormData.h in Headers */ = {isa = PBXBuildFile; fileRef = 2ED609BB1145B07100C8684E /* DOMFormData.h */; };
>@@ -6820,6 +6822,11 @@
> 		2EB767551DA19B99003E23B5 /* InputEvent.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = InputEvent.cpp; sourceTree = "<group>"; };
> 		2EBBC3D71B65988300F5253D /* WheelEventDeltaFilter.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WheelEventDeltaFilter.h; sourceTree = "<group>"; };
> 		2EC41DE21C0410A300D294FE /* RealtimeMediaSourceSupportedConstraints.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = RealtimeMediaSourceSupportedConstraints.cpp; sourceTree = "<group>"; };
>+		2ECDBACE21D8903400F00ECD /* UndoManager.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = UndoManager.h; sourceTree = "<group>"; };
>+		2ECDBACF21D8903400F00ECD /* UndoManager.cpp */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; path = UndoManager.cpp; sourceTree = "<group>"; };
>+		2ECDBAD021D8903400F00ECD /* UndoManager.idl */ = {isa = PBXFileReference; lastKnownFileType = text; path = UndoManager.idl; sourceTree = "<group>"; };
>+		2ECDBAD521D8906300F00ECD /* UndoItem.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = UndoItem.h; sourceTree = "<group>"; };
>+		2ECDBAD721D8906300F00ECD /* UndoItem.idl */ = {isa = PBXFileReference; lastKnownFileType = text; path = UndoItem.idl; sourceTree = "<group>"; };
> 		2ECF7ADA10162B3800427DE7 /* JSErrorEvent.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JSErrorEvent.cpp; sourceTree = "<group>"; };
> 		2ECF7ADB10162B3800427DE7 /* JSErrorEvent.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = JSErrorEvent.h; sourceTree = "<group>"; };
> 		2ECF7ADE10162B5800427DE7 /* ErrorEvent.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = ErrorEvent.cpp; sourceTree = "<group>"; };
>@@ -20105,6 +20112,11 @@
> 				62C1217B11AB9E77003C462C /* SuspendableTimer.h */,
> 				2D4F96F11A1ECC240098BF88 /* TextIndicator.cpp */,
> 				2D4F96F21A1ECC240098BF88 /* TextIndicator.h */,
>+				2ECDBAD521D8906300F00ECD /* UndoItem.h */,
>+				2ECDBAD721D8906300F00ECD /* UndoItem.idl */,
>+				2ECDBACF21D8903400F00ECD /* UndoManager.cpp */,
>+				2ECDBACE21D8903400F00ECD /* UndoManager.h */,
>+				2ECDBAD021D8903400F00ECD /* UndoManager.idl */,
> 				1AE79D40188DB61F002239C2 /* UserContentController.cpp */,
> 				1AE79D41188DB61F002239C2 /* UserContentController.h */,
> 				7C3F01BF1C8E5AB100ADD962 /* UserContentProvider.cpp */,
>@@ -31633,6 +31645,8 @@
> 				85031B4E0A44EFC700F992E0 /* UIEvent.h in Headers */,
> 				83FE7CA71DA9F1A70037237C /* UIEventInit.h in Headers */,
> 				85031B4F0A44EFC700F992E0 /* UIEventWithKeyState.h in Headers */,
>+				2ECDBAD821D8906300F00ECD /* UndoItem.h in Headers */,
>+				2ECDBAD121D8903400F00ECD /* UndoManager.h in Headers */,
> 				9B2D8A7914997CCF00ECEF3E /* UndoStep.h in Headers */,
> 				A863E2011343412000274926 /* UnicodeBidi.h in Headers */,
> 				518864E11BBAF57400E540C9 /* UniqueIDBDatabase.h in Headers */,
>diff --git a/Source/WebCore/bindings/js/WebCoreBuiltinNames.h b/Source/WebCore/bindings/js/WebCoreBuiltinNames.h
>index 2ae1ecf78361d866821c6e9c83ed5c43bbec456c..f89ff0d9acd74ba06e2f84a771ea10abc273f417 100644
>--- a/Source/WebCore/bindings/js/WebCoreBuiltinNames.h
>+++ b/Source/WebCore/bindings/js/WebCoreBuiltinNames.h
>@@ -178,6 +178,8 @@ namespace WebCore {
>     macro(StaticRange) \
>     macro(StylePropertyMapReadOnly) \
>     macro(StylePropertyMap) \
>+    macro(UndoItem) \
>+    macro(UndoManager) \
>     macro(VRDisplay) \
>     macro(VRDisplayCapabilities) \
>     macro(VRDisplayEvent) \
>diff --git a/Source/WebCore/dom/Document.cpp b/Source/WebCore/dom/Document.cpp
>index ec66be7661d21606e57cd1f749cdcd42c17f5edc..211c2bd89c8f2551198112bebd596ad113df5713 100644
>--- a/Source/WebCore/dom/Document.cpp
>+++ b/Source/WebCore/dom/Document.cpp
>@@ -210,6 +210,7 @@
> #include "TextNodeTraversal.h"
> #include "TransformSource.h"
> #include "TreeWalker.h"
>+#include "UndoManager.h"
> #include "UserGestureIndicator.h"
> #include "ValidationMessageClient.h"
> #include "VisibilityChangeClient.h"
>@@ -537,6 +538,7 @@ Document::Document(Frame* frame, const URL& url, unsigned documentClasses, unsig
>     , m_isNonRenderedPlaceholder(constructionFlags & NonRenderedPlaceholder)
>     , m_orientationNotifier(currentOrientation(frame))
>     , m_identifier(generateObjectIdentifier<DocumentIdentifierType>())
>+    , m_undoManager(UndoManager::create(*this))
> {
>     auto addResult = allDocumentsMap().add(m_identifier, this);
>     ASSERT_UNUSED(addResult, addResult.isNewEntry);
>diff --git a/Source/WebCore/dom/Document.h b/Source/WebCore/dom/Document.h
>index 8a0ffe10b459712274de7d7242860290737cf9ea..3c3735692f9b4c93547b564bd59f1a6d50e59c3e 100644
>--- a/Source/WebCore/dom/Document.h
>+++ b/Source/WebCore/dom/Document.h
>@@ -186,6 +186,7 @@ class StyleSheetList;
> class Text;
> class TextResourceDecoder;
> class TreeWalker;
>+class UndoManager;
> class VisibilityChangeClient;
> class VisitedLinkState;
> class WebAnimation;
>@@ -1004,6 +1005,8 @@ public:
>     WEBCORE_EXPORT bool queryCommandSupported(const String& command);
>     WEBCORE_EXPORT String queryCommandValue(const String& command);
> 
>+    UndoManager& undoManager() const { return m_undoManager.get(); }
>+
>     // designMode support
>     enum InheritedBool { off = false, on = true, inherit };    
>     void setDesignMode(InheritedBool value);
>@@ -2078,6 +2081,8 @@ private:
>     bool m_isRunningUserScripts { false };
> 
>     bool m_alwaysAllowLocalWebarchive { false };
>+
>+    Ref<UndoManager> m_undoManager;
> };
> 
> Element* eventTargetElementForDocument(Document*);
>diff --git a/Source/WebCore/dom/Document.idl b/Source/WebCore/dom/Document.idl
>index 1b68f24364d2ff583aa8d944df36490b4a3d7f1f..6f6379b8cffc95cf5d1c6ee807779667185419d8 100644
>--- a/Source/WebCore/dom/Document.idl
>+++ b/Source/WebCore/dom/Document.idl
>@@ -126,6 +126,7 @@ typedef (
>     boolean queryCommandState(DOMString commandId);
>     boolean queryCommandSupported(DOMString commandId);
>     DOMString queryCommandValue(DOMString commandId);
>+    [EnabledAtRuntime=UndoManagerAPI] readonly attribute UndoManager undoManager;
> 
>     // Special event handler IDL attributes that only apply to Document objects.
>     [LenientThis] attribute EventHandler onreadystatechange;
>diff --git a/Source/WebCore/page/RuntimeEnabledFeatures.h b/Source/WebCore/page/RuntimeEnabledFeatures.h
>index 114558efa65818dbf6b38dae4abc46a2fb3e31b6..02face0d3574bdc3bb5a3318a2e721c20289e26d 100644
>--- a/Source/WebCore/page/RuntimeEnabledFeatures.h
>+++ b/Source/WebCore/page/RuntimeEnabledFeatures.h
>@@ -315,6 +315,9 @@ public:
>     bool intersectionObserverEnabled() const { return m_intersectionObserverEnabled; }
> #endif
> 
>+    void setUndoManagerAPIEnabled(bool isEnabled) { m_undoManagerAPIEnabled = isEnabled; }
>+    bool undoManagerAPIEnabled() const { return m_undoManagerAPIEnabled; }
>+
> #if ENABLE(ENCRYPTED_MEDIA)
>     void setEncryptedMediaAPIEnabled(bool isEnabled) { m_encryptedMediaAPIEnabled = isEnabled; }
>     bool encryptedMediaAPIEnabled() const { return m_encryptedMediaAPIEnabled; }
>@@ -506,6 +509,8 @@ private:
>     bool m_systemPreviewEnabled { false };
> #endif
> 
>+    bool m_undoManagerAPIEnabled { false };
>+
>     friend class WTF::NeverDestroyed<RuntimeEnabledFeatures>;
> };
> 
>diff --git a/Source/WebCore/page/UndoItem.h b/Source/WebCore/page/UndoItem.h
>new file mode 100644
>index 0000000000000000000000000000000000000000..2a6e2516a1a8d75e10f67f62e53e84e35ea7c6fc
>--- /dev/null
>+++ b/Source/WebCore/page/UndoItem.h
>@@ -0,0 +1,63 @@
>+/*
>+ * Copyright (C) 2019 Apple Inc. All rights reserved.
>+ *
>+ * Redistribution and use in source and binary forms, with or without
>+ * modification, are permitted provided that the following conditions
>+ * are met:
>+ * 1. Redistributions of source code must retain the above copyright
>+ *    notice, this list of conditions and the following disclaimer.
>+ * 2. Redistributions in binary form must reproduce the above copyright
>+ *    notice, this list of conditions and the following disclaimer in the
>+ *    documentation and/or other materials provided with the distribution.
>+ *
>+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
>+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
>+ * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
>+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
>+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
>+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
>+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
>+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
>+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
>+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
>+ * THE POSSIBILITY OF SUCH DAMAGE.
>+ */
>+
>+#pragma once
>+
>+#include "VoidCallback.h"
>+#include <wtf/Function.h>
>+#include <wtf/RefCounted.h>
>+#include <wtf/text/WTFString.h>
>+
>+namespace WebCore {
>+
>+class UndoItem : public RefCounted<UndoItem> {
>+public:
>+    static Ref<UndoItem> create(String&& label)
>+    {
>+        return adoptRef(*new UndoItem(WTFMove(label)));
>+    }
>+
>+    virtual ~UndoItem() = default;
>+
>+    const String& label() const { return m_label; }
>+    const RefPtr<VoidCallback>& undoHandler() const { return m_undoHandler; }
>+    const RefPtr<VoidCallback>& redoHandler() const { return m_redoHandler; }
>+
>+    void setLabel(String&& label) { m_label = WTFMove(label); }
>+    void setUndoHandler(RefPtr<VoidCallback>&& handler) { m_undoHandler = WTFMove(handler); }
>+    void setRedoHandler(RefPtr<VoidCallback>&& handler) { m_redoHandler = WTFMove(handler); }
>+
>+private:
>+    UndoItem(String&& label)
>+        : m_label(WTFMove(label))
>+    {
>+    }
>+
>+    String m_label;
>+    RefPtr<VoidCallback> m_undoHandler;
>+    RefPtr<VoidCallback> m_redoHandler;
>+};
>+
>+} // namespace WebCore
>diff --git a/Source/WebCore/page/UndoItem.idl b/Source/WebCore/page/UndoItem.idl
>new file mode 100644
>index 0000000000000000000000000000000000000000..a722048efc44ccecae2d69356c1e1f27d6b6532d
>--- /dev/null
>+++ b/Source/WebCore/page/UndoItem.idl
>@@ -0,0 +1,33 @@
>+/*
>+ * Copyright (C) 2019 Apple Inc. All rights reserved.
>+ *
>+ * Redistribution and use in source and binary forms, with or without
>+ * modification, are permitted provided that the following conditions
>+ * are met:
>+ * 1. Redistributions of source code must retain the above copyright
>+ *    notice, this list of conditions and the following disclaimer.
>+ * 2. Redistributions in binary form must reproduce the above copyright
>+ *    notice, this list of conditions and the following disclaimer in the
>+ *    documentation and/or other materials provided with the distribution.
>+ *
>+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
>+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
>+ * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
>+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
>+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
>+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
>+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
>+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
>+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
>+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
>+ * THE POSSIBILITY OF SUCH DAMAGE.
>+ */
>+
>+[
>+    EnabledAtRuntime=UndoManagerAPI,
>+    Constructor(DOMString label)
>+] interface UndoItem {
>+    attribute DOMString label;
>+    [ImplementedAs=undoHandler] attribute VoidCallback? undo;
>+    [ImplementedAs=redoHandler] attribute VoidCallback? redo;
>+};
>diff --git a/Source/WebCore/page/UndoManager.cpp b/Source/WebCore/page/UndoManager.cpp
>new file mode 100644
>index 0000000000000000000000000000000000000000..ac86600bafd800ee02a2235dd2bf8ed9fa99e555
>--- /dev/null
>+++ b/Source/WebCore/page/UndoManager.cpp
>@@ -0,0 +1,49 @@
>+/*
>+ * Copyright (C) 2019 Apple Inc. All rights reserved.
>+ *
>+ * Redistribution and use in source and binary forms, with or without
>+ * modification, are permitted provided that the following conditions
>+ * are met:
>+ * 1. Redistributions of source code must retain the above copyright
>+ *    notice, this list of conditions and the following disclaimer.
>+ * 2. Redistributions in binary form must reproduce the above copyright
>+ *    notice, this list of conditions and the following disclaimer in the
>+ *    documentation and/or other materials provided with the distribution.
>+ *
>+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
>+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
>+ * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
>+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
>+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
>+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
>+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
>+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
>+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
>+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
>+ * THE POSSIBILITY OF SUCH DAMAGE.
>+ */
>+
>+#include "config.h"
>+#include "UndoManager.h"
>+
>+#include "Document.h"
>+#include "UndoItem.h"
>+
>+namespace WebCore {
>+
>+void UndoManager::addItem(Ref<UndoItem>&& item)
>+{
>+    UNUSED_PARAM(item);
>+}
>+
>+void UndoManager::undo()
>+{
>+    m_document.execCommand("Undo"_s);
>+}
>+
>+void UndoManager::redo()
>+{
>+    m_document.execCommand("Redo"_s);
>+}
>+
>+} // namespace WebCore
>diff --git a/Source/WebCore/page/UndoManager.h b/Source/WebCore/page/UndoManager.h
>new file mode 100644
>index 0000000000000000000000000000000000000000..ea492ffdddd6c952cef34a3d666eb824795116d5
>--- /dev/null
>+++ b/Source/WebCore/page/UndoManager.h
>@@ -0,0 +1,57 @@
>+/*
>+ * Copyright (C) 2019 Apple Inc. All rights reserved.
>+ *
>+ * Redistribution and use in source and binary forms, with or without
>+ * modification, are permitted provided that the following conditions
>+ * are met:
>+ * 1. Redistributions of source code must retain the above copyright
>+ *    notice, this list of conditions and the following disclaimer.
>+ * 2. Redistributions in binary form must reproduce the above copyright
>+ *    notice, this list of conditions and the following disclaimer in the
>+ *    documentation and/or other materials provided with the distribution.
>+ *
>+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
>+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
>+ * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
>+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
>+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
>+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
>+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
>+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
>+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
>+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
>+ * THE POSSIBILITY OF SUCH DAMAGE.
>+ */
>+
>+#pragma once
>+
>+#include <wtf/Ref.h>
>+#include <wtf/RefCounted.h>
>+
>+namespace WebCore {
>+
>+class Document;
>+class UndoItem;
>+
>+class UndoManager : public RefCounted<UndoManager> {
>+public:
>+    static Ref<UndoManager> create(Document& document)
>+    {
>+        return adoptRef(*new UndoManager(document));
>+    }
>+
>+    virtual ~UndoManager() = default;
>+    void addItem(Ref<UndoItem>&&);
>+    void undo();
>+    void redo();
>+
>+private:
>+    UndoManager(Document& document)
>+        : m_document(document)
>+    {
>+    }
>+
>+    Document& m_document;
>+};
>+
>+} // namespace WebCore
>diff --git a/Source/WebCore/page/UndoManager.idl b/Source/WebCore/page/UndoManager.idl
>new file mode 100644
>index 0000000000000000000000000000000000000000..2e896af7c603fd7b4878d482da1f00b7b92e34c3
>--- /dev/null
>+++ b/Source/WebCore/page/UndoManager.idl
>@@ -0,0 +1,32 @@
>+/*
>+ * Copyright (C) 2019 Apple Inc. All rights reserved.
>+ *
>+ * Redistribution and use in source and binary forms, with or without
>+ * modification, are permitted provided that the following conditions
>+ * are met:
>+ * 1. Redistributions of source code must retain the above copyright
>+ *    notice, this list of conditions and the following disclaimer.
>+ * 2. Redistributions in binary form must reproduce the above copyright
>+ *    notice, this list of conditions and the following disclaimer in the
>+ *    documentation and/or other materials provided with the distribution.
>+ *
>+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
>+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
>+ * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
>+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
>+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
>+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
>+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
>+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
>+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
>+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
>+ * THE POSSIBILITY OF SUCH DAMAGE.
>+ */
>+
>+[
>+    EnabledAtRuntime=UndoManagerAPI
>+] interface UndoManager {
>+    void addItem(UndoItem item);
>+    void undo();
>+    void redo();
>+};
>diff --git a/Source/WebCore/page/mac/WheelEventDeltaFilterMac.h b/Source/WebCore/page/mac/WheelEventDeltaFilterMac.h
>index 310822ccbc15dbdd771982374c08924841f7fd57..2cc98bf791cd27ca5d6b77e0f5a5adac45ea19e9 100644
>--- a/Source/WebCore/page/mac/WheelEventDeltaFilterMac.h
>+++ b/Source/WebCore/page/mac/WheelEventDeltaFilterMac.h
>@@ -28,6 +28,7 @@
> #if PLATFORM(MAC)
> 
> #include "WheelEventDeltaFilter.h"
>+#include <wtf/MonotonicTime.h>
> #include <wtf/RetainPtr.h>
> 
> OBJC_CLASS _NSScrollingPredominantAxisFilter;
>diff --git a/Source/WebKit/Shared/WebPreferences.yaml b/Source/WebKit/Shared/WebPreferences.yaml
>index bff125239ff8af9977a4a9f5424c00a0c58b25ae..f32235e77c525a562e4793d4c7fa4dbb4f64996f 100644
>--- a/Source/WebKit/Shared/WebPreferences.yaml
>+++ b/Source/WebKit/Shared/WebPreferences.yaml
>@@ -1518,3 +1518,11 @@ CaptureVideoInUIProcessEnabled:
>   category: internal
>   webcoreBinding: none
>   condition: ENABLE(MEDIA_STREAM)
>+
>+UndoManagerAPIEnabled:
>+  type: bool
>+  defaultValue: false
>+  humanReadableName: "UndoManager DOM API"
>+  humanReadableDescription: "Enable the UndoManager DOM API"
>+  category: internal
>+  webcoreBinding: RuntimeEnabledFeatures
>diff --git a/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm b/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
>index 3c5bebf27b42fb9456fedd0e9ae133e75bda6dc9..75f76520e078fbe9fdd86ae19c9196ba2a9a680d 100644
>--- a/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
>+++ b/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
>@@ -645,6 +645,7 @@ - (void)_initializeWithConfiguration:(WKWebViewConfiguration *)configuration
>     pageConfiguration->preferenceValues().set(WebKit::WebPreferencesKey::colorFilterEnabledKey(), WebKit::WebPreferencesStore::Value(!![_configuration _colorFilterEnabled]));
> 
>     pageConfiguration->preferenceValues().set(WebKit::WebPreferencesKey::editableImagesEnabledKey(), WebKit::WebPreferencesStore::Value(!![_configuration _editableImagesEnabled]));
>+    pageConfiguration->preferenceValues().set(WebKit::WebPreferencesKey::undoManagerAPIEnabledKey(), WebKit::WebPreferencesStore::Value(!![_configuration _undoManagerAPIEnabled]));
> 
> #if ENABLE(LEGACY_ENCRYPTED_MEDIA)
>     pageConfiguration->preferenceValues().set(WebKit::WebPreferencesKey::legacyEncryptedMediaAPIEnabledKey(), WebKit::WebPreferencesStore::Value(!![_configuration _legacyEncryptedMediaAPIEnabled]));
>diff --git a/Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm b/Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm
>index de6f33ed972ec7f039ba6e21a59bc69805820257..f983fa6477ad971cbe7cef7a49e53ea0dc11d791 100644
>--- a/Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm
>+++ b/Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm
>@@ -160,6 +160,7 @@ @implementation WKWebViewConfiguration {
>     BOOL _shouldDeferAsynchronousScriptsUntilAfterDocumentLoad;
>     BOOL _drawsBackground;
>     BOOL _editableImagesEnabled;
>+    BOOL _undoManagerAPIEnabled;
> 
>     RetainPtr<NSString> _mediaContentTypesRequiringHardwareSupport;
>     RetainPtr<NSArray<NSString *>> _additionalSupportedImageTypes;
>@@ -248,6 +249,7 @@ - (instancetype)init
>     _drawsBackground = YES;
> 
>     _editableImagesEnabled = NO;
>+    _undoManagerAPIEnabled = YES;
> 
>     return self;
> }
>@@ -409,6 +411,7 @@ - (id)copyWithZone:(NSZone *)zone
>     configuration->_drawsBackground = self->_drawsBackground;
> 
>     configuration->_editableImagesEnabled = self->_editableImagesEnabled;
>+    configuration->_undoManagerAPIEnabled = self->_undoManagerAPIEnabled;
> 
>     return configuration;
> }
>@@ -1037,6 +1040,16 @@ - (BOOL)_editableImagesEnabled
>     return _editableImagesEnabled;
> }
> 
>+- (void)_setUndoManagerAPIEnabled:(BOOL)enabled
>+{
>+    _undoManagerAPIEnabled = enabled;
>+}
>+
>+- (BOOL)_undoManagerAPIEnabled
>+{
>+    return _undoManagerAPIEnabled;
>+}
>+
> @end
> 
> @implementation WKWebViewConfiguration (WKDeprecated)
>diff --git a/Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h b/Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h
>index 37c430fbe8a5160df669e013e0e12e51617799bd..2abc8c14abf8b7eb64ff9e068f13caa5e78845ac 100644
>--- a/Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h
>+++ b/Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h
>@@ -106,6 +106,7 @@ typedef NS_ENUM(NSUInteger, _WKDragLiftDelay) {
> @property (nonatomic, copy, setter=_setAdditionalSupportedImageTypes:) NSArray<NSString *> *_additionalSupportedImageTypes WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA));
> 
> @property (nonatomic, setter=_setEditableImagesEnabled:) BOOL _editableImagesEnabled WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA));
>+@property (nonatomic, setter=_setUndoManagerAPIEnabled:) BOOL _undoManagerAPIEnabled WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA));
> 
> @end
> 
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 490a0ea86e4d8bee44dfc80bfa04afbbad0761c8..413cbd280468dda05cbb59e0692176a78e138477 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,20 @@
>+2019-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
>+
>+        Introduce IDL files for runtime-enabled UndoManager and UndoItem JavaScript API
>+        https://bugs.webkit.org/show_bug.cgi?id=193109
>+        <rdar://problem/44807048>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Introduce and respect a test option to enable the UndoManager API.
>+
>+        * WebKitTestRunner/TestController.cpp:
>+        (WTR::updateTestOptionsFromTestHeader):
>+        * WebKitTestRunner/TestOptions.h:
>+        (WTR::TestOptions::hasSameInitializationOptions const):
>+        * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
>+        (WTR::TestController::platformCreateWebView):
>+
> 2019-01-02  Alex Christensen  <achristensen@webkit.org>
> 
>         Homograph with LATIN SMALL LETTER R WITH FISHHOOK
>diff --git a/Tools/WebKitTestRunner/TestController.cpp b/Tools/WebKitTestRunner/TestController.cpp
>index 6d4dffb49656524c64d962e79fe238384c69c0c6..7c88e0027f3d750be61567232a881adcdfb4dda8 100644
>--- a/Tools/WebKitTestRunner/TestController.cpp
>+++ b/Tools/WebKitTestRunner/TestController.cpp
>@@ -1264,6 +1264,8 @@ static void updateTestOptionsFromTestHeader(TestOptions& testOptions, const std:
>             testOptions.enableEditableImages = parseBooleanTestHeaderValue(value);
>         else if (key == "editable")
>             testOptions.editable = parseBooleanTestHeaderValue(value);
>+        else if (key == "enableUndoManagerAPI")
>+            testOptions.enableUndoManagerAPI = parseBooleanTestHeaderValue(value);
>         pairStart = pairEnd + 1;
>     }
> }
>diff --git a/Tools/WebKitTestRunner/TestOptions.h b/Tools/WebKitTestRunner/TestOptions.h
>index 05a4efbf90e5cce9dc404e841c700612278a60e5..10cd4e4c34571b0b1b8a02cb6dd479c67fec7340 100644
>--- a/Tools/WebKitTestRunner/TestOptions.h
>+++ b/Tools/WebKitTestRunner/TestOptions.h
>@@ -67,6 +67,7 @@ struct TestOptions {
>     bool shouldShowSpellCheckingDots { false };
>     bool enableEditableImages { false };
>     bool editable { false };
>+    bool enableUndoManagerAPI { false };
> 
>     float deviceScaleFactor { 1 };
>     Vector<String> overrideLanguages;
>@@ -111,7 +112,8 @@ struct TestOptions {
>             || shouldShowSpellCheckingDots != options.shouldShowSpellCheckingDots
>             || shouldIgnoreMetaViewport != options.shouldIgnoreMetaViewport
>             || enableEditableImages != options.enableEditableImages
>-            || editable != options.editable)
>+            || editable != options.editable
>+            || enableUndoManagerAPI != options.enableUndoManagerAPI)
>             return false;
> 
>         if (experimentalFeatures != options.experimentalFeatures)
>diff --git a/Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm b/Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm
>index 11b0e3ae34fbbe7e1ba9e1721a4d118d33026796..2c1f6a63c9e49e7cce81dacb60dda2f8f5b18a83 100644
>--- a/Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm
>+++ b/Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm
>@@ -161,6 +161,9 @@ void TestController::platformCreateWebView(WKPageConfigurationRef, const TestOpt
>     if (options.enableEditableImages)
>         [copiedConfiguration _setEditableImagesEnabled:YES];
> 
>+    if (options.enableUndoManagerAPI)
>+        [copiedConfiguration _setUndoManagerAPIEnabled:YES];
>+
>     if (options.applicationManifest.length()) {
>         auto manifestPath = [NSString stringWithUTF8String:options.applicationManifest.c_str()];
>         NSString *text = [NSString stringWithContentsOfFile:manifestPath usedEncoding:nullptr error:nullptr];
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 886d5a5c429faa558c4540a3f66d1c4dd3e4c393..9b14f85eae8a774c4a8bb97e719394ae1af6229e 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,22 @@
>+2019-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
>+
>+        Introduce IDL files for runtime-enabled UndoManager and UndoItem JavaScript API
>+        https://bugs.webkit.org/show_bug.cgi?id=193109
>+        <rdar://problem/44807048>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Add UndoManager tests to exercise new bindings, as well as check that UndoManager.undo and UndoManager.redo
>+        work as expected, and can be used alongside document.execCommand.
>+
>+        * TestExpectations:
>+        * editing/undo/UndoManager/undo-manager-basic-undo-redo-expected.txt: Added.
>+        * editing/undo/UndoManager/undo-manager-basic-undo-redo.html: Added.
>+        * editing/undo/UndoManager/undo-manager-interfaces-expected.txt: Added.
>+        * editing/undo/UndoManager/undo-manager-interfaces.html: Added.
>+        * platform/ios-wk2/TestExpectations:
>+        * platform/mac-wk2/TestExpectations:
>+
> 2019-01-02  Simon Fraser  <simon.fraser@apple.com>
> 
>         REGRESSION (r239306): Don't disable font smoothing in transparent layers on macOS Mojave and later
>diff --git a/LayoutTests/TestExpectations b/LayoutTests/TestExpectations
>index 23018bc2921d41600b98bb6cef164b9c74ad7665..1609874097361425db6afdf5c5452becc94fee32 100644
>--- a/LayoutTests/TestExpectations
>+++ b/LayoutTests/TestExpectations
>@@ -19,6 +19,7 @@ editing/input/ios [ Skip ]
> editing/find [ Skip ]
> editing/pasteboard/gtk [ Skip ]
> editing/selection/ios [ Skip ]
>+editing/undo/UndoManager [ Skip ]
> tiled-drawing [ Skip ]
> fast/css/watchos [ Skip ]
> fast/dom/Window/watchos [ Skip ]
>diff --git a/LayoutTests/editing/undo/UndoManager/undo-manager-basic-undo-redo-expected.txt b/LayoutTests/editing/undo/UndoManager/undo-manager-basic-undo-redo-expected.txt
>new file mode 100644
>index 0000000000000000000000000000000000000000..03d34b3a3c3b8a6a0a1d3897fa920202cd9b9176
>--- /dev/null
>+++ b/LayoutTests/editing/undo/UndoManager/undo-manager-basic-undo-redo-expected.txt
>@@ -0,0 +1,16 @@
>+Verifies that UndoManager.undo and UndoManager.redo can be used to undo and redo editing commands.
>+
>+After inserting text:
>+| "hello<#selection-caret>"
>+
>+After undoing using UndoManager:
>+| 
>+
>+After redoing using execCommand:
>+| "hello<#selection-caret>"
>+
>+After undoing again using execCommand:
>+| 
>+
>+After redoing again using UndoManager:
>+| "hello<#selection-caret>"
>diff --git a/LayoutTests/editing/undo/UndoManager/undo-manager-basic-undo-redo.html b/LayoutTests/editing/undo/UndoManager/undo-manager-basic-undo-redo.html
>new file mode 100644
>index 0000000000000000000000000000000000000000..a0060155c712266a14ea5a79ea8061491a573a43
>--- /dev/null
>+++ b/LayoutTests/editing/undo/UndoManager/undo-manager-basic-undo-redo.html
>@@ -0,0 +1,26 @@
>+<!DOCTYPE html> 
>+<html>
>+    <head>
>+        <script src="../../../resources/dump-as-markup.js"></script>
>+    </head>
>+    <body>
>+        <div id="editor" contenteditable></div>
>+    </body>
>+    <script>
>+        editor.focus();
>+
>+        Markup.description("Verifies that UndoManager.undo and UndoManager.redo can be used to undo and redo editing commands.");
>+        document.execCommand("InsertHTML", true, "hello");
>+        Markup.dump("editor", "After inserting text");
>+        document.undoManager.undo();
>+        Markup.dump("editor", "After undoing using UndoManager");
>+        document.execCommand("redo");
>+        Markup.dump("editor", "After redoing using execCommand");
>+        document.execCommand("undo");
>+        Markup.dump("editor", "After undoing again using execCommand");
>+        document.undoManager.redo();
>+        Markup.dump("editor", "After redoing again using UndoManager");
>+
>+        editor.remove();
>+    </script>
>+</html>
>diff --git a/LayoutTests/editing/undo/UndoManager/undo-manager-interfaces-expected.txt b/LayoutTests/editing/undo/UndoManager/undo-manager-interfaces-expected.txt
>new file mode 100644
>index 0000000000000000000000000000000000000000..800bcc4df841c3e5b6ffd66b321a37340af18fe4
>--- /dev/null
>+++ b/LayoutTests/editing/undo/UndoManager/undo-manager-interfaces-expected.txt
>@@ -0,0 +1,49 @@
>+Verifies that, when the UndoManager API is enabled, UndoManager and UndoItem interfaces behave as expected.
>+
>+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
>+
>+
>+
>+Testing UndoManager:
>+PASS UndoManager instanceof Function is true
>+PASS typeof UndoManager is "function"
>+PASS document.undoManager instanceof UndoManager is true
>+PASS Object.getPrototypeOf(document.undoManager) === UndoManager.prototype is true
>+PASS UndoManager.prototype.addItem instanceof Function is true
>+PASS UndoManager.prototype.undo instanceof Function is true
>+PASS UndoManager.prototype.redo instanceof Function is true
>+PASS UndoManager() threw exception TypeError: Illegal constructor.
>+PASS new UndoManager() threw exception TypeError: function is not a constructor (evaluating 'new UndoManager()').
>+PASS document.undoManager.addItem() threw exception TypeError: Not enough arguments.
>+PASS document.undoManager.addItem('foo') threw exception TypeError: Argument 1 ('item') to UndoManager.addItem must be an instance of UndoItem.
>+PASS document.undoManager.undo() did not throw exception.
>+PASS document.undoManager.redo() did not throw exception.
>+PASS document.undoManager.undo(2) did not throw exception.
>+PASS document.undoManager.redo(new Array(0)) did not throw exception.
>+PASS UndoManager.toString() is "function UndoManager() {\n    [native code]\n}"
>+PASS document.undoManager.toString() is "[object UndoManager]"
>+
>+Testing UndoItem:
>+PASS UndoItem instanceof Function is true
>+PASS typeof UndoItem is "function"
>+PASS UndoItem() threw exception TypeError: Constructor requires 'new' operator.
>+PASS new UndoItem() threw exception TypeError: Not enough arguments.
>+PASS new UndoItem('') instanceof UndoItem is true
>+PASS Object.getPrototypeOf(new UndoItem('')) === UndoItem.prototype is true
>+PASS UndoItem.toString() is "function UndoItem() {\n    [native code]\n}"
>+PASS new UndoItem('').toString() is "[object UndoItem]"
>+PASS document.undoManager.addItem(new UndoItem('')) did not throw exception.
>+PASS new UndoItem('foo').label is "foo"
>+PASS new UndoItem('').label = 'testing' is "testing"
>+PASS new UndoItem('').undo is null
>+PASS new UndoItem('').undo = 8 threw exception TypeError: The UndoItem.undo attribute must be an instance of VoidCallback.
>+PASS new UndoItem('').undo = null is null
>+PASS new UndoItem('').undo = () => { } did not throw exception.
>+PASS new UndoItem('').redo is null
>+PASS new UndoItem('').redo = 'hi' threw exception TypeError: The UndoItem.redo attribute must be an instance of VoidCallback.
>+PASS new UndoItem('').redo = undefined is undefined
>+PASS new UndoItem('').redo = (foo, bar) => { } did not throw exception.
>+PASS successfullyParsed is true
>+
>+TEST COMPLETE
>+
>diff --git a/LayoutTests/editing/undo/UndoManager/undo-manager-interfaces.html b/LayoutTests/editing/undo/UndoManager/undo-manager-interfaces.html
>new file mode 100644
>index 0000000000000000000000000000000000000000..510f87f09d359dd0532d987b13cc4b97c7055bb6
>--- /dev/null
>+++ b/LayoutTests/editing/undo/UndoManager/undo-manager-interfaces.html
>@@ -0,0 +1,53 @@
>+<!DOCTYPE html> 
>+<html>
>+    <head>
>+        <script src="../../../resources/js-test.js"></script>
>+    </head>
>+    <script>
>+        function runTest()
>+        {
>+            description("Verifies that, when the UndoManager API is enabled, UndoManager and UndoItem interfaces behave as expected.");
>+
>+            debug("\nTesting UndoManager:");
>+            shouldBeTrue("UndoManager instanceof Function");
>+            shouldBeEqualToString("typeof UndoManager", "function");
>+            shouldBeTrue("document.undoManager instanceof UndoManager");
>+            shouldBeTrue("Object.getPrototypeOf(document.undoManager) === UndoManager.prototype");
>+            shouldBeTrue("UndoManager.prototype.addItem instanceof Function");
>+            shouldBeTrue("UndoManager.prototype.undo instanceof Function");
>+            shouldBeTrue("UndoManager.prototype.redo instanceof Function");
>+            shouldThrow("UndoManager()");
>+            shouldThrow("new UndoManager()");
>+            shouldThrow("document.undoManager.addItem()");
>+            shouldThrow("document.undoManager.addItem('foo')");
>+            shouldNotThrow("document.undoManager.undo()");
>+            shouldNotThrow("document.undoManager.redo()");
>+            shouldNotThrow("document.undoManager.undo(2)");
>+            shouldNotThrow("document.undoManager.redo(new Array(0))");
>+            shouldBeEqualToString("UndoManager.toString()", "function UndoManager() {\n    [native code]\n}");
>+            shouldBeEqualToString("document.undoManager.toString()", "[object UndoManager]");
>+
>+            debug("\nTesting UndoItem:");
>+            shouldBeTrue("UndoItem instanceof Function");
>+            shouldBeEqualToString("typeof UndoItem", "function");
>+            shouldThrow("UndoItem()");
>+            shouldThrow("new UndoItem()");
>+            shouldBeTrue("new UndoItem('') instanceof UndoItem");
>+            shouldBeTrue("Object.getPrototypeOf(new UndoItem('')) === UndoItem.prototype");
>+            shouldBeEqualToString("UndoItem.toString()", "function UndoItem() {\n    [native code]\n}");
>+            shouldBeEqualToString("new UndoItem('').toString()", "[object UndoItem]");
>+            shouldNotThrow("document.undoManager.addItem(new UndoItem(''))");
>+            shouldBeEqualToString("new UndoItem('foo').label", "foo");
>+            shouldBeEqualToString("new UndoItem('').label = 'testing'", "testing");
>+            shouldBeNull("new UndoItem('').undo");
>+            shouldThrow("new UndoItem('').undo = 8");
>+            shouldBe("new UndoItem('').undo = null", "null");
>+            shouldNotThrow("new UndoItem('').undo = () => { }");
>+            shouldBeNull("new UndoItem('').redo");
>+            shouldThrow("new UndoItem('').redo = 'hi'");
>+            shouldBe("new UndoItem('').redo = undefined", "undefined");
>+            shouldNotThrow("new UndoItem('').redo = (foo, bar) => { }");
>+        }
>+    </script>
>+    <body onload=runTest()></body>
>+</html>
>diff --git a/LayoutTests/platform/ios-wk2/TestExpectations b/LayoutTests/platform/ios-wk2/TestExpectations
>index c36183dda7a10cd08b0519fd31dabc5bc8df56bf..b86c942b3302763aefc29f2416507cab5d6ed0fa 100644
>--- a/LayoutTests/platform/ios-wk2/TestExpectations
>+++ b/LayoutTests/platform/ios-wk2/TestExpectations
>@@ -16,6 +16,7 @@ tiled-drawing/ios [ Pass ]
> fast/web-share [ Pass ]
> editing/find [ Pass ]
> editing/input/ios [ Pass ]
>+editing/undo/UndoManager [ Pass ]
> 
> editing/selection/character-granularity-rect.html [ Failure ]
> 
>diff --git a/LayoutTests/platform/mac-wk2/TestExpectations b/LayoutTests/platform/mac-wk2/TestExpectations
>index caaa4c15daac91f3659a35a6240645cae2a0521d..fd796054709f6f0d1a1c17ef4a3f320c997fdbc0 100644
>--- a/LayoutTests/platform/mac-wk2/TestExpectations
>+++ b/LayoutTests/platform/mac-wk2/TestExpectations
>@@ -11,6 +11,7 @@ fast/visual-viewport/tiled-drawing [ Pass ]
> swipe [ Pass ]
> fast/web-share [ Pass ]
> editing/find [ Pass ]
>+editing/undo/UndoManager [ Pass ]
> 
> fast/events/autoscroll-when-zoomed.html [ Pass ]
> fast/events/autoscroll-main-document.html [ Pass ]

Actions: View | Formatted Diff | Diff

Attachments on bug 193109: 358282 | 358847 | 358873