Attachment 358281 Details for Bug 193124 – Patch

[patch] Patch

bug-193124-20190103150510.patch (text/plain), 2.07 KB, created by Simon Fraser (smfr) on 2019-01-03 15:05:11 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Simon Fraser (smfr)

Created: 2019-01-03 15:05:11 PST

Size: 2.07 KB

patch

obsolete

>Subversion Revision: 239596
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index dc1f8d982cc8394940734728052ad8004df6fa69..50add1316750541338028bed9ff1e9e1f8398230 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,21 @@
>+2019-01-03  Simon Fraser  <simon.fraser@apple.com>
>+
>+        REGRESSION (r238090): After showing the Find banner or tab bar, hit tests are vertically offset (or painting is not offset)
>+        https://bugs.webkit.org/show_bug.cgi?id=193124
>+        rdar://problem/46755409
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Top content inset feeds into scrolling tree geometry, so when it changes we need to trigger
>+        an update of the root scrolling node, which happens via RenderLayerBacking::updateGeometry().
>+        So set a dirty bit on the root layer in frameViewDidChangeSize(), which is called from the code
>+        path that runs when top content inset changes.
>+
>+        Find banner behavior is not easily testable. platform/mac/fast/events/content-inset-hit-testing.html did not detect the regression.
>+
>+        * rendering/RenderLayerCompositor.cpp:
>+        (WebCore::RenderLayerCompositor::frameViewDidChangeSize):
>+
> 2019-01-02  Simon Fraser  <simon.fraser@apple.com>
> 
>         REGRESSION (r239306): Don't disable font smoothing in transparent layers on macOS Mojave and later
>diff --git a/Source/WebCore/rendering/RenderLayerCompositor.cpp b/Source/WebCore/rendering/RenderLayerCompositor.cpp
>index d34f659794e10ff5afec58a7c95b7e17de8d0fd2..578efb2960f806ee00db4bb22dc0d52e43711291 100644
>--- a/Source/WebCore/rendering/RenderLayerCompositor.cpp
>+++ b/Source/WebCore/rendering/RenderLayerCompositor.cpp
>@@ -1806,6 +1806,9 @@ void RenderLayerCompositor::frameViewDidChangeLocation(const IntPoint& contentsO
> 
> void RenderLayerCompositor::frameViewDidChangeSize()
> {
>+    if (auto* layer = m_renderView.layer())
>+        layer->setNeedsCompositingGeometryUpdate();
>+
>     if (m_clipLayer) {
>         const FrameView& frameView = m_renderView.frameView();
>         m_clipLayer->setSize(frameView.sizeForVisibleContent());

Actions: View | Formatted Diff | Diff

Attachments on bug 193124: 358281