WebKit Bugzilla
Attachment 358277 Details for
Bug 193053
: test262-runner misbehaves when test file YAML has a trailing space
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-193053-20190103141029.patch (text/plain), 8.39 KB, created by
Ross Kirsling
on 2019-01-03 14:10:30 PST
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Ross Kirsling
Created:
2019-01-03 14:10:30 PST
Size:
8.39 KB
patch
obsolete
>Subversion Revision: 239596 >diff --git a/Tools/ChangeLog b/Tools/ChangeLog >index 3ea765f6438546d0a15a61707c4be6cec6ee635f..9f32f2b77e298681e47b11298d6182c759b66314 100644 >--- a/Tools/ChangeLog >+++ b/Tools/ChangeLog >@@ -1,3 +1,14 @@ >+2019-01-03 Ross Kirsling <ross.kirsling@sony.com> >+ >+ test262-runner misbehaves when test file YAML has a trailing space >+ https://bugs.webkit.org/show_bug.cgi?id=193053 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * Scripts/test262/Runner.pm: >+ (parseData): >+ Accept trailing space when parsing a test file's YAML block. >+ > 2019-01-03 Michael Catanzaro <mcatanzaro@igalia.com> > > UserMedia test should use WKPageNavigationClient >diff --git a/Tools/Scripts/test262/Runner.pm b/Tools/Scripts/test262/Runner.pm >index 6af261df24206dcf1587b08977f461379fa1572e..e948a440c3cf928221a9e05c42ea9f77d98b752a 100755 >--- a/Tools/Scripts/test262/Runner.pm >+++ b/Tools/Scripts/test262/Runner.pm >@@ -871,7 +871,7 @@ sub parseData { > > my $parsed; > my $found = ''; >- if ($contents =~ /\/\*(---[\r\n]+[\S\s]*)[\r\n]+---\*\//m) { >+ if ($contents =~ /\/\*(---[\r\n]+[\S\s]*)[\r\n]+\s*---\*\//m) { > $found = $1; > }; > >diff --git a/JSTests/ChangeLog b/JSTests/ChangeLog >index 8cd88133220b2253c6fdae49e5c4d622389e9b9e..41e1bb697874d8402a874a0359cb02f0dd5e596d 100644 >--- a/JSTests/ChangeLog >+++ b/JSTests/ChangeLog >@@ -1,3 +1,13 @@ >+2019-01-03 Ross Kirsling <ross.kirsling@sony.com> >+ >+ test262-runner misbehaves when test file YAML has a trailing space >+ https://bugs.webkit.org/show_bug.cgi?id=193053 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * test262/expectations.yaml: >+ Mark two dozen tests as passing (and correct the output of another). >+ > 2018-12-30 Yusuke Suzuki <yusukesuzuki@slowstart.org> > > Unreviewed, JSTests gardening with memoryLimited >diff --git a/JSTests/test262/expectations.yaml b/JSTests/test262/expectations.yaml >index 3be8dec314fa1669b3309cb407bc9010a7dde87e..3c8334116a9b1f29c2f813ecab202166795ae8e4 100644 >--- a/JSTests/test262/expectations.yaml >+++ b/JSTests/test262/expectations.yaml >@@ -1049,9 +1049,6 @@ test/built-ins/Object/defineProperties/15.2.3.7-5-a-16.js: > test/built-ins/Object/defineProperties/15.2.3.7-5-b-248.js: > default: 'TypeError: Property description must be an object.' > strict mode: 'TypeError: Property description must be an object.' >-test/built-ins/Object/defineProperty/15.2.3.6-4-289-1.js: >- default: "ReferenceError: Can't find variable: verifyEqualTo" >- strict mode: "ReferenceError: Can't find variable: verifyEqualTo" > test/built-ins/Object/internals/DefineOwnProperty/consistent-value-function-arguments.js: > default: 'Test262Error: Expected SameValue(ënullû, ë[object Arguments]û) to be true' > test/built-ins/Object/internals/DefineOwnProperty/consistent-value-function-caller.js: >@@ -6782,18 +6779,6 @@ test/language/expressions/object/method-definition/yield-as-function-expression- > strict mode: "SyntaxError: Cannot use 'yield' as a function name in strict mode." > test/language/expressions/object/method-definition/yield-as-identifier-in-nested-function.js: > strict mode: "SyntaxError: Unexpected keyword 'yield'. Cannot use yield expression out of generator." >-test/language/expressions/object/method-definition/yield-as-logical-or-expression.js: >- default: "SyntaxError: Unexpected token '?'" >- strict mode: "SyntaxError: Unexpected token '?'" >-test/language/expressions/object/method-definition/yield-as-parameter.js: >- default: "SyntaxError: Cannot use 'yield' as a parameter name in a generator function." >- strict mode: "SyntaxError: Cannot use 'yield' as a parameter name in strict mode." >-test/language/expressions/object/method-definition/yield-star-after-newline.js: >- default: "SyntaxError: Unexpected token '*'" >- strict mode: "SyntaxError: Unexpected token '*'" >-test/language/expressions/object/method-definition/yield-weak-binding.js: >- default: "SyntaxError: Unexpected number '3'" >- strict mode: "SyntaxError: Unexpected number '3'" > test/language/expressions/object/scope-gen-meth-body-lex-distinct.js: > default: 'Test262Error: Expected a SyntaxError to be thrown but no exception was thrown at all' > test/language/expressions/object/scope-gen-meth-param-elem-var-close.js: >@@ -6953,9 +6938,6 @@ test/language/global-code/script-decl-func-err-non-extensible.js: > test/language/global-code/script-decl-var-err.js: > default: 'Test262Error: Expected a TypeError to be thrown but no exception was thrown at all' > strict mode: 'Test262Error: Expected a TypeError to be thrown but no exception was thrown at all' >-test/language/identifiers/val-yield-strict.js: >- default: 'Test262: This statement should not be evaluated.' >- strict mode: "SyntaxError: Cannot use 'yield' as a variable name in strict mode." > test/language/literals/numeric/numeric-separator-literal-bil-bd-nsl-bd.js: > default: 'SyntaxError: No space between binary literal and identifier' > strict mode: 'SyntaxError: No space between binary literal and identifier' >@@ -7158,8 +7140,7 @@ test/language/module-code/instn-resolve-order-depth.js: > test/language/module-code/instn-resolve-order-src.js: > module: "SyntaxError: 'break' is only valid inside a switch or loop statement." > test/language/module-code/instn-star-as-props-dflt-skip.js: >- default: "SyntaxError: Unexpected token '{'. import call expects exactly one argument." >- strict mode: "SyntaxError: Unexpected token '{'. import call expects exactly one argument." >+ module: "SyntaxError: Unexpected identifier 'as'. Expected 'from' before exported module name." > test/language/module-code/instn-star-props-nrml.js: > module: "SyntaxError: Unexpected identifier 'as'. Expected 'from' before exported module name." > test/language/module-code/namespace/internals/define-own-property.js: >@@ -7193,24 +7174,6 @@ test/language/statements/class/class-name-ident-static.js: > test/language/statements/class/classelementname-abrupt-completion.js: > default: "SyntaxError: Unexpected token '}'. Expected an opening '(' before a method's parameter list." > strict mode: "SyntaxError: Unexpected token '}'. Expected an opening '(' before a method's parameter list." >-test/language/statements/class/definition/methods-gen-yield-as-function-expression-binding-identifier.js: >- default: "SyntaxError: Cannot use 'yield' as a function name in strict mode." >- strict mode: "SyntaxError: Cannot use 'yield' as a function name in strict mode." >-test/language/statements/class/definition/methods-gen-yield-as-identifier-in-nested-function.js: >- default: "SyntaxError: Unexpected keyword 'yield'. Cannot use yield expression out of generator." >- strict mode: "SyntaxError: Unexpected keyword 'yield'. Cannot use yield expression out of generator." >-test/language/statements/class/definition/methods-gen-yield-as-logical-or-expression.js: >- default: "SyntaxError: Unexpected token '?'" >- strict mode: "SyntaxError: Unexpected token '?'" >-test/language/statements/class/definition/methods-gen-yield-as-parameter.js: >- default: "SyntaxError: Cannot use 'yield' as a parameter name in strict mode." >- strict mode: "SyntaxError: Cannot use 'yield' as a parameter name in strict mode." >-test/language/statements/class/definition/methods-gen-yield-star-after-newline.js: >- default: "SyntaxError: Unexpected token '*'" >- strict mode: "SyntaxError: Unexpected token '*'" >-test/language/statements/class/definition/methods-gen-yield-weak-binding.js: >- default: "SyntaxError: Unexpected number '3'" >- strict mode: "SyntaxError: Unexpected number '3'" > test/language/statements/class/dstr-private-gen-meth-ary-init-iter-close.js: > default: "SyntaxError: Invalid character: '#'" > strict mode: "SyntaxError: Invalid character: '#'" >@@ -11073,9 +11036,6 @@ test/language/statements/labeled/value-yield-non-strict-escaped.js: > default: "SyntaxError: Unexpected escaped characters in keyword token: 'yi\\u0065ld'" > test/language/statements/labeled/value-yield-non-strict.js: > strict mode: "SyntaxError: Cannot use 'yield' as a label in strict mode." >-test/language/statements/labeled/value-yield-strict.js: >- default: 'Test262: This statement should not be evaluated.' >- strict mode: "SyntaxError: Cannot use 'yield' as a label in strict mode." > test/language/statements/let/block-local-closure-set-before-initialization.js: > default: 'Test262Error: Expected a ReferenceError to be thrown but no exception was thrown at all' > test/language/statements/let/syntax/attempt-to-redeclare-let-binding-with-function-declaration.js:
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 193053
:
358129
| 358277