Attachment 358273 Details for Bug 193122 – Patch v1

[patch] Patch v1

bug-193122-20190103130039.patch (text/plain), 2.71 KB, created by David Kilzer (:ddkilzer) on 2019-01-03 13:00:40 PST

(hide)

Description:

Filename:

MIME Type:

Creator: David Kilzer (:ddkilzer)

Created: 2019-01-03 13:00:40 PST

Size: 2.71 KB

patch

obsolete

>Subversion Revision: 239367
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 1ba42ea24ae1ba160de0d3ea98b9b42bd1f9d168..0ba40216b3c2e72df25c43205c59b3a16b482269 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,22 @@
>+2019-01-03  David Kilzer  <ddkilzer@apple.com>
>+
>+        Leak of WebCore::LibWebRTCCertificateGenerator::RTCCertificateGeneratorCallback (48 bytes) in com.apple.WebKit.WebContent running WebKit layout tests
>+        <https://webkit.org/b/193122>
>+        <rdar://problem/47022987>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Modules/mediastream/libwebrtc/LibWebRTCCertificateGenerator.cpp:
>+        (WebCore::LibWebRTCCertificateGenerator::RTCCertificateGeneratorCallback::AddRef const):
>+        (WebCore::LibWebRTCCertificateGenerator::RTCCertificateGeneratorCallback::Release const):
>+        - Remove `final` keyword so that
>+          `new rtc::RefCountedObject<RTCCertificateGeneratorCallback>()`
>+          can be called.
>+        (WebCore::LibWebRTCCertificateGenerator::generateCertificate):
>+        - To fix the leak call
>+          `new rtc::RefCountedObject<RTCCertificateGeneratorCallback>()`
>+          to create the object.
>+
> 2018-12-23  David Kilzer  <ddkilzer@apple.com>
> 
>         Leak of CMSampleBuffer (752 bytes) in com.apple.WebKit.WebContent running WebKit layout tests
>diff --git a/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCCertificateGenerator.cpp b/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCCertificateGenerator.cpp
>index 8a088be3e3cce151ff1ec5454976fb17edad8474..9687f45969c0a5810c17d3270cfdb0a0b57926da 100644
>--- a/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCCertificateGenerator.cpp
>+++ b/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCCertificateGenerator.cpp
>@@ -53,8 +53,8 @@ public:
>     {
>     }
> 
>-    void AddRef() const final { ref(); }
>-    rtc::RefCountReleaseStatus Release() const final
>+    void AddRef() const { ref(); }
>+    rtc::RefCountReleaseStatus Release() const
>     {
>         auto result = refCount() - 1;
>         deref();
>@@ -106,7 +106,7 @@ static inline rtc::KeyParams keyParamsFromCertificateType(const PeerConnectionBa
> 
> void generateCertificate(Ref<SecurityOrigin>&& origin, LibWebRTCProvider& provider, const PeerConnectionBackend::CertificateInformation& info, DOMPromiseDeferred<IDLInterface<RTCCertificate>>&& promise)
> {
>-    rtc::scoped_refptr<RTCCertificateGeneratorCallback> callback(new RTCCertificateGeneratorCallback(WTFMove(origin), WTFMove(promise)));
>+    rtc::scoped_refptr<RTCCertificateGeneratorCallback> callback(new rtc::RefCountedObject<RTCCertificateGeneratorCallback>(WTFMove(origin), WTFMove(promise)));
> 
>     absl::optional<uint64_t> expiresMs;
>     if (info.expires)

Actions: View | Formatted Diff | Diff

Attachments on bug 193122: 358273