Attachment 358248 Details for Bug 193102 – Proposed patch

[patch] Proposed patch

ews-build-checkPatchRelevance-earlier.patch (text/plain), 3.08 KB, created by Aakash Jain on 2019-01-03 03:12:16 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Aakash Jain

Created: 2019-01-03 03:12:16 PST

Size: 3.08 KB

patch

obsolete

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 239588)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,13 @@
>+2019-01-03  Aakash Jain  <aakash_jain@apple.com>
>+
>+        [ews-build] Check patch relevance before applying the patch
>+        https://bugs.webkit.org/show_bug.cgi?id=193102
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * BuildSlaveSupport/ews-build/factories.py:
>+        (Factory.__init__): Moved CheckPatchRelevance step to base class.
>+
> 2019-01-02  Alex Christensen  <achristensen@webkit.org>
> 
>         Homograph with LATIN SMALL LETTER R WITH FISHHOOK
>Index: Tools/BuildSlaveSupport/ews-build/factories.py
>===================================================================
>--- Tools/BuildSlaveSupport/ews-build/factories.py	(revision 239588)
>+++ Tools/BuildSlaveSupport/ews-build/factories.py	(working copy)
>@@ -30,9 +30,11 @@ Property = properties.Property
> 
> 
> class Factory(factory.BuildFactory):
>-    def __init__(self, platform, configuration=None, architectures=None, buildOnly=True, additionalArguments=None, **kwargs):
>+    def __init__(self, platform, configuration=None, architectures=None, buildOnly=True, additionalArguments=None, checkRelevance=False, **kwargs):
>         factory.BuildFactory.__init__(self)
>         self.addStep(ConfigureBuild(platform, configuration, architectures, buildOnly, additionalArguments))
>+        if checkRelevance:
>+            self.addStep(CheckPatchRelevance())
>         self.addStep(CheckOutSource())
> 
> 
>@@ -44,8 +46,7 @@ class StyleFactory(Factory):
> 
> class BindingsFactory(Factory):
>     def __init__(self, platform, configuration=None, architectures=None, additionalArguments=None, **kwargs):
>-        Factory.__init__(self, platform, configuration, architectures, False, additionalArguments)
>-        self.addStep(CheckPatchRelevance())
>+        Factory.__init__(self, platform, configuration, architectures, False, additionalArguments, checkRelevance=True)
>         self.addStep(RunBindingsTests())
> 
> 
>@@ -57,8 +58,7 @@ class WebKitPerlFactory(Factory):
> 
> class WebKitPyFactory(Factory):
>     def __init__(self, platform, configuration=None, architectures=None, additionalArguments=None, **kwargs):
>-        Factory.__init__(self, platform, configuration, architectures, False, additionalArguments)
>-        self.addStep(CheckPatchRelevance())
>+        Factory.__init__(self, platform, configuration, architectures, False, additionalArguments, checkRelevance=True)
>         self.addStep(RunWebKitPyTests())
> 
> 
>@@ -104,8 +104,7 @@ class TestFactory(Factory):
> 
> class JSCTestsFactory(Factory):
>     def __init__(self, platform, configuration='release', architectures=None, additionalArguments=None, **kwargs):
>-        Factory.__init__(self, platform, configuration, architectures, False, additionalArguments)
>-        self.addStep(CheckPatchRelevance())
>+        Factory.__init__(self, platform, configuration, architectures, False, additionalArguments, checkRelevance=True)
>         self.addStep(CompileJSCOnly())
>         self.addStep(UnApplyPatchIfRequired())
>         self.addStep(CompileJSCOnlyToT())

Actions: View | Formatted Diff | Diff

Attachments on bug 193102: 358248