Attachment 358240 Details for Bug 193099 – Patch

[patch] Patch

patch.txt (text/plain), 1.66 KB, created by Nikita Vasilyev on 2019-01-02 18:49:06 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Nikita Vasilyev

Created: 2019-01-02 18:49:06 PST

Size: 1.66 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index d0d8c6c2cb9..b8a6203c914 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,15 @@
>+2019-01-02  Nikita Vasilyev  <nvasilyev@apple.com>
>+
>+        Web Inspector: Styles: it shouldn't be possible to delete read-only properties
>+        https://bugs.webkit.org/show_bug.cgi?id=193099
>+        <rdar://problem/47016335>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js:
>+        (WI.SpreadsheetCSSStyleDeclarationEditor):
>+        Drive-by: Forward Delete should work the same way as Delete (Backspace).
>+
> 2018-12-21  Devin Rousso  <drousso@apple.com>
> 
>         Web Inspector: Styles Redesign: remove unused CSS style icons
>diff --git a/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js b/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js
>index e6cdb9013d8..2411bfee15a 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js
>@@ -533,7 +533,10 @@ WI.SpreadsheetCSSStyleDeclarationEditor = class SpreadsheetCSSStyleDeclarationEd
>                 event.stop();
>                 property.startEditingName();
>             }
>-        } else if (event.key === "Backspace") {
>+        } else if (event.key === "Backspace" || event.key === "Delete") {
>+            if (!this.style.editable)
>+                return;
>+
>             let [startIndex, endIndex] = this.selectionRange;
> 
>             let propertyIndexToSelect = NaN;

Actions: View | Formatted Diff | Diff

Attachments on bug 193099: 358240