Attachment 358233 Details for Bug 192124 – Patch

[patch] Patch

patch.txt (text/plain), 2.55 KB, created by Nikita Vasilyev on 2019-01-02 18:00:53 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Nikita Vasilyev

Created: 2019-01-02 18:00:53 PST

Size: 2.55 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index d0d8c6c2cb9..07329e397b2 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,17 @@
>+2018-12-27  Nikita Vasilyev  <nvasilyev@apple.com>
>+
>+        Web Inspector: Styles: selection lost when inspector is blurred
>+        https://bugs.webkit.org/show_bug.cgi?id=192124
>+        <rdar://problem/46800965>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css:
>+        (body:matches(.window-docked-inactive, .window-inactive) .spreadsheet-style-declaration-editor .property.selected):
>+        Selection should be gray when Web Inspector window isn't focused.
>+
>+        * UserInterface/Views/SpreadsheetStyleProperty.js:
>+
> 2018-12-21  Devin Rousso  <drousso@apple.com>
> 
>         Web Inspector: Styles Redesign: remove unused CSS style icons
>diff --git a/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css b/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css
>index beb712841e2..481253c6a04 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css
>+++ b/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css
>@@ -133,6 +133,10 @@
>     background-color: var(--background-color-selected);
> }
> 
>+body:matches(.window-docked-inactive, .window-inactive) .spreadsheet-style-declaration-editor .property.selected {
>+    background-color: var(--selected-background-color-unfocused);
>+}
>+
> .spreadsheet-style-declaration-editor .property.selected:focus {
>     border-left-color: var(--border-color-selected);
> }
>diff --git a/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js b/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js
>index a41f95dfd64..d454fa6020f 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js
>@@ -54,6 +54,10 @@ WI.SpreadsheetStyleProperty = class SpreadsheetStyleProperty extends WI.Object
>             this._element.tabIndex = -1;
> 
>             this._element.addEventListener("blur", (event) => {
>+                // Keep selection after tabbing out of Web Inspector window and back.
>+                if (document.activeElement === this._element)
>+                    return;
>+
>                 if (this._delegate.spreadsheetStylePropertyBlur)
>                     this._delegate.spreadsheetStylePropertyBlur(event, this);
>             });

Actions: View | Formatted Diff | Diff

Attachments on bug 192124: 358233 | 358235