WebKit Bugzilla
Attachment 358229 Details for
Bug 193096
: Fix an assertion in UniqueIDBDatabase
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-193096-20190102172425.patch (text/plain), 1.76 KB, created by
Sihui Liu
on 2019-01-02 17:24:26 PST
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Sihui Liu
Created:
2019-01-02 17:24:26 PST
Size:
1.76 KB
patch
obsolete
>Subversion Revision: 239582 >diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog >index 510b23b351439a44bc7ab2072803debab0d66f88..7776c635f948152764f3cf2550c91ca3f7c0e0b2 100644 >--- a/Source/WebCore/ChangeLog >+++ b/Source/WebCore/ChangeLog >@@ -1,3 +1,16 @@ >+2019-01-02 Sihui Liu <sihui_liu@apple.com> >+ >+ Fix an assertion in UniqueIDBDatabase >+ https://bugs.webkit.org/show_bug.cgi?id=193096 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ m_objectStoreTransactionCounts.count(objectStore) == 1 in UniqueIDBDatabase::operationAndTransactionTimerFired() >+ is not necessarily true because m_objectStoreTransactionCounts may be cleared in immediateCloseForUserDelete. >+ >+ * Modules/indexeddb/server/UniqueIDBDatabase.cpp: >+ (WebCore::IDBServer::UniqueIDBDatabase::operationAndTransactionTimerFired): >+ > 2019-01-02 Charles Vazac <cvazac@gmail.com> > > Fix resourcetimingbufferfull bubbles attribute >diff --git a/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp b/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp >index 4e2a2df6b7a37777229cc8f2d5a44985b668c673..a28ce40545b230eb6ddf58aba6d8baa9ef9cc770 100644 >--- a/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp >+++ b/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp >@@ -1580,7 +1580,7 @@ void UniqueIDBDatabase::operationAndTransactionTimerFired() > m_objectStoreTransactionCounts.add(objectStore); > if (!transaction->isReadOnly()) { > m_objectStoreWriteTransactions.add(objectStore); >- ASSERT(m_objectStoreTransactionCounts.count(objectStore) == 1); >+ ASSERT(m_objectStoreTransactionCounts.count(objectStore) == 1 || m_hardClosedForUserDelete); > } > } >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 193096
: 358229